[HOLD for payment 2022-09-16] [$250] mWeb/Safari - Log in/Payments- Blue border appears in password field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #10162

Action Performed:

1. Go to staging.new.expensify.com
2. In log in page put your user name
3. Tap Continue

Expected Result:

Blue border does not appear in password field

Actual Result:

Blue border appears in password field

Workaround:

Unknown

Platform:

Where is this issue occurring?

-mWeb/safari

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5702372_RPReplay_Final1661354040.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhairyasenjaliya & Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661107700990479

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dhairyasenjaliya]

issue reported here on slack : https://expensify.slack.com/archives/C01GTK53T8Q/p1661107700990479

[roryabraham]

Going to look into this

[Beamanator]

Also going to look into this 😅

[Beamanator]

here's what I see in Safari web, both in production & staging:

[roryabraham]

I've been able to reproduce this on dev:

[melvin-bot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[roryabraham]

Demoted. Interestingly this will disappear if you refresh the page or do anything that causes a re-render. This makes me think it might be a react-native-web bug, and not a problem with one of our styles

[stephanieelliott]

What do you think @roryabraham, should we hire someone to investigate this? Or is there a pretty strong likelihood that this is a RN bug and isn't something we'll be able to fix?

[melvin-bot]

@deetergp, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

I think we should make it external. That it's a RNW is just a hunch, and even if that's right we can fix it, because we have our own fork of react-native-web we use.

[melvin-bot]

@deetergp, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[stephanieelliott]

Posted to Upwork: https://www.upwork.com/jobs/~01091321c3578832d2

[dhairyasenjaliya]

am I eligible for reporting this issue as I have logged this issue in slack before listed in git https://expensify.slack.com/archives/C01GTK53T8Q/p1661107700990479

Cc @stephanieelliott @deetergp

[stephanieelliott]

@railway17 Upwork offer sent!

@mananjadhav Please grab the job in Upwork when you get a chance! https://www.upwork.com/jobs/~01091321c3578832d2

[railway17]

@stephanieelliott
I've created a PR here.
Please assign reviewers.
Thank you

[mananjadhav]

@kbecciv I am on not able to reproduce this on latest version on staging as well as local. I am on version v1.1.96-5.

@railway17 Are you able to reproduce on the latest version?

[railway17]

@mananjadhav
I've just tested in the v1.1.96-5 version, but still reproducible in desktop safari.
But couldn't reproduce it in the mobile safari that I've posted in my proposal.
I think this issue will be visible if we test under some conditions.

[mananjadhav]

What is your Safari and Mac OS version ?

[railway17]

Here are my versions, @mananjadhav

[dhairyasenjaliya]

@mananjadhav the actual issue is different in mWeb/safari just try to change the password you will notice whenever it is secureTextInput with (eye icon) it has some weird blue opacity border

[dhairyasenjaliya]

@mananjadhav the actual issue is different in mWeb/safari just try to change the password you will notice whenever it is secureTextInput with (eye icon) it has some weird blue opacity border

• stagging + local both affected

[railway17]

@dhairyasenjaliya
Which iOS version do you use?
I think my PR will resolve the issue on the mobile as well as desktop (because it is style issue), but couldn't reproduce it on my phone.

[dhairyasenjaliya]

@railway17 you have to check in mobile web (specific M-Safari)

[railway17]

You mean do you want to see the screenshot from my phone?

[railway17]

@dhairyasenjaliya
Looks like I am about to reproduce the issue in mobile which is a lower iOS version.
I will upload my videos for both original and fixed ones soon.
Thank you

[railway17]

ICQW3388.MP4

OCLS3801.MP4

@dhairyasenjaliya , @mananjadhav
I just reproduce the issue on the mobile phone and attached 2 videos with my fix.
Please take a look and let me know
Thank you

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mananjadhav]

@mvtglobally I am still able to reproduce this on iOS 14.4. I can see the previous dev screenshot was also from iOS 14.4. So you might want to take a look at the older versions maybe?

---

Quick update is that I was finally able to reproduce and I've reviewed the PR to confirm the fix works. Thanks @railway17 @dhairyasenjaliya

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.98-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 10535: set the outline style based on outline width #10769

If no regressions arise, payment will be issued on 2022-09-16. 🎊

[dhairyasenjaliya]

@stephanieelliott Upwork job for reporting issue is missing

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[stephanieelliott]

Hey @dhairyasenjaliya there is no separate job for reporting -- please apply on the Upwork post and I will pay you on that 😊 https://www.upwork.com/jobs/~01091321c3578832d2

[dhairyasenjaliya]

Hey @dhairyasenjaliya there is no separate job for reporting -- please apply on the Upwork post and I will pay you on that 😊 https://www.upwork.com/jobs/~01091321c3578832d2

Ah thanks applied

[stephanieelliott]

All paid!