Deploy Checklist: New Expensify 2022-08-23

[OSBotify]

Release Version: 1.1.89-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Use better unread icon #10041
• Refactor part of Wallet_Activate into VerifyIdentity #10053
• IOS/Android - Payments - Making payment method default will have keyboard overlapping password prompt  #10162
• Refactor OpenReport API call for Report GetHistory #10164
• Add some docs for pattern B #10321
• Handling display of errors when MakeDefaultPaymentMethod fails #10322
• Refactor request call page to use Form #10402
• Add borderBottom styles on the WorkspaceMembersPage #10403
• Use GithubUtils to access octokit #10415
• Make sure we unsubscribe the pressOnEnter handler for the login form when we render the password form #10418
• Fix overflow issue on login screen #10425
• [NO QA] Update Expensify Common commit #10429
• Remove blocking loading spinner from WorkspacePagewithSections #10432
• [No QA] Use published version of Expensify react-native-web fork #10434
• Refactor WorkspaceSettingsPage #10438
• Update to node 16 and npm 8 via nvm and updated many node packages #10439
• Refactor Terms step of Wallet_Activate into AcceptWalletTerms #10443
• Refactor WorkspaceInitialPage to no longer use withFullPolicy #10444
• [NO QA]Ignore all PropTypes.arrayOf(PropTypes.object) #10448
• Refactor WorkspaceBankAccountPage #10454
• Use main now that andrew-npm-8 is merged #10463
• Ignore forbid-prop-types to fix lint #10464
• fix: Attachment - PDF file is not shown in Preview Page #10465
• Ignore login's case when generating the default avatar #10466
• Fix the issue with user not being able to send the video on Android #10467
• add URLs to OfflineWithFeedback Component docs #10476
• Manually revert 10069 #10479
• [No QA] Update Offline UX docs #10480
• Wrap setString instead of using Clipboard object #10540
• [CP Stg] Move report fetch to ReportScreen to populate props.report #10545
• [CP Stg] Remove LayoutAnimation from KeyboardSpacer #10546
• Use defaultProps instead of hardcoded value #10567

Deploy Blockers:

• Desktop - "You appear to be offline" message and grey indicator are missing, chat conversation is not shown when user is offline  #10424
• Android - Payments- White space is displayed in Settings after make default payment #10520
• Web - User detail - Unable to copy the email address #10522
• [Bug] No Offline Indicator displayed after going offline #10524
• Web - New Group - Aviators icon is missing when create a new group #10527
• Web - Login - Infinite spinner when logging in to the specified account #10531
• Web - Login - Infinite spinner when logging in to a specified account #10534
• [HOLD for payment 2022-09-16] [$250] mWeb/Safari - Log in/Payments- Blue border appears in password field #10535
• Desktop - Infinite loading when open App #10536
• Web - Workspace- User receives error message in JS console when offline in General settings #10538
• [$250] Android - Blank space displayed under compose box on new conversations #10539
• mweb/Desktop - Growl - User does not receive a growl when offline in workspace options #10547
• [Bug] IOS/Android/Desktop - Messages are showing sent multiple times for sender #10550
• Desktop - Offline - Error message while inviting user to the Workspace #10552

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.89-0 🚀

[neil-marcellini]

I was not able to reproduce #10524 on iOS staging, so I don't think we should block on this. I'll test on Android soon.

[mvtglobally]

@AndrewGable @sketchydroide
Interim summary
PR #10041 is failing due to #10528. Not a blocker. Checking off
PRs #10162 & 10322 are failing due to blocker #10520
PR #10479 is failing due to #10524

[sketchydroide]

we have set #10520 as not a blocker for now as it's behind a closed beta
is there a way to still test #10162 & #10322?

[sketchydroide]

#10524 does not seems to be consistent, and set it as not a blocker
can you still test #10479?

[mvtglobally]

@sketchydroide We tested #10162 & #10322 and if linked issues are not blockers, I guess we can check them off. Rest of the environments are pass.

[sketchydroide]

@mvtglobally how about
#10432
#10444
and
#10479
?

[Julesssss]

Checked off #10535 as the deploy blocker label has been removed

[mvtglobally]

@sketchydroide PRs #10432 & #10444. Team is facing few JS Console errors when offline. PROD experience is different, but we are not sure if these are expected as user is offline, or its actually failing PR. #10538

[sketchydroide]

I think those are expected is a user is offline

[sketchydroide]

@cead22 just gave a good feedback on the GH, if that is what was blocking the other 2 items we can check them off

[sketchydroide]

@mvtglobally last one #10479 🙏🏼 ?

[mvtglobally]

few more min....

[mvtglobally]

@sketchydroide PR #10479 is failing due to #10524. Since #10524 is no longer a blocker. Are we ok to check off?
Only Android is impacted. Other platforms are PASS

[sketchydroide]

yes, let's @mvtglobally

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.89-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.89-1 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.89-2 🚀

[mvtglobally]

checking New CPs. Regression is almost completed

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.89-2 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.89-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.89-3 has been deployed to staging 🎉

[mvtglobally]

Last CP #10545 (comment)

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.89-4 🚀

[mvtglobally]

@sketchydroide CP #10567 looks good and Issue no longer repro

Recording.1626.mp4

Record_2022-08-25-19-05-40_4f9154176b47c00da84e32064abf1c48.mp4

[sketchydroide]

[sketchydroide]

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.89-4 has been deployed to staging 🎉