Desktop - Offline - Error message while inviting user to the Workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Desktop App
2. Go to Setting - Workspace - Members
3. Turn off the network
4. Try to invite user to the workspace

Expected Result:

Member should be added to the list and still present once device is online

Actual Result:

Error message appears: "An error occurred inviting the user to the workspace, please try again"

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Desktop App

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5702650_Screen_Recording_2022-08-24_at_20.53.02.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ctkochan22]

Wait, is this a blocker? Is the refactor out for this?

Seems like offline handling will be handled in the refactor?

[ctkochan22]

cc @arosiclair

[ctkochan22]

@kbecciv How are you "turning the network off" specifically?

[kbecciv]

@ctkochan22 Yes, QA team was following the steps in TR.

[ctkochan22]

Okay. I was just wondering. I tried with using the Network tab in the developer console for desktop and wasn't able to reproduce. Let me try turning off the wifi

[ctkochan22]

Tried turning my computer wifi off. Button is working as expected. Disabled.

The WorkspaceInvitePage just has the FormAlertWithSubmitButton button implemented. I don't see anything in the code that would do something like "Member should be added to the list and still present once device is online"

[sketchydroide]

I can't replicate this as well, in fact the green button is not even enabled while in offline mode

[roryabraham]

Not able to reproduce this either

[sketchydroide]

Removing the blocker, @kbecciv can you please test again on the latest version

[neil-marcellini]

I was able to reproduce on desktop staging v1.1.89-2

Offline

Back online

[mountiny]

I think this command is not using a new API yet:

App/src/libs/actions/Policy.js

Lines 322 to 370 in e7503a0

	/**
	* Merges the passed in login into the specified policy
	*
	* @param {Array<String>} logins
	* @param {String} welcomeNote
	* @param {String} policyID
	*/
	function invite(logins, welcomeNote, policyID) {
	const key = `${ONYXKEYS.COLLECTION.POLICY}${policyID}`;
	const newEmployeeList = _.map(logins, login => OptionsListUtils.addSMSDomainIfPhoneNumber(login));
	// Make a shallow copy to preserve original data, and concat the login
	const policy = _.clone(allPolicies[key]);
	policy.employeeList = [...policy.employeeList, ...newEmployeeList];
	policy.alertMessage = '';
	// Optimistically add the user to the policy
	Onyx.merge(key, policy);
	// Make the API call to merge the login into the policy
	DeprecatedAPI.Policy_Employees_Merge({
	employees: JSON.stringify(_.map(logins, login => ({email: login}))),
	welcomeNote,
	policyID,
	})
	.then((data) => {
	// Save the personalDetails for the invited user in Onyx and fetch the latest policyExpenseChats
	if (data.jsonCode === 200) {
	Onyx.merge(ONYXKEYS.PERSONAL_DETAILS, PersonalDetails.formatPersonalDetails(data.personalDetails));
	Navigation.goBack();
	if (!_.isEmpty(data.policyExpenseChatIDs)) {
	Report.fetchChatReportsByIDs(data.policyExpenseChatIDs);
	}
	return;
	}
	// If the operation failed, undo the optimistic addition
	const policyDataWithoutLogin = _.clone(allPolicies[key]);
	policyDataWithoutLogin.employeeList = _.without(allPolicies[key].employeeList, ...newEmployeeList);
	// Show the user feedback that the addition failed
	policyDataWithoutLogin.alertMessage = Localize.translateLocal('workspace.invite.genericFailureMessage');
	if (data.jsonCode === 402) {
	policyDataWithoutLogin.alertMessage += ` ${Localize.translateLocal('workspace.invite.pleaseEnterValidLogin')}`;
	}
	Onyx.set(key, policyDataWithoutLogin);
	});
	}

[arosiclair]

I think this command is not using a new API yet:

Yeah this is not supposed to work offline currently. However, the invite button should be blocked while offline to begin with. I was able to repro using v1.1.91-0 and the offline indicator doesn't always appear when I disable Wi-Fi on my macbook:

[ctkochan22]

Looking at the PR in teh checklist, it could be the case on prod too?

[neil-marcellini]

Since this is not expected to work offline and the only problem is that the invite button is not disabled, it sounds like the core issue is that the offline status is not detected. I'm closing this in favor of #10524.