[Bug] No Offline Indicator displayed after going offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Go to any chat
4. Go offline

Expected Result:

offline message displayed below after go offline

Actual Result:

No offline message displayed below after go offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Desktop App

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

Not reproducible on iOS staging so I'll remove the deploy blocker label.

[sketchydroide]

this might be duplicated with the one I just linked

[neil-marcellini]

I'm unable to test on Android right now, it keeps crashing.

[neil-marcellini]

I think this issue title and description is better so I'm going to close the other issue and update this one to include the desktop platform.

[neil-marcellini]

I'm un-assigning and posting this to n7 in Slack so that someone can take it on with a higher priority. I'll also make it daily. This issue is causing a lot of QA to fail.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[grgia]

Offline message seems to be working on staging web/mobile ios/desktop so far, will continue trying to replicate

[grgia]

v1.1.94-2 - iOS is good
v1.1.94-3 - Desktop is good
v1.1.94-3 - Android is good

[grgia]

Changing label to daily seeing as there's indication of a regression.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@grgia Eep! 4 days overdue now. Issues have feelings too...

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[grgia]

I'm not able to reproduce the sign-on offline issue on staging/web/mobile. @neil-marcellini are you still able to? Otherwise, we can probably close out for now.
That said, I do still notice that when you log off while offline, you can't sign back in until you refresh or close/reopen the app (which I'm assuming is because of how we clear onyx values on sign-out). This doesn't happen when you go offline and online from the sign-on page otherwise, only after signing out while offline.

[neil-marcellini]

I'll see if I can still reproduce this.

That said, I do still notice that when you log off while offline, you can't sign back in until you refresh or close/reopen the app (which I'm assuming is because of how we clear onyx values on sign-out). This doesn't happen when you go offline and online from the sign-on page otherwise, only after signing out while offline.

That sounds like another bug, please create a separate issue for it.

[neil-marcellini]

I can reproduce this.

Screen.Recording.2022-10-04.at.9.54.57.AM.mov

[neil-marcellini]

After looking at the logs more, I don't think this has anything to do with clearing Onyx.

If I comment out this line then it works. I think the problem is that when we log out we stop listening to the NetInfo here, and when we log back in we never start listening again. I think we should always listen to the net info.

App/src/libs/actions/Session/index.js

Line 376 in 03fa7f5

NetworkConnection.stopListeningForReconnect();

[grgia]

I'll see if I can replicate it today and if so, I can look more into that suggestion.

[grgia]

I met with Neil and this is what we discussed:

We use NetworkConnection functions to handle our listeners.
We start listening for Network Connection when we build the App here, which was why removing the listeners during sign-off required a refresh in order to see the indicators again.
For now, a simple solution in this PR is to not stop listening for Network Connection, since the offline indicator is used on the sign-in page.

[grgia]

Not Overdue