Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap setString instead of using Clipboard object #10540

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Wrap setString instead of using Clipboard object #10540

merged 1 commit into from
Aug 24, 2022

Conversation

AndrewGable
Copy link
Contributor

Details

I believe the issue is that Clipboard was slightly tweaked in an update of react-native-web breaking our ability to export it as an object. This wraps the setString method instead of directly accessing that method via the object in both native and web platforms.

Fixed Issues

$ #10522

Tests

  1. Go to a chat
  2. Click on a name
  3. Click the clipboard icon
  4. Verify no error ✅
  5. Verify email is copied to clipboard

Screenshots

Screen Shot 2022-08-24 at 7 22 44 PM

Screen Shot 2022-08-24 at 7 20 59 PM

@AndrewGable AndrewGable self-assigned this Aug 24, 2022
@AndrewGable AndrewGable requested a review from a team as a code owner August 24, 2022 17:28
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team August 24, 2022 17:28
mountiny
mountiny approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@sketchydroide
Copy link
Contributor

looks good

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@AndrewGable
Copy link
Contributor Author

Got many reviews, merging and CP-ing

@AndrewGable AndrewGable merged commit a06404b into main Aug 24, 2022
@AndrewGable AndrewGable deleted the andrew-clippy branch August 24, 2022 18:13
OSBotify pushed a commit that referenced this pull request Aug 24, 2022
@AndrewGable @OSBotify
Merge pull request #10540 from Expensify/andrew-clippy
938b7ad 
Wrap setString instead of using Clipboard object

(cherry picked from commit a06404b)
@OSBotify OSBotify mentioned this pull request Aug 24, 2022
Merged
OSBotify added a commit that referenced this pull request Aug 24, 2022
@OSBotify
Merge pull request #10543 from Expensify/OSBotify-cherry-pick-staging…
8c4e9b1 
…-10540

🍒 Cherry pick PR #10540 to staging 🍒
@OSBotify OSBotify mentioned this pull request Aug 24, 2022
Closed
48 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @AndrewGable in version: 1.1.89-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Aug 25, 2022 •
edited
Loading

Pretty sure this is a regressions so added to the RCA sheet, https://docs.google.com/spreadsheets/d/1u73RE8J1DdX3mDohV1RXgulF6_cke3N_a15Sk-UUdQo/edit#gid=0

dropped note in #contributor-plus too
https://expensify.slack.com/archives/C02NK2DQWUX/p1661460296325789

@OSBotify OSBotify mentioned this pull request Aug 26, 2022
Closed
25 tasks
@OSBotify OSBotify mentioned this pull request Oct 14, 2022
Closed
53 tasks
@OSBotify OSBotify mentioned this pull request May 2, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@marcochavezf marcochavezf marcochavezf approved these changes

@sketchydroide sketchydroide sketchydroide approved these changes

@cead22 cead22 Awaiting requested review from cead22

@roryabraham roryabraham Awaiting requested review from roryabraham

@techievivek techievivek Awaiting requested review from techievivek

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndrewGable @sketchydroide @OSBotify @mallenexpensify @marcochavezf @mountiny