Deploy Checklist: New Expensify 2023-05-02

[OSBotify]

Release Version: 1.3.8-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Make sure we unsubscribe the pressOnEnter handler for the login form when we render the password form #10418
• fix: Attachment - PDF file is not shown in Preview Page #10465
• Wrap setString instead of using Clipboard object #10540
• [CP Stg] Move report fetch to ReportScreen to populate props.report #10545
• [CP Stg] Remove LayoutAnimation from KeyboardSpacer #10546
• Refactor custom unit rate update  #10557
• Use defaultProps instead of hardcoded value #10567
• Revert "Refactor ValidateLogin" #10588
• Fix crash from AvatarWithIndicator error checking methods #10652
• [No QA] Pull latest code after waiting for turnstyle but before creating new branch #10660
• Fix for delete comment refactor #10764
• Revert "update react-native-svg version" #10775
• Use sequenceNumber and reportActionID for now #10779
• Show deleted messages with a strike-through when offline #10780
• Add resendLink message to successData #10783
• [NO QA] Update iOS cert and provisioning profile #10844
• [No QA] Fetch full PR object to fix CPs #10856
• Attempt to workaround a workflow CP edge case #10867
• Partial revert of "Use window.location.href for current URL" #10908
• [No QA] Revert "Toggle staging and production server api" #10920
• CP a useless commit to fix failed release #10942
• Remove usages of onyxRates #10974
• Revert "Refactor withFullPolicy" #10979
• Add missing code from main into staging branch #10995
• Dummy change to allow new staging CP #11000
• Omit default Avatar param to prevent crash on app start #11006
• Use existing personal details' avatar when it exists #11022
• Add missing alternateText option in option #11023
• Only use personal detail login as alternateText if we're not making the option for a report #11029
• Remove offline message from BaseOptionsSelector #11173
• [No QA] Fix syntax error in upload_symbols_to_crashlytics #11182
• Correct the Onyx beta key that sidebar connects to #11188
• Revert "OptionsSelector - Migrate setNativeProps to state" #11240
• Add teamdot check to SideBarUtils.js #11244
• [CP Staging] Pass report instead of reportID to ReportActionItem #11303
• Fix onfido flow #11466
• Add early return to ActiveClientManager #11539
• [CP Staging] save routingNumber and accountNumber in connectBankAccountManually #11556
• Fix masked account number and default values #11616
• Check for unread reports at the end of the filter logic #11631
• Only show reports without comments if they are non-archived policy rooms #11634
• [No QA] Revert "[Refactor] Use new API Command: VerifyIdentityForBankAccount" #11702
• Make sure that archived reports are shown properly in the LHN and the search options #11725
• Refactor PLAID_DATA and fix plaid bankAccounts selector #11750
• Go back to lower version of onyx #11759
• [No QA]Fix Free Workspace transitions, add Admin badge to all admins #11774
• Fix policy name when creating a workspace for another user #11831
• Re-render ReportFooter when transitioning to new chat #11853
• Revert "Update handling so that Concierge link redirects to chat" #11909
• [No QA] Remove pip install for wheel #11939
• [No QA] Upgrade Fastlane #11942
• Upgrade react-navigation/drawer to use our fork #11944
• Update expensify-common #11996
• Show Default Rooms when there is a team.expensify.com account on the report #12013
• [CP Staging] Fix hasExpensifyGuidesEmails call #12038
• [No QA] Update to macos-12 and XCode 14 in GitHub Actions #12068
• [No QA] Upgrade actions/checkout, actions/setup-node, ruby/setup-ruby to latest #12072
• [No QA] Specify developer team to sign generated projects #12084
• [No QA] Disable signing for generated projects #12092
• Onyx package revert #12099
• Revert "Upgrade react-native-svg to 13.4.0" #12176
• Use Onyx set if creating new report #12192
• Add loading spinner to IOUConfirmationList #12216
• [CP Staging] Revert PR 11907 which introduced missing FAB bug #12336
• [NO-QA] Update hermes-pods manually to resolve iOS build issue #12342
• Add errors object back to menu item, remove unused isPolicy #12460
• Revert PR11313 #12468
• [NO-QA] Resolve upstream ReactNative android build blocker #12510
• [NO-QA] Lock Android Hermes gradle version #12525
• Stop using deprecated jcenter repository for android dependencies #12532
• fix crash on profile detail #12533
• Pass array to navigateToAndOpenReport instead of string #12679
• Remove renderCell method as it's no longer needed and causes errors #12688
• Reverts elements from #12169 #12722
• [NoQA] Smarter regex for parsing No QA PRs #12754
• Splash Web - Fix mapping of production logo and do work only after DOM is ready #12785
• [CP Staging] Fix Success / Danger Button Text Color, Fix Growl Colors #12829
• [No QA]Add Browserstack API call to staging deploys #12830
• [No QA]Attempt to fix iOS uploads to browserstack with different path #12855
• Revert "removed resetting the report fields to allow user to operate multiple actions on same popover" #12897
• [No QA] Fix small button padding #12959
• Revert "Merge pull request #12648 from margelo/@thomas/fast-image-cac… #13010
• Revert "refactor navigation modal card styles" #13014
• Only navigate to chat reports #13028
• Sort archived rooms using Unix epoch #13093
• fix android keyboard issue #13106
• Fix autofill styles #13119
• Dark Picker Icon Colour Scheme Added #13142
• Fix autofill colors #13164
• Add a color to the options in the picker when using Windows #13174
• Revert filtering out workspaces with pending delete action #13201
• Update Onfido to latest to resolve deploy issues #13284
• [CP Staging] Changed border style #13298
• Revert "Display banner to enable 2FA when setting up VBBA" #13407
• Refactor the function for filtering the currency list #13412
• fix "Upload photo" popup menu not hiding #13448
• Remove extra flex from style #13475
• Stop displaying Closed Account message when the user starts typing #13519
• Check hasOutstandingIOU in money requests #13522
• Flatten styles to avoid crash #13525
• fix button position #13530
• Report can be a {}, improve check for emptyness/falsey #13531
• fix error message style issue on OfflineWithFeedback #13535
• Make sure that we pass markdown to parser when getting the parsed originalCommentHTML #13703
• Revert "Load pdfjs webworker script from source" #13707
• Fix bad CP by defining originalCommentHTML #13711
• Force a staging build/deploy #13712
• Revert "Use Onyx.clear to preserve state when logging out" #13758
• Removed forgotten code that is not required after removing onFocus #14115
• Return to createPortal to properly recalculate tooltipTextWidth #14171
• [CP Staging] Fix crash after log out #14450
• [No QA] Filter out reportActionID-keyed Onyx updates #14455
• Revert "[No QA] Filter out reportActionID-keyed Onyx updates" #14484
• Fix missing import preventing opening Plaid modal #14508
• Remove left padding for prefix #14628
• fix typo when measure time on ReportActionsView #14663
• Fix OptionRow shouldComponentUpdate #14791
• correct file uri set order #14823
• Revert 'fix: Timezone changes to some 1st option in the list while pressing the enter key' #14826
• Make sure amount is string before trimming #14850
• Check whether option row changed focus before re-rendering #14856
• change maxInputLength default value to undefined from -1 #14921
• [CP Staging] Get route.params.openOnAdminRoom if exists #14955
• Revert "Conditionally require password for adding a debit card" #15217
• Revert "Open a test tools modal with 5 taps on dev" #15417
• Revert "replace onModalHide with onDismiss for the web" #15563
• Decode transaction messages because they may have HTML Entities #15578
• Implement Invite message page #15672
• Remove accountID param when signing with SigninUser command #15709
• Revert "Show all Expensify logins in Contact Methods page & view each in new Contact Method Details page" #15761
• Revert "Make status bar transparent on android" #15771
• Fix navigation to Concierge chat after sign-up/sign-in #15788
• Fix Static emoji autosuggestion issues #15871
• Always call OpenReport when deeplinking within the app #15897
• [NO QA] Fix leftover review comments on App/pull/15897 #15904
• Fix opening oldDot links when offline #15923
• Ensure OpenReport is always called when deeplinking from an outside source #15994
• feat: magic code input (passwordless login) #16076
• fix/15438: regression test #16397
• Fix getSmallSizeAvatar to block url is not from cloudfront #16441
• [No QA] Update xcode version #16540
• fix: show workspace name in search preview for policy expense chats #16554
• Revert "Make optimistic reportActions appear last" #16559
• Get PlaidData values #16607
• Revert "Emoji search on mobile" #16659
• Fix propsRef initialization in native PlaidLink component #16778
• Remove incorrect this from replaceEmojis function #16902
• [CP Staging] Fix infinity loading display for inaccessible report #16918
• show compose box before report is ready after logout #16922
• Update optimistic data to match IOU action notification templates, send back additional data needed by Settle Up templates #17090
• Fix automatic authentication with magic link on mobile native #17141
• Update Gemfile.lock as it's out of date with Gemfile #17309
• Fix: Can delete attachments in archived workspace #17329
• Import correct CONST to unbreak notifications #17352
• Fix: Redundant URL param openOnAdminRoom on log out #17447
• Revert: 17138 17360 listen keydown from user #17475
• Fix: Regression of console error #17494
• fix: inline display for comment links #17496
• Fix/17212: Also update html message and get last message in LHN when edit offline #17586
• Revert "Allow keyboard shortcuts to work on native devices" #17592
• Revert "Merge pull request #17310 from akinwale/task-16946" #17618
• [NO QA] Show archived rooms without participants in the LHN #17694
• Revert "Use local SVG for concierge icon" #17697
• Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message #17704
• Revert "Merge pull request #17321 from allroundexperts/fix-16521" #17739
• Remove this so it doesn't crash after building it #17792
• Fix: RBR not show on error workspace in Workspace List page #17902
• [Onfido] Fix use of locale in Onfido #17943
• Fix: Some inputs are not focused automatically #17953
• Fix issues from unpopulated personal details #17984
• Fix undefined personal details access causing crash when calling getOptions #17988
• Add new vertical line separator instead of borderRight #18022
• [No QA] Add green dot in LHN when chat is unread with mention #18038
• Fix: Current currency is not highlighted and not marked #18059
• fix: web does not show not show notifications for not active window #18065
• Fix: Description menu item is not disabled on confirm #18066
• [No QA] Implement the SubScript avatar for workspace money requests #18085
• Add margin above Remove button in Contact Method Detail screen #18087
• [PhoneNumber-Verification 2] Display only valid numbers in user search. #18103
• Allow navigating to public announce rooms as the initial report after signing in/signing up #18114
• Fix: Dev error when not grant camera permission on native #18126
• Fix GBR and RBR show up at the same time in the LHN #18137
• Fix applying styling when it want to apply opacity on OpacityView #18153
• fix: re-add placeholder text inside base option selector #18155
• [NoQA] Add falsey checks and _.compact() to places where we access SMS logins from personal details #18159
• Fix form terminology #18160
• [NoQA] Remove unnecessary participants filtering #18173
• [Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18193
• Prevent emoji suggestions flicker on file picker opening on desktop web #18227
• Fix: Copying the messages and marking a message in between as unread generates 'new' in the text #18228
• Fix email keyboard type #18236
• [Icon Size] GBR, RBR & related icon size 20x20 #18242
• Fix iOS Webp Download #18256
• Feat: Hide member if no errors and deletion is pending #18257
• Update react-native-onyx to 1.0.41: Removes AsyncStorage from Onyx #18261
• Remove the blink_input_opacity_to_prevent_scrolling_when_focus hack #18266
• [No QA] Fix the padding on the subscript avatar #18275
• fix add reaction icon position changed when user add emoji #18276

Internal QA:

• Add leaveRoom action #15392 - @marcochavezf
• Autofocus magic code input #15101 - @francoisl

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[marcaaron]

Heads up we're closing this one and going to manually create the checklist.

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[mvtglobally]

QA did not start yet. Waiting for the checklist verification. https://expensify.slack.com/archives/C9YU7BX5M/p1683072509727969?thread_ts=1683040298.909869&channel=C9YU7BX5M&message_ts=1683072509.727969