[No QA] Filter out reportActionID-keyed Onyx updates

[roryabraham]

Details

This is a temporary workaround while we migrate Onyx data from being keyed by sequence number to being keyed by reportActionID.

Fixed Issues

$ #14452

Tests

Just automated tests and basic regressions.

• Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

None.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web.mov

Mobile Web - Chrome

AndroidWeb.mov

Mobile Web - Safari

iOSWeb.mov

Desktop

Desktop.mov

iOS

iOS.mov

Android

screen-20230120-184201.mp4

[melvin-bot]

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[puneetlath]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[puneetlath]

Looks good to me!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	695.327 ms → 716.087 ms (+20.760 ms, +3.0%)
Open Search Page TTI	609.272 ms → 615.773 ms (+6.502 ms, +1.1%)
App start nativeLaunch	19.129 ms → 19.516 ms (+0.387 ms, +2.0%)
App start runJsBundle	196.129 ms → 196.276 ms (+0.147 ms, ±0.0%)
App start regularAppStart	0.021 ms → 0.016 ms (-0.005 ms, -22.9%) 🟢

Show details

Name	Duration
App start TTI	Baseline Mean: 695.327 ms Stdev: 35.096 ms (5.0%) Runs: 615.2616559998132 654.5298959999345 654.7648129998706 658.17394600017 659.8729599998333 662.4858550000936 663.3379600001499 665.3010100000538 665.5564959999174 667.3060630001128 676.8595019998029 677.3092939998023 679.7495720000006 681.23230399983 684.529978999868 685.2415089998394 689.7287050001323 702.8448589998297 705.8344129999168 708.1695139999501 710.933960000053 712.0890990002081 712.3562389998697 715.3914620000869 720.3314020000398 733.6552400002256 734.5470500001684 740.8865789999254 741.3181400001049 743.9838629998267 761.2283800002187 765.6393840000965 Current Mean: 716.087 ms Stdev: 32.173 ms (4.5%) Runs: 644.7239410001785 678.3825079998933 679.3959849998355 680.627121000085 682.7893219999969 683.6149039999582 685.9664409998804 689.4473250000738 692.7804769999348 697.7409459999762 701.7577960002236 703.0145379998721 704.316387000028 705.1506249997765 705.1788659999147 710.6835659998469 713.5509279998951 717.9366830000654 718.7542889998294 720.7088100002147 721.9385520000942 724.8131940001622 725.7806870001368 733.9005849999376 744.1242129998282 744.3462600000203 755.193566000089 758.6519630001858 759.1474290001206 767.3487940002233 777.272280999925 785.7417270001024
Open Search Page TTI	Baseline Mean: 609.272 ms Stdev: 18.128 ms (3.0%) Runs: 570.231201000046 577.3897710000165 581.8049320001155 583.0333660002798 583.6866859998554 586.0222169999033 590.430907999631 594.9189449995756 597.2820640001446 598.3058679997921 599.056925999932 600.3275560000911 603.8367519997992 610.3655600002967 612.2330729998648 613.875489000231 614.0631110002287 614.1293129995465 615.8339439998381 617.0129399998114 617.4656989998184 619.9231769996695 620.2805180000141 621.113851999864 622.6585290003568 622.9182950002141 623.0930989999324 625.0885419999249 626.2527669998817 628.5760099999607 634.8646650002338 639.7242439999245 640.162679000292 Current Mean: 615.773 ms Stdev: 22.287 ms (3.6%) Runs: 574.0368250003085 582.6831469996832 583.0921229999512 586.2422690000385 588.5155849996954 589.1012369999662 599.997273999732 602.4150399998762 603.7008059998043 603.8836670001037 604.6446539997123 606.0528560001403 608.7086189999245 610.9424240002409 611.0788169996813 613.6577150002122 614.519328000024 615.7114670001902 618.0206709997728 620.7055259998888 621.4280600002967 621.850790000055 621.928670999594 624.5429700003006 624.9949550000019 626.7264809999615 632.0760500002652 632.647665000055 648.3573409998789 649.2968760002404 649.9106850000098 659.3227130002342 669.7201339998282
App start nativeLaunch	Baseline Mean: 19.129 ms Stdev: 1.661 ms (8.7%) Runs: 17 17 17 18 18 18 18 18 18 18 18 18 18 18 18 18 19 19 19 20 20 20 20 20 20 21 21 21 22 22 24 Current Mean: 19.516 ms Stdev: 1.521 ms (7.8%) Runs: 17 18 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 21 21 21 21 21 22 22 22 23
App start runJsBundle	Baseline Mean: 196.129 ms Stdev: 25.160 ms (12.8%) Runs: 158 162 167 168 169 172 173 173 173 180 180 181 186 186 187 189 192 192 196 210 211 213 214 219 221 225 229 233 237 240 244 Current Mean: 196.276 ms Stdev: 14.659 ms (7.5%) Runs: 162 171 173 175 179 179 183 188 190 191 193 194 198 198 199 202 202 202 202 206 208 208 209 209 210 212 213 217 219
App start regularAppStart	Baseline Mean: 0.021 ms Stdev: 0.002 ms (7.3%) Runs: 0.017496999818831682 0.018066999968141317 0.018432000186294317 0.018920999951660633 0.019043000414967537 0.019327000249177217 0.019532000180333853 0.019694000016897917 0.019816000014543533 0.020060000009834766 0.020263999700546265 0.020508000161498785 0.020508000161498785 0.020589000079780817 0.02066999999806285 0.020874000154435635 0.02091500023379922 0.021077000070363283 0.021158000454306602 0.021158999763429165 0.02164699975401163 0.02172800013795495 0.021850999910384417 0.021932000294327736 0.02201299974694848 0.022379000205546618 0.02282699989154935 0.022948999889194965 0.023111999966204166 0.023843999952077866 Current Mean: 0.016 ms Stdev: 0.001 ms (5.2%) Runs: 0.014283000025898218 0.014527000021189451 0.0148930000141263 0.01497400039806962 0.015015000011771917 0.01525900000706315 0.01525900000706315 0.015298999845981598 0.015461999922990799 0.015463000163435936 0.015503000002354383 0.0157880000770092 0.016112999990582466 0.016113999765366316 0.01615400006994605 0.016276000067591667 0.016316999681293964 0.0163569999858737 0.016398000065237284 0.016398000065237284 0.016398000065237284 0.016439000144600868 0.0165200000628829 0.016561000142246485 0.016764999832957983 0.016844999976456165 0.016927000135183334 0.017659000121057034 0.017700999975204468

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.2.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.58-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅