fix: inline display for comment links #17496

aswin-s · 2023-04-17T10:24:45Z

Details

Fixed Issues

Tests

Post a long hyperlink as a comment
e.g link : [Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer ornare dignissim nunc, eleifend molestie dui tempus non. Proin semper eu metus sit amet feugiat. Sed turpis augue, pellentesque sed accumsan ornare, malesuada in ligula. Aliquam porta condimentum varius. Morbi id lorem felis.](https://google.com/)
Hover over the hyperlink after posting the comment
On web and desktop platforms pointer cursor should be shown only when the mouse cursor is above the hyperlink.
Regular cursor should be shown while hovering over empty area next to hyperlink.
On other platforms, the comment should be shown exactly it was rendered earlier.
All other comment types should render exactly the same as before
Same behaviour is applicable for links posted as a reply to a comment via email.
Also verify that below comment types are rendered same as before.

- Text comment
- Comment with hyperlinks
- Edited comments
- Code blocks (Single & Multiline)
- Image attachments
- PDF attachments (Normal & Password Protected)
- Attachments with no preview like mp4, html, doc etc.
- Emojis
- IOU messages

Verify that no errors appear in the JS console

Offline tests

QA Steps

Post a long hyperlink as a comment
e.g link : [Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer ornare dignissim nunc, eleifend molestie dui tempus non. Proin semper eu metus sit amet feugiat. Sed turpis augue, pellentesque sed accumsan ornare, malesuada in ligula. Aliquam porta condimentum varius. Morbi id lorem felis.](https://google.com/)
Hover over the hyperlink after posting the comment
On web and desktop platforms pointer cursor should be shown only when the mouse cursor is above the hyperlink.
Regular cursor should be shown while hovering over empty area next to hyperlink.
On other platforms, the comment should be shown exactly it was rendered earlier.
All other comment types should render exactly the same as before
Same behaviour is applicable for links posted as a reply to a comment via email.
Also verify that below comment types are rendered exactly as before.

- Text comment
- Comment with hyperlinks
- Edited comments
- Code blocks (Single & Multiline)
- Image attachments
- PDF attachments (Normal & Password Protected)
- Attachments with no preview like mp4, html, doc etc.
- Emojis
- IOU messages

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.mp4

Mobile Web - Chrome

Android-Web.mp4

Mobile Web - Safari

iOS-Web.mp4

Desktop

Desktop.mp4

iOS

iOS.mp4

Android

Android.mp4

MelvinBot · 2023-04-17T10:25:22Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js

parasharrajat · 2023-04-17T16:20:14Z

This does not look like the proposal we discussed. What is the reasoning of moving to this solution.

thienlnam · 2023-04-17T17:39:15Z

Seems pullerbear assignment didn't work here - going to assign the people that were on the issue

aswin-s · 2023-04-17T18:47:54Z

@parasharrajat I had to improve upon my original proposal because it was working only for links posted directly within the app. When I implemented it and tested the use cases, I could see that similar bug is possible when a comment is posted via email as well. Original issue didn't mention this. Applying same fix for email-comment tag didn't fix the problem because server was wrapping the email comment in an additional div element like <div dir="ltr">[emailContent]</div>. This forced me to dig deeper and figure out why the element was behaving as a block element even when explicit display:inline style was passed on to it. The answer was that the root view for HTML renderer was using display:flex style and that forces all immediate children to be block elements. Even giving inline style or specifying !important will not help because flex style on parent node has precedence over any of these.

I've recored a video from staging to show how Chrome computes the CSS and the inner element is rendered as a block element even when a display:inline style is given.

root-cause.mp4

I'm happy to answer any further question there is. I believe this fix is better than the original proposal which would have fixed only comments posted via the app.

aswin-s · 2023-04-21T03:10:57Z

@parasharrajat Any feedback here?

parasharrajat · 2023-04-21T17:06:10Z

Oops! This got missed. I will review this today.

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js

parasharrajat

Gonna run some tests now.

src/components/HTMLEngineProvider/defaultViewProps/defaultViewProps.native.js

src/components/HTMLEngineProvider/defaultViewProps/defaultViewProps.web.js

aswin-s · 2023-04-25T07:16:48Z

@parasharrajat Renamed the files

parasharrajat

The issue with file rendering.

parasharrajat

Please extend your tests to cover all types of elements that are rendered in the comments. These changes are affecting the whole comment rendering.

Do tests to make sure everything looks good.

src/components/HTMLEngineProvider/defaultViewProps/index.web.js

parasharrajat

The code looks good. Testing.

parasharrajat · 2023-04-26T07:58:59Z

Can you please merge main?

parasharrajat · 2023-04-26T08:18:59Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-04-26.at.1.49.03.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-04-26.at.1.45.38.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-04-26.at.1.40.04.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-04-26.at.1.42.57.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-04-26.at.1.44.45.PM.mov

🔲 Android / native

Screen.Recording.2023-04-26.at.1.50.55.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @chiragsalian

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-04-27T07:22:09Z

Bump @chiragsalian

aswin-s · 2023-04-28T13:25:56Z

Requesting your review @chiragsalian

chiragsalian

LGTM. GH actions was failing on PR review checklist.
I edited Rajat's checklist to add the missing items and i checked them off.

OSBotify · 2023-04-28T19:20:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-03T00:08:02Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.9-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-05-08T14:17:17Z

src/components/HTMLEngineProvider/defaultViewProps/index.native.js

+import styles from '../../../styles/styles';
+
+export default {
+    style: [styles.dFlex, styles.userSelectText],


Hey, @aswin-s Do you mind explaining to me why we had to remove the styles.alignItemsStart from Native platforms?

alignItemsStart was applied to the root renderer for both web and native platforms. While fixing it for web platform I removed it for both platforms and moved it to inner renderers which are responsible for rendering individual components. You can checkout the changes for Image and Attachment renders. This style is needed for both native and web platforms but applying it at root node has unintended effects for web.

So the change was needed only for web platforms right, and switch back only for native should make no harm? I came across the problem with dFlex on native, as with it applied on root render component, rendered text component span on whole line, and applying it to the renderer itself does nothing as it is intended to be inline rather than block

I think it makes sense to keep the same styling layout across platforms as much as possible. This will reduce the complexity. For now, we have a simple solution that works so let's go with that.

OSBotify · 2023-05-09T04:08:01Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

…-16526" This reverts commit b249584, reversing changes made to 4492f90.

OSBotify · 2023-06-08T17:03:54Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:24:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mollfpr · 2023-06-29T05:55:41Z

✋ Coming from #18658, this PR is causing the regression because of the change of the style display from flex to block.

thesahindia · 2023-07-25T22:27:12Z

We had a regression. The attachments were getting downloaded on clicking outside of the attachment container. (info)

aswin-s added 3 commits April 17, 2023 12:25

fix: use block styling for parent HTML node

315b6a7

fix: image styling with block parent

8aaa49f

fix: use block display only for web & desktop platforms

c36ead4

aswin-s requested a review from a team as a code owner April 17, 2023 10:24

melvin-bot bot requested review from thienlnam and removed request for a team April 17, 2023 10:25

aswin-s commented Apr 17, 2023

View reviewed changes

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js Outdated Show resolved Hide resolved

thienlnam requested review from chiragsalian and parasharrajat and removed request for thienlnam April 17, 2023 17:39

parasharrajat reviewed Apr 22, 2023

View reviewed changes

src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js Outdated Show resolved Hide resolved

fix: separate defaultViewProps into separate platform files

d065025

aswin-s requested a review from parasharrajat April 25, 2023 02:44

parasharrajat suggested changes Apr 25, 2023

View reviewed changes

src/components/HTMLEngineProvider/defaultViewProps/defaultViewProps.native.js Outdated Show resolved Hide resolved

src/components/HTMLEngineProvider/defaultViewProps/defaultViewProps.web.js Outdated Show resolved Hide resolved

fix: rename files

3c80630

aswin-s requested a review from parasharrajat April 25, 2023 06:52

parasharrajat suggested changes Apr 25, 2023

View reviewed changes

src/components/HTMLEngineProvider/defaultViewProps/index.web.js Show resolved Hide resolved

aswin-s added 5 commits April 25, 2023 13:53

add comment to explain why block display is needed

1d80407

fix: styling of file attachment view

c561d8e

fix: default alignment of pressables in comment renderer

7642625

fix: move custom style into HTML renderers

cee0034

fix: pass down style props from parent

23ac14e

parasharrajat reviewed Apr 26, 2023

View reviewed changes

Merge branch 'main' into aswin_s/issue-16526

0ab51e7

aswin-s requested a review from parasharrajat April 26, 2023 08:17

parasharrajat approved these changes Apr 26, 2023

View reviewed changes

parasharrajat mentioned this pull request Apr 28, 2023

Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message #17704

Merged

56 tasks

chiragsalian approved these changes Apr 28, 2023

View reviewed changes

chiragsalian merged commit b249584 into Expensify:main Apr 28, 2023

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

marcaaron mentioned this pull request May 3, 2023

Deploy Checklist: New Expensify 2023-05-02 #18322

Closed

59 tasks

robertKozik mentioned this pull request May 8, 2023

[No QA] create UserMentionRenderer for rendering mentions inside chat #18495

Merged

57 tasks

parasharrajat reviewed May 8, 2023

View reviewed changes

mallenexpensify mentioned this pull request May 12, 2023

[Pay May 15][$2000] In a long link that split into several lines, the pointer cursor is shown in the empty space #16526

Closed

6 tasks

Nikhil-Vats mentioned this pull request May 23, 2023

[HOLD for payment 2023-06-30] [$1000] Chat - Deleted messages with heading style not strike-through in offline #18658

Closed

6 tasks

This was referenced May 30, 2023

[$1000] Attachment downloaded when user clicked outside the attachment button #19717

Closed

[HOLD for payment 2023-06-19] [$1000] Long-pressing the empty right section of a message with just a link doesn't show correct options. #19934

Closed

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Jun 3, 2023

Revert "Merge pull request Expensify#17496 from aswin-s/aswin_s/issue…

1a16bf7

…-16526" This reverts commit b249584, reversing changes made to 4492f90.

bernhardoj mentioned this pull request Jun 3, 2023

Reattempt to fix multiline comment link show pointer cursor in the empty space line #20114

Merged

57 tasks

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

bernhardoj mentioned this pull request Jun 13, 2023

Fix task preview text is overflown #20694

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: inline display for comment links #17496

fix: inline display for comment links #17496

aswin-s commented Apr 17, 2023 •

edited

Loading

MelvinBot commented Apr 17, 2023

parasharrajat commented Apr 17, 2023 •

edited

Loading

thienlnam commented Apr 17, 2023

aswin-s commented Apr 17, 2023

aswin-s commented Apr 21, 2023

parasharrajat commented Apr 21, 2023

parasharrajat left a comment

aswin-s commented Apr 25, 2023

parasharrajat left a comment

parasharrajat left a comment

parasharrajat left a comment

parasharrajat commented Apr 26, 2023

parasharrajat commented Apr 26, 2023 •

edited

Loading

parasharrajat left a comment •

edited by chiragsalian

Loading

parasharrajat commented Apr 27, 2023

aswin-s commented Apr 28, 2023

chiragsalian left a comment •

edited

Loading

OSBotify commented Apr 28, 2023

OSBotify commented May 3, 2023

parasharrajat May 8, 2023

aswin-s May 8, 2023

robertKozik May 8, 2023

parasharrajat May 8, 2023

OSBotify commented May 9, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

mollfpr commented Jun 29, 2023

thesahindia commented Jul 25, 2023

fix: inline display for comment links #17496

fix: inline display for comment links #17496

Conversation

aswin-s commented Apr 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 17, 2023

parasharrajat commented Apr 17, 2023 • edited Loading

thienlnam commented Apr 17, 2023

aswin-s commented Apr 17, 2023

aswin-s commented Apr 21, 2023

parasharrajat commented Apr 21, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

aswin-s commented Apr 25, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

parasharrajat commented Apr 26, 2023

parasharrajat commented Apr 26, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment • edited by chiragsalian Loading

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Apr 27, 2023

aswin-s commented Apr 28, 2023

chiragsalian left a comment • edited Loading

Choose a reason for hiding this comment

OSBotify commented Apr 28, 2023

OSBotify commented May 3, 2023

parasharrajat May 8, 2023

Choose a reason for hiding this comment

aswin-s May 8, 2023

Choose a reason for hiding this comment

robertKozik May 8, 2023

Choose a reason for hiding this comment

parasharrajat May 8, 2023

Choose a reason for hiding this comment

OSBotify commented May 9, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

mollfpr commented Jun 29, 2023

thesahindia commented Jul 25, 2023

aswin-s commented Apr 17, 2023 •

edited

Loading

parasharrajat commented Apr 17, 2023 •

edited

Loading

parasharrajat commented Apr 26, 2023 •

edited

Loading

parasharrajat left a comment •

edited by chiragsalian

Loading

chiragsalian left a comment •

edited

Loading