Omit default Avatar param to prevent crash on app start #11006

Julesssss · 2022-09-15T10:32:00Z

CC @francoisl @trjExpensify

Details

Prevents a crash when personalDetails objects are not available locally in Onyx.

Fixed Issues

$ #11003

Tests

A) [TEST ON STAGING ONLY] Login with an account known to face this issue

Login with user applausetester+0901abb@applause.expensifail.com, using the password Feya86Katya
The app should not crash on first load

B) Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

github-actions · 2022-09-15T10:32:50Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

mountiny

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Julesssss · 2022-09-15T10:37:36Z

Stupid checklist check. Ignoring

Julesssss · 2022-09-15T10:39:06Z

I ignored the checklist check as it was completed, and this is a time-sensitive deploy blocker fix.

Beamanator

Looks good, provided some other ideas

Beamanator · 2022-09-15T10:39:22Z

src/libs/OptionsListUtils.js

@@ -349,7 +349,7 @@ function createOption(logins, personalDetails, report, reportActions = {}, {
    result.text = reportName;
    result.subtitle = subtitle;
    result.participantsList = personalDetailList;
-    result.icons = ReportUtils.getIcons(report, personalDetails, policies, personalDetail.avatar);
+    result.icons = ReportUtils.getIcons(report, personalDetails, policies);


NAB what about making this:

Suggested change

result.icons = ReportUtils.getIcons(report, personalDetails, policies);

result.icons = ReportUtils.getIcons(report, personalDetails, policies, personalDetail && personalDetail.avatar);

Or changing const personalDetail = personalDetailList[0]; above to const personalDetail = personalDetailList[0] || {};?

The getIcons function falls back to a default icon anyway, and the param has a default. But yeah, that might have been better... Maybe you could submit a follow up if the test passes.

Submitted a PR for this here, because it was found to create a new blocker.

Omit default Avatar param to prevent crash on app start (cherry picked from commit 17b2378)

…-11006 🍒 Cherry pick PR #11006 to staging 🍒

Julesssss · 2022-09-15T11:03:05Z

Confirmed the issue is no longer occuring on staging for the two known users:

tom@expensify.com
applausetester+0901abb@applause.expensifail.com

OSBotify · 2022-09-15T12:47:03Z

🚀 Cherry-picked to staging by @Julesssss in version: 1.2.0-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

…yBlocker" This reverts commit 17b2378, reversing changes made to ddd34f8.

OSBotify · 2023-06-15T01:46:22Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

do not pass default avatar when building option

fc4f8c6

Julesssss requested a review from a team as a code owner September 15, 2022 10:32

Julesssss self-assigned this Sep 15, 2022

melvin-bot bot requested review from tylerkaraszewski and removed request for a team September 15, 2022 10:32

Julesssss changed the title ~~do not pass default avatar when building option~~ Omit default Avatar param to prevent crash on app start Sep 15, 2022

Julesssss added the CP Staging label Sep 15, 2022

Julesssss mentioned this pull request Sep 15, 2022

Android - Chat - App crashed after sign in with specific account #11003

Closed

mountiny approved these changes Sep 15, 2022

View reviewed changes

Julesssss merged commit 17b2378 into main Sep 15, 2022

Julesssss deleted the jules-fixAvatarDeployBlocker branch September 15, 2022 10:37

This comment was marked as spam.

Sign in to view

melvin-bot bot added the Emergency label Sep 15, 2022

Julesssss removed the Emergency label Sep 15, 2022

Beamanator approved these changes Sep 15, 2022

View reviewed changes

OSBotify pushed a commit that referenced this pull request Sep 15, 2022

Merge pull request #11006 from Expensify/jules-fixAvatarDeployBlocker

9437344

Omit default Avatar param to prevent crash on app start (cherry picked from commit 17b2378)

OSBotify mentioned this pull request Sep 15, 2022

🍒 Cherry pick PR #11006 to staging 🍒 #11008

Merged

OSBotify added a commit that referenced this pull request Sep 15, 2022

Merge pull request #11008 from Expensify/OSBotify-cherry-pick-staging…

6d643af

…-11006 🍒 Cherry pick PR #11006 to staging 🍒

OSBotify mentioned this pull request Sep 15, 2022

Deploy Checklist: New Expensify 2022-09-13 #10958

Closed

30 tasks

kbecciv mentioned this pull request Sep 15, 2022

[$2000] Web/mweb - Chat - LHN does not display after signing out/signing in #11011

Closed

francoisl mentioned this pull request Sep 15, 2022

[$250] Investigate: 💥 Crash 💥 createOption #11004

Closed

francoisl added a commit that referenced this pull request Sep 15, 2022

Revert "Merge pull request #11006 from Expensify/jules-fixAvatarDeplo…

fe631e1

…yBlocker" This reverts commit 17b2378, reversing changes made to ddd34f8.

francoisl mentioned this pull request Sep 15, 2022

Revert #10784 and #11006 #11018

Closed

93 tasks

OSBotify mentioned this pull request Sep 16, 2022

Deploy Checklist: New Expensify 2022-09-16 #11043

Closed

27 tasks

OSBotify mentioned this pull request Oct 14, 2022

Deploy Checklist: New Expensify 2022-10-14 #11873

Closed

53 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Omit default Avatar param to prevent crash on app start #11006

Omit default Avatar param to prevent crash on app start #11006

Julesssss commented Sep 15, 2022 •

edited by mountiny

Loading

github-actions bot commented Sep 15, 2022

mountiny left a comment

Julesssss commented Sep 15, 2022

This comment was marked as spam.

Julesssss commented Sep 15, 2022

Beamanator left a comment

Beamanator Sep 15, 2022

Beamanator Sep 15, 2022 •

edited

Loading

Julesssss Sep 15, 2022

francoisl Sep 15, 2022

Julesssss commented Sep 15, 2022

OSBotify commented Sep 15, 2022

OSBotify commented Jun 15, 2023

	result.icons = ReportUtils.getIcons(report, personalDetails, policies);
	result.icons = ReportUtils.getIcons(report, personalDetails, policies, personalDetail && personalDetail.avatar);

Omit default Avatar param to prevent crash on app start #11006

Omit default Avatar param to prevent crash on app start #11006

Conversation

Julesssss commented Sep 15, 2022 • edited by mountiny Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

github-actions bot commented Sep 15, 2022

mountiny left a comment

Choose a reason for hiding this comment

Julesssss commented Sep 15, 2022

This comment was marked as spam.

Julesssss commented Sep 15, 2022

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator Sep 15, 2022

Choose a reason for hiding this comment

Beamanator Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

Julesssss Sep 15, 2022

Choose a reason for hiding this comment

francoisl Sep 15, 2022

Choose a reason for hiding this comment

Julesssss commented Sep 15, 2022

OSBotify commented Sep 15, 2022

OSBotify commented Jun 15, 2023

Julesssss commented Sep 15, 2022 •

edited by mountiny

Loading

Beamanator Sep 15, 2022 •

edited

Loading