Add leaveRoom action #15392

marcochavezf · 2023-02-23T00:36:45Z

~~Requires https://github.com/Expensify/Web-Expensify/pull/36572~~

Details

Hides and shows the Leave Room button according to the chatType or visibility and triggers the LeaveRoom command to leave the room.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/263097

Tests

Create a new workspace, save the reportID of the #announce room.
./script/sql.sh and run the following query to update the visibility rNVP to be "public_announce":
INSERT INTO reportNameValuePairs (reportID, name, value) VALUES (, "visibility", "public_announce");
Alternatively you can use the reportID of an existing public room, ask @MitchExpensify
In another browser or an incognito session sign in with another account
Navigate to the #announce room (i.e. localhost:8080/r/<reportID)
Click on Leave Room and verify the member's list is updated in the first browser session

Verify that no errors appear in the JS console

Offline tests

Same as Test steps, but before Clicking on the Leave Room put the browser/app offline and verify the room disappears from the LHN

QA Steps

Join this room https://new.expensify.com/r/3073545337096441 (or ask @MitchExpensify for the link for a public announce room) with two accounts (e.g. marco@expensify.com and marco@expensifail.com)
On one of those accounts, click on Leave Room and verify the member's list is updated in the other account.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-02.at.11.17.14.mov

Mobile Web - Chrome

Screen.Recording.2023-03-02.at.12.02.30.mov

Mobile Web - Safari

Screen.Recording.2023-03-02.at.12.01.10.mov

Desktop

Screen.Recording.2023-03-02.at.12.03.23.mov

iOS

Screen.Recording.2023-03-02.at.11.56.43.mov

Android

Screen.Recording.2023-03-02.at.11.58.05.mov

github-actions · 2023-03-02T18:56:52Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

MelvinBot · 2023-03-02T19:00:44Z

@sobitneupane @joelbettner One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg · 2023-03-06T19:08:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Screen.Recording.2023-03-06.at.12.44.03.PM.mov

Mobile Web - Safari

mobile-web-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

jasperhuangg · 2023-03-06T19:13:35Z

Sorry jumped the gun, found this during testing @marcochavezf

EDIT: fixed it for ya since I noticed there was some other logic that needed fixing, also opened this PR https://github.com/Expensify/Auth/pull/7604 that we should probably deploy before yours since your PR enables the "Public" option in the new room page.

src/languages/es.js

jasperhuangg · 2023-03-07T04:09:04Z

@marcochavezf Auth PR was just merged, if it isn't deployed tomorrow I'll ask for a CP for ya

Add leaveRoom action (cherry picked from commit 17cf77e)

…-15392 🍒 Cherry pick PR #15392 to staging 🍒

OSBotify · 2023-03-08T12:52:36Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.2.80-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

marcochavezf · 2023-03-08T18:54:23Z

The LeaveRoom button looks good on web:

Screen.Recording.2023-03-08.at.12.49.12.mov

marcochavezf · 2023-03-08T18:58:51Z

On Android (and I think the other platforms) the latest version hasn't been updated. The possible reason here.

marcochavezf · 2023-03-08T22:25:41Z

Tested well on the remaining platforms (1.2.80-1) 👍🏽

OSBotify · 2023-03-09T03:32:31Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.80-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:36:01Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:53:46Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

wildan-m · 2024-10-28T02:50:31Z

src/libs/actions/Policy.js

+                onyxMethod: CONST.ONYX.METHOD.SET,
+                key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
+                value: {
+                    stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,


@marcochavezf what is the reason that we use

value: { stateNum: CONST.REPORT.STATE_NUM.SUBMITTED, statusNum: CONST.REPORT.STATUS.CLOSED, },

Than directly set the report to null?

cc: @parasharrajat

Hi @wildan-m, iirc we just close the report (where this values represent a closed report) to hide instead of removing completely from Onyx. And I think that's because in case we receive an update for that report, we don't show it again

Also I noticed this code doesn't exist in main, and was changed in this PR https://github.com/Expensify/App/pull/27966/files#diff-8afe5b71ee0436c21364148c86dadd640f2bff3e3d916addbb1f1f6f7e5b6a43R1939-R1940

marcochavezf added 7 commits February 22, 2023 17:50

add leaveRoom action

4b0da92

hook up leaveRoom action to Leave room button

60dccf3

add new visibility values

60f2002

add missing visibility value

3c49baa

add canLeaveRoom function

6760e66

hide the Leave room button if use cannot leave

f4885e6

add comment

85f93a1

marcochavezf self-assigned this Feb 23, 2023

Merge branch 'main' into marco-addLeaveRoomAction

ea547ce

jasperhuangg self-requested a review March 1, 2023 21:05

marcochavezf added 9 commits March 1, 2023 17:34

include only public and public_announce values

4fec5ff

fix Policy.leaveRoom

a48c312

fix New Room page

d3a7f24

update canLeaveRoom logic

9dcc676

add new visibilityOptions

d1ce25d

open concierge when user leaves room

48cf798

update logic to show Leave Room button

aced8a8

check if policy exists for the user

7e4c64b

Merge branch 'main' into marco-addLeaveRoomAction

078513d

marcochavezf added CP Staging InternalQA This pull request required internal QA labels Mar 2, 2023

marcochavezf changed the title ~~[WIP] Add leaveRoom action~~ [HOLD #36572] Add leaveRoom action Mar 2, 2023

marcochavezf marked this pull request as ready for review March 2, 2023 18:59

marcochavezf requested a review from a team as a code owner March 2, 2023 19:00

marcochavezf requested a review from iwiznia March 2, 2023 19:00

melvin-bot bot requested review from joelbettner and sobitneupane and removed request for a team March 2, 2023 19:00

jasperhuangg mentioned this pull request Mar 6, 2023

Disable renaming public rooms if the current user is not an admin or the creator of the linked workspace #15688

Merged

55 tasks

filter visibility options, add visibility descriptions

817168d

jasperhuangg dismissed their stale review via 817168d March 6, 2023 19:27

remove unused

e7790de

jasperhuangg changed the title ~~Add leaveRoom action~~ [HOLD Auth#7604] Add leaveRoom action Mar 6, 2023

jasperhuangg reviewed Mar 6, 2023

View reviewed changes

src/languages/es.js Show resolved Hide resolved

jasperhuangg approved these changes Mar 6, 2023

View reviewed changes

jasperhuangg changed the title ~~[HOLD Auth#7604] Add leaveRoom action~~ Add leaveRoom action Mar 7, 2023

jasperhuangg changed the title ~~Add leaveRoom action~~ [HOLD Auth#7604] Add leaveRoom action Mar 7, 2023

jasperhuangg changed the title ~~[HOLD Auth#7604] Add leaveRoom action~~ Add leaveRoom action Mar 7, 2023

jasperhuangg merged commit 17cf77e into main Mar 7, 2023

jasperhuangg deleted the marco-addLeaveRoomAction branch March 7, 2023 18:08

OSBotify pushed a commit that referenced this pull request Mar 8, 2023

Merge pull request #15392 from Expensify/marco-addLeaveRoomAction

d743ebb

Add leaveRoom action (cherry picked from commit 17cf77e)

OSBotify mentioned this pull request Mar 8, 2023

🍒 Cherry pick PR #15392 to staging 🍒 #15739

Merged

OSBotify added a commit that referenced this pull request Mar 8, 2023

Merge pull request #15739 from Expensify/OSBotify-cherry-pick-staging…

8d76887

…-15392 🍒 Cherry pick PR #15392 to staging 🍒

OSBotify mentioned this pull request Mar 8, 2023

Deploy Checklist: New Expensify 2023-03-07 #15717

Closed

18 tasks

OSBotify mentioned this pull request Mar 9, 2023

Deploy Checklist: New Expensify 2023-03-09 #15767

Closed

19 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

wildan-m reviewed Oct 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add leaveRoom action #15392

Add leaveRoom action #15392

marcochavezf commented Feb 23, 2023 •

edited

Loading

github-actions bot commented Mar 2, 2023

MelvinBot commented Mar 2, 2023

jasperhuangg commented Mar 6, 2023 •

edited

Loading

jasperhuangg commented Mar 6, 2023 •

edited

Loading

jasperhuangg commented Mar 7, 2023

OSBotify commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

OSBotify commented Mar 9, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

wildan-m Oct 28, 2024 •

edited

Loading

marcochavezf Oct 28, 2024

Add leaveRoom action #15392

Add leaveRoom action #15392

Conversation

marcochavezf commented Feb 23, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Mar 2, 2023

MelvinBot commented Mar 2, 2023

jasperhuangg commented Mar 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jasperhuangg commented Mar 6, 2023 • edited Loading

jasperhuangg commented Mar 7, 2023

OSBotify commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

marcochavezf commented Mar 8, 2023

OSBotify commented Mar 9, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

wildan-m Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

marcochavezf Oct 28, 2024

Choose a reason for hiding this comment

marcochavezf commented Feb 23, 2023 •

edited

Loading

jasperhuangg commented Mar 6, 2023 •

edited

Loading

jasperhuangg commented Mar 6, 2023 •

edited

Loading

wildan-m Oct 28, 2024 •

edited

Loading