Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-03-07 #15717

Closed
18 tasks done
OSBotify opened this issue Mar 7, 2023 · 10 comments
Closed
18 tasks done

Deploy Checklist: New Expensify 2023-03-07 #15717

OSBotify opened this issue Mar 7, 2023 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 7, 2023

Release Version: 1.2.80-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 7, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 7, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 8, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.80-1 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 8, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.80-1 has been deployed to staging 🎉

@roryabraham
Copy link
Contributor

How's QA progressing here?

@mvtglobally
Copy link

@roryabraham Regression is completed. We are just finishing last PRs

PR #15204 is failing #15735 repro in PROD checking off
PR #15552 is failing #15728. repro in PROD checking off
PR #15650 is failing #15724. not repro in PROD but its a new feature, so we didnt add Blocker label. PLs double check

@roryabraham
Copy link
Contributor

@mvtglobally Agree with not making #15724 a deploy blocker. Checking off #15650

@roryabraham
Copy link
Contributor

Just merged a fix for #15725 (just reverted the PR that added that feature for now)

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 9, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.80-2 🚀

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Mar 9, 2023

Checking off #15725, the bug is no longer in staging

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 9, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.80-2 has been deployed to staging 🎉

@roryabraham
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants