[HOLD for payment 2023-04-03] WEB - Chat - Draft text is not cleared but the compose box is still focused

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #15650

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to any chat
4. Write some text in the compose box
5. Press Esc
6. Verify that the draft text is cleared but the compose box is still focused
7. Repeat Steps 3,4,5

Expected Result:

Draft text is cleared but the compose box is still focused

Actual Result:

If you repeat the steps 3,4,5 several times, then the comment does not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Web / Chrome
• MacOS / Desktop

Version Number: 1.2.80.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5967861_Recording__346.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012df6b447b406c99c
• Upwork Job ID: 1633544219615494144
• Last Price Increase: 2023-03-08

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tjferriss]

@luacmartins this issue appears like it could be the same as #15597. What do you think?

I was able to reproduce the issue:

Screen.Recording.2023-03-08.at.9.42.54.AM.mov

[luacmartins]

I see. This is related to the PR linked in the OP. Seems like the debounce we have on the composer box is putting the text back in it. I can take a look at this.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~012df6b447b406c99c

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[tjferriss]

Whoops, got a little trigger happy with Internal label

[Santhosh-Sellavel]

@tjferriss @luacmartins

I got unassigned accidentally or is no C+ help needed here?

[tjferriss]

I don't think it's needed, my mistake.

[MelvinBot]

@tjferriss, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

No updates yet because of ECX

[tjferriss]

@luacmartins will look into this one post-ECX

[luacmartins]

Gonna work on this today!

[luacmartins]

PR up #16317

[luacmartins]

PR in review

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Debounce escape to clear #16317

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR @mollfpr

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Clear compose on Esc key #15650
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: this is a new feature
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a new feature
• [@tjferriss] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/271457

[luacmartins]

We should add the test steps in this PR to the compose box tests.

[mollfpr]

Test step from the PR.

---

On Web/Desktop only:

1. Open a chat with a user
2. Type quickly in the compose box and immediately press Esc
3. Verify that the compose box is cleared and the old text doesn't show up again
4. Repeat 2-3 several times

Not applicable to mobile devices.

---

@luacmartins @tjferriss Could you assign me to the issue? Thank you!

[tjferriss]

Issue for regression test created https://github.com/Expensify/Expensify/issues/271457

[tjferriss]

@mollfpr sorry for the delay, I just invited you to the Upworks job to process payment for the PR review: https://www.upwork.com/jobs/~01b2c83c7fb1bd9dd7

[mollfpr]

@tjferriss Applied!

[mollfpr]

@tjferriss bump for the payment

[tjferriss]

Done