Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-03-16] Feature Request: Pressing Esc when composing a new message should clear the message #15597

Closed
kavimuru opened this issue Mar 1, 2023 · 4 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@kavimuru
Copy link

kavimuru commented Mar 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

When editing a message, pressing Escape cancels the edit; when composing a new message, Escape does nothing.

Solution:

Make pressing Escape clear the new message being composed.

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

esc.key.behavior.mp4

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677476774053969

View all open jobs on GitHub

@kavimuru kavimuru added Weekly KSv2 NewFeature Something to build that is a new item. labels Mar 1, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 1, 2023
@luacmartins luacmartins self-assigned this Mar 2, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Mar 3, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 9, 2023
@melvin-bot melvin-bot bot changed the title Feature Request: Pressing Esc when composing a new message should clear the message [HOLD for payment 2023-03-16] Feature Request: Pressing Esc when composing a new message should clear the message Mar 9, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 9, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.80-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-03-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 15, 2023
@luacmartins
Copy link
Contributor

Still waiting on payment here

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@luacmartins
Copy link
Contributor

Payment is processed. We are all done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants