Fix the content-type for AASA #15708

justinpersaud · 2023-03-07T14:32:05Z

The content-type for the AASA file is incorrect which prevents deeplinking from working properly.

We are using the aws cli to deploy the build files into the s3 bucket, but if a content-type is not specified during this operation, it attempts to guess the correct mime type and it happens to be wrong for this file.

The fix here is to copy the file over itself during the deploy with the correct content-type header.

Details

Explained above

Fixed Issues

https://github.com/Expensify/Expensify/issues/266451

Tests

Since I have access to the bucket directly, I used the AWS CLI locally and ran the commands to check what it's set to now, updated it, then checked again.

❯ aws s3api head-object --bucket expensify-cash --key .well-known/apple-app-site-association
{
    "AcceptRanges": "bytes",
    "LastModified": "2023-03-06T15:21:48+00:00",
    "ContentLength": 1882,
    "ETag": "\"cf128e3c63ff747d0dc2448796e58744\"",
    "VersionId": "AEjHTa_2cV1EWNQ9W4ktuvci4sQwKZxl",
    "ContentType": "binary/octet-stream",
    "ServerSideEncryption": "AES256",
    "Metadata": {}
}

~ 6s
❯ aws s3 cp --content-type 'application/json' --metadata-directive REPLACE s3://expensify-cash/.well-known/apple-app-site-association s3://expensify-cash/.well-known/apple-app-site-association
copy: s3://expensify-cash/.well-known/apple-app-site-association to s3://expensify-cash/.well-known/apple-app-site-association

~ 12s
❯ aws s3api head-object --bucket expensify-cash --key .well-known/apple-app-site-association
{
    "AcceptRanges": "bytes",
    "LastModified": "2023-03-07T14:26:44+00:00",
    "ContentLength": 1882,
    "ETag": "\"cf128e3c63ff747d0dc2448796e58744\"",
    "VersionId": "nDTrPy3pUU_nUDl.QXor29JLhrxZkJrl",
    "ContentType": "application/json",
    "ServerSideEncryption": "AES256",
    "Metadata": {}
}

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-03-07T14:32:55Z

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bondydaa

i don't know much about the inner workings of the apple stuff but seems legit to me

marcochavezf · 2023-03-07T15:43:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-03-07T15:52:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-07T18:11:30Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.2.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-08T14:28:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-09T03:32:37Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.80-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix the content-type for AASA

9914551

justinpersaud requested a review from marcochavezf March 7, 2023 14:32

justinpersaud self-assigned this Mar 7, 2023

justinpersaud requested a review from a team as a code owner March 7, 2023 14:32

melvin-bot bot requested review from bondydaa and removed request for a team March 7, 2023 14:32

justinpersaud added 2 commits March 7, 2023 14:49

fix staging bucket name

f58eac1

undo style changes

8c3cf56

bondydaa approved these changes Mar 7, 2023

View reviewed changes

marcochavezf approved these changes Mar 7, 2023

View reviewed changes

marcochavezf merged commit 74f4e3d into main Mar 7, 2023

marcochavezf deleted the jpersaud_fix_ios_deeplink branch March 7, 2023 15:48

OSBotify mentioned this pull request Mar 7, 2023

Deploy Checklist: New Expensify 2023-03-07 #15717

Closed

18 tasks

marcochavezf mentioned this pull request Mar 7, 2023

[No QA] Revert "Fix the content-type for AASA" #15727

Merged

53 tasks

arielgreen mentioned this pull request Mar 7, 2023

[$2000] Deep links are broken on iOS #15158

Closed

6 tasks

justinpersaud mentioned this pull request Mar 8, 2023

Update Content-Type for AASA file #15743

Merged

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the content-type for AASA #15708

Fix the content-type for AASA #15708

justinpersaud commented Mar 7, 2023 •

edited

Loading

MelvinBot commented Mar 7, 2023

bondydaa left a comment

marcochavezf commented Mar 7, 2023 •

edited

Loading

OSBotify commented Mar 7, 2023

OSBotify commented Mar 7, 2023

OSBotify commented Mar 8, 2023

OSBotify commented Mar 9, 2023

Fix the content-type for AASA #15708

Fix the content-type for AASA #15708

Conversation

justinpersaud commented Mar 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 7, 2023

bondydaa left a comment

Choose a reason for hiding this comment

marcochavezf commented Mar 7, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Mar 7, 2023

OSBotify commented Mar 7, 2023

OSBotify commented Mar 8, 2023

OSBotify commented Mar 9, 2023

justinpersaud commented Mar 7, 2023 •

edited

Loading

marcochavezf commented Mar 7, 2023 •

edited

Loading