Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Magic code 000000 doesn't work to validate the login #15735

Closed
6 tasks done
kbecciv opened this issue Mar 8, 2023 · 6 comments
Closed
6 tasks done

Profile - Magic code 000000 doesn't work to validate the login #15735

kbecciv opened this issue Mar 8, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Mar 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #15204

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account that only has an email login OR only has a phone number login as Contact methods
  3. Go to Settings -> Profile -> Contact methods
  4. Add a new contact method (phone number for me)
  5. Enter 000000 magic code for successfully validate the login

Expected Result:

User can successfully validate the login by entering 000000 magic code

Actual Result:

Magic code 000000 doesn't work to validate the login

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.80.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

15204.Web.online.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 8, 2023
@MelvinBot
Copy link

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 8, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Beamanator Beamanator self-assigned this Mar 8, 2023
@Beamanator
Copy link
Contributor

self-assigning b/c I messed up test steps a bit :D

@kbecciv I just updated the test steps on that PR (#15204) to mention that you should actually see an email with a magic code, and use the magic code in that email to validate the secondary login - 000000 will only work in dev environments, sorry for the confusion

@Beamanator
Copy link
Contributor

Orrr I guess if you're not on the passwordless beta (I'm not sure if Applause accounts are on the beta yet?) you'll see an email like this, which you should be able to use to validate your new contact method:

Screenshot 2023-03-08 at 10 49 11 AM

@CortneyOfstad
Copy link
Contributor

@Beamanator is there anything you need me to do from a Bug-Zero perspective? I was able to recreate this on my mobile device 👍

@Beamanator
Copy link
Contributor

@CortneyOfstad nahhhh i think you're good! If you can successfully verify a new contact method / secondary login, I think we're good to close this out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants