Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Update Expensify Common commit #10429

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[NO QA] Update Expensify Common commit #10429

merged 1 commit into from
Aug 17, 2022

Conversation

sketchydroide
Copy link
Contributor

@sketchydroide sketchydroide commented Aug 17, 2022 •
edited
Loading

Update Commit to Expensify Common, as required here #9826

Fixed Issues

No real issue fix, but related to the one above.

Tests

N/A

  • Verify that no errors appear in the JS console

@sketchydroide sketchydroide self-assigned this Aug 17, 2022
@sketchydroide sketchydroide marked this pull request as ready for review August 17, 2022 13:50
@sketchydroide sketchydroide requested a review from a team as a code owner August 17, 2022 13:50
@melvin-bot melvin-bot bot requested review from Justicea83 and removed request for a team August 17, 2022 13:50
Justicea83
Justicea83 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@Justicea83 Justicea83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justicea83 Justicea83 merged commit 8cc92aa into main Aug 17, 2022
@Justicea83 Justicea83 deleted the afonseca_update_common_library branch August 17, 2022 16:38
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rushatgabhane rushatgabhane mentioned this pull request Aug 22, 2022
Closed
@OSBotify OSBotify mentioned this pull request Aug 23, 2022
Closed
48 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Justicea83 in version: 1.1.89-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justicea83 Justicea83 Justicea83 approved these changes

Assignees

@sketchydroide sketchydroide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sketchydroide @OSBotify @Justicea83