Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in - Missing re-sent link message when you click Forgot password #10754

Closed
kbecciv opened this issue Sep 1, 2022 · 9 comments
Closed

Log in - Missing re-sent link message when you click Forgot password #10754

kbecciv opened this issue Sep 1, 2022 · 9 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. In log in page enter your username
  3. Click continue
  4. Click Forgot Password

Expected Result:

Re-sent link message should be appears when you click Forgot password

Actual Result:

Missing re-sent link message when you click Forgot password

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.96.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5713317_Recording__1056.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@arosiclair
Copy link
Contributor

I can easily reproduce this in staging, however the reset email is still sent without issue so I don't think this is a blocking issue.

@arosiclair
Copy link
Contributor

cc @jasperhuangg it looks like your refactor PR was the last to touch this

@bondydaa
Copy link
Contributor

bondydaa commented Sep 2, 2022

I can easily reproduce this in staging, however the reset email is still sent without issue so I don't think this is a blocking issue.

be careful here, when you click Forgot Password we trigger 1 email automatically.

Clicking the Resend button should send a second one.

@bondydaa
Copy link
Contributor

bondydaa commented Sep 2, 2022

This is probably from Jasper's / my PR #10556

we refactored a component in there - let me take a deeper look.

@bondydaa bondydaa assigned bondydaa and unassigned arosiclair Sep 2, 2022
@luacmartins
Copy link
Contributor

I have a fix for it, testing now.

@bondydaa
Copy link
Contributor

bondydaa commented Sep 2, 2022

Just to update slightly there will be another small regression here where clicking the Forgot? button will automatically show the Green Brick Road message when it takes you to the next step for the time being like this: image

This is fine and expected for now, we are cleaning it up on #10785

@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants