Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Create ResendRequestPasswordReset #10785

Closed
luacmartins opened this issue Sep 2, 2022 · 16 comments
Closed

[$250] Create ResendRequestPasswordReset #10785

luacmartins opened this issue Sep 2, 2022 · 16 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

Coming from this issue, we need a new command for ResendRequestPasswordReset for when the user clicks the Resend link in the Forgot? password page. We also need to remove the linkHasBeenResent since we should NOT show that message the first time we navigate the user to the Forgot? page

@melvin-bot
Copy link

melvin-bot bot commented Sep 2, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@bondydaa
Copy link
Contributor

bondydaa commented Sep 2, 2022

got some draft prs here https://github.com/Expensify/Web-Expensify/pull/34769 #10798, i'll finish these off on monday.

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2022

@bondydaa Whoops! This issue is 2 days overdue. Let's get this updated quick!

@bondydaa
Copy link
Contributor

bondydaa commented Sep 6, 2022

was focused on something else yesterday, working on finalizing my PRs today for this.

@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2022
@bondydaa
Copy link
Contributor

bondydaa commented Sep 7, 2022

publishing PRs today

@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

@bondydaa Eep! 4 days overdue now. Issues have feelings too...

@bondydaa
Copy link
Contributor

web-e pr is in review, once that's finished I'll update the App PR.

@melvin-bot melvin-bot bot removed the Overdue label Sep 13, 2022
@bondydaa
Copy link
Contributor

woohoo, web-e PR was merged 🎉

@bondydaa bondydaa added Internal Requires API changes or must be handled by Expensify staff ContributorPlusReview labels Sep 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @arielgreen for Upwork job creation (chore: ContributorPlusReview), see https://stackoverflow.com/c/expensify/questions/13732 for more details.

@bondydaa
Copy link
Contributor

throwingContributorPlusReview on here to get #10798 reviewed

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @Luke9389 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Create ResendRequestPasswordReset [$250] Create ResendRequestPasswordReset Sep 15, 2022
@puneetlath
Copy link
Contributor

@arielgreen I went ahead and put the Exported label on so that @mananjadhav would get assigned to review the PR right away. You'll still need to create the GH issue. Thanks!

@melvin-bot melvin-bot bot closed this as completed Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants