-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2022-09-30] [$250] Web - Login - The input field does not focus after following the magic link #10968
Comments
Triggered auto assignment to @Julesssss ( |
Reproduced on Chrome. Not a big issue, but I suppose we should try to get this working. |
Triggered auto assignment to @mallenexpensify ( |
ProposalWe have to use componentDidMount() {
if (!canFocusInputOnScreenFocus() || !this.input) {
return;
}
this.input.focus();
} Need to pass App/src/pages/settings/NewPasswordForm.js Line 72 in a034007
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
Current assignee @Julesssss is eligible for the Exported assigner, not assigning anyone new. |
@parasharrajat can you review @thesahindia 's proposal above? Thx |
Proposal We need to pass autoFocus={true} props to TextInput in the NewPasswordForm.js and it focuses the input on componentDidMount. App/src/pages/settings/NewPasswordForm.js Line 72 in a034007
Like This <TextInput
/> After Fixing The Issue Screen.Recording.2022-09-15.at.3.49.44.AM.mov |
@syedsaroshfarrukhdot's proposal looks good to me. 🎀 👀 🎀 C+ reviewed |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.5-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2022-09-30. 🎊 |
Issue not reproducible during KI retests. (First week) |
@Julesssss, @mallenexpensify, @parasharrajat, @syedsaroshfarrukhdot Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Triggered auto assignment to @trjExpensify ( |
Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new. |
Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new. |
Hey @trjExpensify, Matt is away at the moment. Could you please pay out this issue? Thanks! |
👋 I settled up with @syedsaroshfarrukhdot. The other hire on this job is @mananjadhav, but @parasharrajat was C+. Any idea what happened there? In the meantime, I've sent Rajat an offer. |
I did work on an issue related to magic link and forgot password. But I don't think it is this one. |
Gotcha. Any idea which issue and contract that is? Looks like you've been paid for this one, you see. |
Yeah I found the issue. Looks like I was paid for #10785 with this issue's Upwork job. I don't see any Upwork job or payment for 10785. |
Got it, got it. Cool, so just waiting on @parasharrajat to accept the contract for this job and then we can close it out! |
Cool, settled up with @parasharrajat. Thanks everyone! 🎉 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The input field must be focused
Actual Result:
The input field does not focus
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.0.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5730036_Recording__1889.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: