[HOLD for payment 2022-11-16] [$1000] iOS - LHN - The green + button moves

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the App/iOS and login with any account
2. Click on FAB button
3. Select New Chat or New Group and then close it

Expected Result:

The FAB button should not move

Actual Result:

The FAB button moves down

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.98.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5723392_RPReplay_Final1662657184.mp4

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia & Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661937997800789

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

Hi, I had reported it here.
It's more noticeable in iPad

Screen.Recording.2022-08-31.at.3.08.55.PM.mov

[kadiealexander]

Reassigning as I'm ooo for the next 9 days.

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jboniface]

job post

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @ctkochan22 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

This seems like an issue to me -> #10905 (comment)

189351776-bf687433-caf6-41f0-9d40-bb45b2f73def.mov

But not this #10905 (comment)

189195867-e7b6accc-0664-4dec-8f28-9a32df91cddd.mp4

@Expensify/design Can someone share your thoughts

Also, we have a proposal here please check out the after-fix video is that the expectation?

[JmillsExpensify]

@jliexpensify Don't forget to get the BZ checklist kicked off above please!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• @jliexpensify A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here: https://github.com/Expensify/Expensify/issues/242989
• @Santhosh-Sellavel @tgolen The PR that introduced the bug has been identified. Link to the PR: Fix for Update Global Offline Indicator #10140
• @Santhosh-Sellavel @tgolen The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/10140/files#r1036120226
• @Santhosh-Sellavel @tgolen A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1669053920014679
• @jliexpensify Payment has been made to the issue reporter (if applicable)
• @jliexpensify Payment has been made to the contributor that fixed the issue (if applicable)
• @jliexpensify Payment has been made to the contributor+ that helped on the issue (if applicable)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix keyboard issue on FloatingActionButton component #12345

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[JmillsExpensify]

@jliexpensify Just wanted to circle back and make sure you've gone through the linked BZ checklist?

[jliexpensify]

@JmillsExpensify I previously posted here around what parts of the checklist I should be doing, and you mentioned changes were coming.

I'm still confused here: am I doing the entire checklist? The first 3 items sound like they should be reviewed by the primary engineer (Tim), whilst the last few items are related to payment, which isn't due yet.

[JmillsExpensify]

@jliexpensify I don't recall saying don't fill out the checklist, as any changes to Melvin are unfortunately not retro-active. All good, here's an example checklist I got on Friday. That should clear up your questions.

[jliexpensify]

Thanks @JmillsExpensify, appreciate you sharing that checklist. I've updated the one above to mirror yours.

Regression test question posted here - https://expensify.slack.com/archives/C01SKUP7QR0/p1668379720583589

[jliexpensify]

@Santhosh-Sellavel and @tgolen - I've done the regression test GH, and have tagged you both in the checklist (as per https://expensify.slack.com/archives/C01SKUP7QR0/p1668442521431959?thread_ts=1668440072.179999&cid=C01SKUP7QR0). Cheers!

[tgolen]

I've filled out the first two checkboxes for identifying the PR. @Santhosh-Sellavel would you like to create a slack thread for discussing if any changes are necessary for the checklist?

[JmillsExpensify]

Quick follow-up question: @jliexpensify has payment been issued to contributors?

[Santhosh-Sellavel]

Thread started here

[jliexpensify]

Sorry @JmillsExpensify - dropped the ball on this one! I'll sort out payment now.

[jliexpensify]

@Santhosh-Sellavel , @aimane-chnaif and @thesahindia apologies for the delay: once you accept, I'll pay out $1000 to each of you.

[aimane-chnaif]

@jliexpensify accepted, thanks

[thesahindia]

Accepted, thanks!

I'll pay out $1000 to each of you.

I believe it's $250 for me (reporting compensation)

[jliexpensify]

@thesahindia - thanks for pointing that out and your honesty! My new dad brain appreciates you.

Everyone is paid, feedback has been left and the job closed in Upworks. I'll keep this GH open for @Santhosh-Sellavel to update on the discussion. Thanks!

[JmillsExpensify]

Thank you @jliexpensify! Echoing your last comment, this is the last todo before we can close this issue.

@Santhosh-Sellavel @tgolen A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[melvin-bot]

@tgolen, @shawnborton, @jliexpensify, @Santhosh-Sellavel, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tgolen]

@jliexpensify the BugZero checklist is finished now so this issue is OK to close out now. I'll let you do the honors.

[jliexpensify]

Nice work, thanks @tgolen , @aimane-chnaif , @Santhosh-Sellavel, @shawnborton and @JmillsExpensify !