[$250] Investigate: 💥 Crash 💥 com.facebook.react.views.scroll.MaintainVisibleContentPositionHelper.updateScrollPosition

[melvin-bot]

Firebase has reported a new crash that we need to fix, here are all the details we found:

Fatal Exception: java.lang.NullPointerException

Attempt to invoke virtual method 'void android.view.View.getHitRect(android.graphics.Rect)' on a null object reference

MaintainVisibleContentPositionHelper.java line 105 com.facebook.react.views.scroll.MaintainVisibleContentPositionHelper.updateScrollPosition

Number of Crashes: 3

Device Information

• Platforms: Android
• App Versions: 1.2.1-0
• Devices: OnePlus GM1917 11

Stacktraces

Android 1.2.1-0

com.facebook.react.views.scroll.MaintainVisibleContentPositionHelper.updateScrollPosition (MaintainVisibleContentPositionHelper.java:105)
com.facebook.react.views.scroll.ReactScrollView.onLayoutChange (ReactScrollView.java:1063)
android.view.View.layout (View.java:23060)
android.view.ViewGroup.layout (ViewGroup.java:6419)
com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout (NativeViewHierarchyManager.java:254)
com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout (NativeViewHierarchyManager.java:222)
com.swmansion.reanimated.layoutReanimation.ReanimatedNativeHierarchyManager.updateLayout (ReanimatedNativeHierarchyManager.java:274)
com.facebook.react.uimanager.UIViewOperationQueue$UpdateLayoutOperation.execute (UIViewOperationQueue.java:169)
com.facebook.react.uimanager.UIViewOperationQueue$1.run (UIViewOperationQueue.java:915)
com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches (UIViewOperationQueue.java:1026)
com.facebook.react.uimanager.UIViewOperationQueue.access$2600 (UIViewOperationQueue.java:47)
com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded (UIViewOperationQueue.java:1086)
com.facebook.react.uimanager.GuardedFrameCallback.doFrame (GuardedFrameCallback.java:29)
com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame (ReactChoreographer.java:175)
com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame (ChoreographerCompat.java:85)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1350)
android.view.Choreographer.doCallbacks (Choreographer.java:1149)
android.view.Choreographer.doFrame (Choreographer.java:1040)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1333)
android.os.Handler.handleCallback (Handler.java:938)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loop (Looper.java:233)
android.app.ActivityThread.main (ActivityThread.java:8010)
java.lang.reflect.Method.invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:631)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:978)

---

Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: d04a9af7b41d6cae7236ba230324da48
Exception: Attempt to invoke virtual method 'void android.view.View.getHitRect(android.graphics.Rect)' on a null object reference

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Christinadobrzyn]

Created Upwork job -

Internal positing - https://www.upwork.com/ab/applicants/1571730470955716608/job-details
External posting - https://www.upwork.com/jobs/~016e2332b8b70f7672

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

Hey @Santhosh-Sellavel @stitesExpensify will this job stay open? If yes, I'll increase the price.

[Santhosh-Sellavel]

@stitesExpensify Can you check the logs what environment this crash occurred from?

[stitesExpensify]

It looks like this error is no longer in crashlytics/firebase so I think we can just close.

[Christinadobrzyn]

Closed the job in upwork

[melvin-bot]

This crash occurred again and has not been fully fixed, reopening issue 🔄

[stitesExpensify]

LOL of course. Will look again today

[stitesExpensify]

Not really sure where the actual error happened based on these logs, but maybe they'll be useful

img width="1328" alt="2022-09-28_12-59-24" src="https://user-images.githubusercontent.com/42391420/192866339-5107a620-ad05-427c-980a-4478293083eb.png">

[Santhosh-Sellavel]

@stitesExpensify comment is broken can we get the trace as text if possible?

[stitesExpensify]

com.facebook.react.views.scroll.MaintainVisibleContentPositionHelper.updateScrollPosition (MaintainVisibleContentPositionHelper.java:105)
com.facebook.react.views.scroll.ReactScrollView.onLayoutChange (ReactScrollView.java:1093)
android.view.View.layout (View.java:22514)
android.view.ViewGroup.layout (ViewGroup.java:6528)
com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout (NativeViewHierarchyManager.java:254)
com.facebook.react.uimanager.NativeViewHierarchyManager.updateLayout (NativeViewHierarchyManager.java:222)
com.swmansion.reanimated.layoutReanimation.ReanimatedNativeHierarchyManager.updateLayout (ReanimatedNativeHierarchyManager.java:274)
com.facebook.react.uimanager.UIViewOperationQueue$UpdateLayoutOperation.execute (UIViewOperationQueue.java:169)
com.facebook.react.uimanager.UIViewOperationQueue$1.run (UIViewOperationQueue.java:915)
com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches (UIViewOperationQueue.java:1026)
com.facebook.react.uimanager.UIViewOperationQueue.access$2600 (UIViewOperationQueue.java:47)
com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded (UIViewOperationQueue.java:1086)
com.facebook.react.uimanager.GuardedFrameCallback.doFrame (GuardedFrameCallback.java:29)
com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame (ReactChoreographer.java:175)
com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame (ChoreographerCompat.java:85)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1278)
android.view.Choreographer.doCallbacks (Choreographer.java:1019)
android.view.Choreographer.doFrame (Choreographer.java:907)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1248)
android.os.Handler.handleCallback (Handler.java:900)
android.os.Handler.dispatchMessage (Handler.java:103)
android.os.Looper.loop (Looper.java:219)
android.app.ActivityThread.main (ActivityThread.java:8668)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:513)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1109)

[Christinadobrzyn]

@Santhosh-Sellavel @stitesExpensify Should we reopen the job in Upwork to get some contributors on this?

[stitesExpensify]

Let's wait a little longer, it still only has one occurrence from a week ago, so I'm not convinced it's worth it to try to find a fix yet

[Christinadobrzyn]

@stitesExpensify is ooo this week so let's hold on this another week.

[stitesExpensify]

No new occurrences. Closing this one.