Deploy Checklist: New Expensify 2022-10-24

[OSBotify]

Release Version: 1.2.19-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Render Emoji when typed with emoji code #10165
• Resolved: getting error for name at additional details page #10471
• fix: spacing on report typing indicator #10790
• Refactor Creating a Chat to be optimistic #11439
• Work with Form.js wrapper and refactor address form #11611
• Refactor workspace settings #11615
• Updated code to remove dependency on IS_LOADING_POLICY_DATA for Welcome.js #11627
• Add labels to chat list icons #11712
• [Refactor] VerifyIdentityForBankAccount #11719
• add Jekyll SEO tag plugin #11821
• Fix bank error message #11839
• fix "Fix the error" link on form submit #11847
• fix crash after login while trying to open profile details URL #11849
• Fix request call page errors #11864
• Fix/11261 Chat the name with a long email address is truncated #11900
• Fix: list rendering for RenderHTML #11926
• [No QA] Upgrade Fastlane #11942
• Upgrade react-navigation/drawer to use our fork #11944
• [NoQA] Update copy approval instructions in PR Checklist #11974
• Upgrade react-native to Expensify version 0.70.5  #11975
• Add character limit error for edit composer #11986
• Fix: In Request Call Page, space(' ‘) is considered as valid First name and Last name #11987
• Fix: Pressing ❌ doesn't dismiss the modal #11988
• fix Save button title wrapped issue on room settings page #11989
• Sort workspace alphabetically #11992
• Adding default avatar to workspace members page #11993
• Update expensify-common #11996
• use emoji instead of the alias in policy expense welcome message #12002
• update description on the Expensify Help site #12011
• Show Default Rooms when there is a team.expensify.com account on the report #12013
• [CP Staging] Fix hasExpensifyGuidesEmails call #12038
• Fix: Keyboard fix on attachment download #12053
• [No QA] Update to macos-12 and XCode 14 in GitHub Actions #12068
• Fix: Keyboard shortcut modal doesn't take whole width at the footer #12071
• [No QA] Upgrade actions/checkout, actions/setup-node, ruby/setup-ruby to latest #12072
• [No QA] Specify developer team to sign generated projects #12084
• [NO-QA] Remove hardcoded gradle build tools version #12091
• [No QA] Disable signing for generated projects #12092
• Onyx package revert #12099

Deploy Blockers:

• [$1000] User can't download the production app from playstore #11132
• IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0 #12115
• [HOLD for payment 2022-11-08] [$250] VBA - Error message not dismissed after selecting address from autofill option #12122
• Workspace - No error message and red dot displayed for failed workspace #12132

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.19-1 🚀

[Julesssss]

#12115 is in progress and should be resolved with the next Auth deploy.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.19-2 🚀

[mvtglobally]

@chiragsalian We are still working on the regression, but wanted to send an interim summary

PR #10471 is failing due to #12004
PR #11611 is failing due to #12122. We can't check it in PROD, to confirm if this is a blocker or no.
PR #11627 is blocked by #11595
PR #11839 & #11988 are blocked by #11796 on IOS and Android

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.19-2 has been deployed to staging 🎉

[dangrous]

#12132 Is a bug but reproducible on prod so not a blocker, checking off here.

[Julesssss]

@chiragsalian the Auth fix for #12115 has been merged, but is still awaiting deployment.

[Julesssss]

@chiragsalian I checked off #12115 which is now resolved

[mvtglobally]

@Julesssss Let us know if anything needs re-test. We would love a new build today 😉

[mvtglobally]

@chiragsalian @Julesssss Regression is completed

PR #10471 is failing due to #12004. Prod issue. Checking off
PR #11611 is failing due to #12122 (comment). Checking off
PR #11627 is blocked by #11595
PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android
PR #11719 is also failing due to #11461. Not a blocker.
PR #11839 is failing #12138. Repro in PROD.
PR #11926 (comment) need clarification
PR #11996 is failing #12139. Its not repro in PROD as behavior is different. Pls double check if this should be a blocker or no

[chiragsalian]

Checking off 12122 is its not a blocker as reported in this comment.

[chiragsalian]

I checked off #11132

[chiragsalian]

I've checked off #11926 since its one pending comment was answered - #11926 (comment)

[chiragsalian]

@mvtglobally, can you explain this,

PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android

I wasn't sure what the issue was specific to iOS and Android so can you explain or link someplace if I missed it?

[chiragsalian]

@mvtglobally, can you explain this,

PR #11627 is blocked by #11595

I couldn't find an explanation so I wasn't sure how those two were related. One suggestion @puneetlath mentioned is the steps in #11627 may not work on a controlled domain and maybe try the same on an uncontrolled domain.

[mvtglobally]

@chiragsalian

PR #11627 is blocked by #11595

We only have Expensifail domain accounts which are part of the BETA. As per PR steps we need to add a new user to the workspace, but we are getting error when trying to add a user. So team is not able to proceed with steps. If we give gMail account, Can it be added to Beta?

[chiragsalian]

Checking off #11627 as per comment.

[chiragsalian]

PR #11839 & #11988 & #11719 are blocked by #11796 on IOS and Android

Checking off #11839 & #11988 & #11719 since it cannot be tested on staging physical devices. Context.

[chiragsalian]

PR #11996 is failing #12139. Its not repro in PROD as behavior is different. Pls double check if this should be a blocker or no

Yup that's not a blocker. #11996 works fine for its expectation so I'm checking it off.

[chiragsalian]

I see a single crash on android for 1.2.19-1 for MaintainVisibleContentPositionHelper.java. Its something we seen before and it seems very rare - issue. I'm moving forward with deploy.

[chiragsalian]