Fix bank error message #11839

Puneet-here · 2022-10-14T09:43:31Z

Details

The error message for Add personal bank account page wasn't correct. We are just fixing that.

Fixed Issues

Tests

Update .env file to

NEW_EXPENSIFY_URL=https://staging.new.expensify.com/
EXPENSIFY_URL=https://staging.expensify.com/

Changed

App/src/libs/actions/BankAccounts.js

Lines 151 to 155 in a93858c

    
           key: ONYXKEYS.PERSONAL_BANK_ACCOUNT, 
        
           value: { 
        
               isLoading: false, 
        
               errors: null, 
        
               shouldShowSuccess: true,

to

                 key: ONYXKEYS.PERSONAL_BANK_ACCOUNT,
                 value: {
                     isLoading: false,
-                    errors: null,
-                    shouldShowSuccess: true,
+                    errors: {
+                        [DateUtils.getMicroseconds()]: Localize.translateLocal('paymentsPage.addBankAccountFailure'),
+                    },
                 },

Change shouldShowSuccess to false

App/src/pages/AddPersonalBankAccountPage.js

Line 110 in a93858c

{shouldShowSuccess ? (
Go to payments > add payment method
Bank account > Select fidelty at onfido and use user_good, pass_good
Select account > add password > press save & continue

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Go to settings > Payments > Add payment method
Bank account > Plaid flow
While in Plaid Sandbox mode, enter any data
You'll be brought back to Expensify
Select a bank account in the dropdown
Use a wrong password > Click Save & continue
Verify the error says "An unexpected error occurred while trying to add your bank account. Please try again."

Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Puneet-here · 2022-10-14T14:33:50Z

@ctkochan22 @eVoloshchak, the plaid flow can't be tested locally. Any idea how can I attach the screenshots for this PR?

eVoloshchak · 2022-10-14T16:19:46Z

@ctkochan22 @eVoloshchak, the plaid flow can't be tested locally. Any idea how can I attach the screenshots for this PR?

I think there is a dummy account, but I haven't tested it
Following the description of #8640

Log into a valid applause.expensifail.com account and Enable the Staging server
Tap on "Wells Fargo" bank and enter correct credentials (user_good and pass_good)

But for me there is no option to enable the staging server in settings

ctkochan22 · 2022-10-14T22:10:08Z

You can test plaid locally:

Update getPlaidLinkTokenParameters/index.js's redirect_uri to: return {redirect_uri: https://localhost:8080/${bankAccountRoute}`};`
From there you should be able to render our plaid sandbox. From there, you can use user_good and pass_good to get a 200 response

Puneet-here · 2022-10-17T08:57:30Z

I am seeing the plaid modal but when I choose a bank it redirect me to the bank login page

Screen.Recording.2022-10-17.at.2.18.03.PM.mov

ctkochan22 · 2022-10-17T16:46:10Z

hmmm what does your .env file look like? When testing on dev you should be hitting Plaid's sandbox

Puneet-here · 2022-10-17T17:12:42Z

hmmm what does your .env file look like? When testing on dev you should be hitting Plaid's sandbox

I didn't make any changes in .env file so it's not related to it. Let's ask at slack maybe someone will be able to help.

I have asked about it here.

ctkochan22 · 2022-10-18T04:22:43Z

Update your .env file to

NEW_EXPENSIFY_URL=https://staging.new.expensify.com/
EXPENSIFY_URL=https://staging.expensify.com/

Re-build npm run web/ios

Puneet-here · 2022-10-18T18:31:00Z

Hi @ctkochan22, thanks for all the help. I have attached the screenshots but I am not sure about the QA steps. The steps that were listed in the OP aren't useful now. We were getting this error earlier even on adding wrong password but some PR has added some validation for this so the error will only show up on failure. I am not sure how we can repro the failure.

For locally testing I have added these steps -

Update .env file to

NEW_EXPENSIFY_URL=https://staging.new.expensify.com/
EXPENSIFY_URL=https://staging.expensify.com/

Changed

App/src/libs/actions/BankAccounts.js

Lines 151 to 155 in a93858c

    
           key: ONYXKEYS.PERSONAL_BANK_ACCOUNT, 
        
           value: { 
        
               isLoading: false, 
        
               errors: null, 
        
               shouldShowSuccess: true,

to

                 key: ONYXKEYS.PERSONAL_BANK_ACCOUNT,
                 value: {
                     isLoading: false,
-                    errors: null,
-                    shouldShowSuccess: true,
+                    errors: {
+                        [DateUtils.getMicroseconds()]: Localize.translateLocal('paymentsPage.addBankAccountFailure'),
+                    },
                 },

Change shouldShowSuccess to false

App/src/pages/AddPersonalBankAccountPage.js

Line 110 in a93858c

{shouldShowSuccess ? (
Go to payments > add payment method
Bank account > Select fidelty at onfido and use user_good, pass_good
Select account > add password > press save & continue

eVoloshchak

I was unable to add the account locally, so tested this by changing the source code. Looks good

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-20T20:53:57Z

@ctkochan22 looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

ctkochan22 · 2022-10-20T20:54:10Z

Everything was checked off

OSBotify · 2022-10-20T20:58:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-25T00:13:44Z

🚀 Deployed to staging by @ctkochan22 in version: 1.2.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-26T22:33:08Z

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Puneet-here marked this pull request as ready for review October 14, 2022 14:32

Puneet-here requested a review from a team as a code owner October 14, 2022 14:32

melvin-bot bot requested review from ctkochan22 and eVoloshchak and removed request for a team October 14, 2022 14:32

fix error message

08b6e37

eVoloshchak approved these changes Oct 19, 2022

View reviewed changes

ctkochan22 approved these changes Oct 20, 2022

View reviewed changes

ctkochan22 merged commit 07fc7d7 into Expensify:main Oct 20, 2022

melvin-bot bot added the Emergency label Oct 20, 2022

ctkochan22 removed the Emergency label Oct 20, 2022

OSBotify mentioned this pull request Oct 24, 2022

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

45 tasks

kbecciv mentioned this pull request Oct 26, 2022

Payment - An incorrect bank error message displayed #12138

Closed

melvin-bot bot mentioned this pull request Oct 26, 2022

[HOLD for payment 2022-11-02] [$250] Bug: The error message is incorrect, it says "And unexpected error..." instead of "An unexpected error..." reported by @thesahindia #11652

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bank error message #11839

Fix bank error message #11839

Puneet-here commented Oct 14, 2022 •

edited

Loading

Puneet-here commented Oct 14, 2022

eVoloshchak commented Oct 14, 2022

ctkochan22 commented Oct 14, 2022

Puneet-here commented Oct 17, 2022

ctkochan22 commented Oct 17, 2022

Puneet-here commented Oct 17, 2022 •

edited

Loading

ctkochan22 commented Oct 18, 2022

Puneet-here commented Oct 18, 2022

eVoloshchak left a comment •

edited

Loading

melvin-bot bot commented Oct 20, 2022

ctkochan22 commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

	key: ONYXKEYS.PERSONAL_BANK_ACCOUNT,
	value: {
	isLoading: false,
	errors: null,
	shouldShowSuccess: true,

Fix bank error message #11839

Fix bank error message #11839

Conversation

Puneet-here commented Oct 14, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Puneet-here commented Oct 14, 2022

eVoloshchak commented Oct 14, 2022

ctkochan22 commented Oct 14, 2022

Puneet-here commented Oct 17, 2022

ctkochan22 commented Oct 17, 2022

Puneet-here commented Oct 17, 2022 • edited Loading

ctkochan22 commented Oct 18, 2022

Puneet-here commented Oct 18, 2022

eVoloshchak left a comment • edited Loading

Choose a reason for hiding this comment

PR Reviewer Checklist

melvin-bot bot commented Oct 20, 2022

ctkochan22 commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

Puneet-here commented Oct 14, 2022 •

edited

Loading

Puneet-here commented Oct 17, 2022 •

edited

Loading

eVoloshchak left a comment •

edited

Loading