Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment - An incorrect bank error message displayed #12138

Closed
kbecciv opened this issue Oct 26, 2022 · 5 comments
Closed

Payment - An incorrect bank error message displayed #12138

kbecciv opened this issue Oct 26, 2022 · 5 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Oct 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #11839

Action Performed:

  1. Go to URL https://staging.new.expensify.com/and login
  2. Go to settings > Payments > Add payment method
  3. Bank account > Plaid flow
  4. While in Plaid Sandbox mode, enter any data
  5. You'll be brought back to Expensify
  6. Select a bank account in the dropdown
  7. Use a wrong password > Click Save & continue
  8. Verify the error says "An unexpected error occurred while trying to add your bank account. Please try again."

Expected Result:

We should see "An unexpected error occurred while trying to add your bank account. Please try again" error message

Actual Result:

An incorrect bank error message displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5792329_11839_Web.mp4

Screen Shot 2022-10-25 at 3 30 18 PM

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Puneet-here
Copy link
Contributor

Hi, it's not a bug. Because of adding new validation you are seeing this error message which is expected. Now you won't see the error message mentioned at #11839 unless the api fails.

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

@yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2022

@yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

@yuwenmemon
Copy link
Contributor

Yes we just need to update the TestRail steps cc @Expensify/applauseleads

Incorrect Expensify password entered is the expected error message now for those test steps.

Closing this out! Let me know if you need me to create a separate issue for updating the test steps.

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants