[HOLD for payment 2022-11-08] [$250] VBA - Error message not dismissed after selecting address from autofill option

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #11611

Action Performed:

1. Launch the app and login
2. Select a workspace > Connect a bank account > Proceed to company info page
3. Click save and continue without entering any info
4. Enter company name
   5.Type an address and select from the auto fill option

Expected Result:

Validation error message dismissed for city and zip code field

Actual Result:

Validation error message not dismissed for city and zip code field

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.2.19-1
Reproducible in staging?: y
Reproducible in production?: Could not check in production
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5791732_error_msg.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mvtglobally]

Added Blocker label since we are not able to verify in PROD. Pls remove if you think this is not a blocker

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[arosiclair]

@kavimuru was there any issue submitting the form even with this error message problem?

[kavimuru]

@arosiclair We didn't have any issue in submitting the form.

[thesahindia]

Not a deploy blocker. It is reproducible on production. I had reported it on slack.

[arosiclair]

Reproduced on web in staging v1.2.19-2 and prod v1.2.18-10. This also seems to be purely cosmetic since you can still submit the form with the error message not dismissed so not a deploy blocker IMO. Removing deploy blocker label and marking as external.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

@arosiclair , before adding the External label, unassign yourself, otherwise GH can glitch and remove folks like it did here #12122 (comment)

Job is posted https://www.upwork.com/jobs/~01e2ce2fe9a4806aec

[melvin-bot]

📣 @Uros787 You have been assigned to this job by @mallenexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

Assigned to @Uros787 and created job, please apply.
https://www.upwork.com/jobs/~0169752bebd6f85148

[Uros787]

@jasperhuangg Thanks, ill get on it. Hopefully ill get it out today
@mallenexpensify thanks, applied

[Uros787]

Hi, me again, for some reason PR is not assigning reviewers correctly.
Sorry about that I'm not sure why is that. Just wanted to mention if you could take look

[mallenexpensify]

Ir looks like this hit production on 2022-11-04
#12239 (comment)

Going to pay tomorrow unless @sobitneupane or @jasperhuangg says I shouldn't (tomorrow instead of waiting 7 days because I'm OOO for a while)

[thesahindia]

I believe I am eligible for the reporting compensation since I had reported this issue on 16 Oct (slack post)

[jasperhuangg]

hey @thesahindia thanks for the bump we'll make sure to get you paid out as well, thanks for reporting! cc @mallenexpensify

[mallenexpensify]

@thesahindia for potential payment for reporting, would this issue have been fixed with the refactor from #10738 had you not reported it? I'm guessing not cuz that's why this issue was worked on. Gut checking myself before paying to make sure I'm not missing anything

[sobitneupane]

@mallenexpensify I was not assigned to PR of this issue and did not review the proposal. So, no payment for me.

[thesahindia]

I'm guessing not cuz that's why this issue was worked on.

Correct. PR for #10738 was already merged 18 days ago and didn't fix this.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @jasperhuangg is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@thesahindia and @Uros787 have been hired. Please comment once you've accepted and @kevinksullivan will pay (I'll be OOO). Thanks Kev
https://www.upwork.com/jobs/~0169752bebd6f85148

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[thesahindia]

Accepted, thanks!

[Uros787]

Also accepted, thanks

[kevinksullivan]

All set! Thanks everyone.