fix: spacing on report typing indicator #10790

mdneyazahmad · 2022-09-02T11:22:32Z

Details

Fixed Issues

$ #10486
PROPOSAL: #10486 (comment)

Tests

Open app
Create group of at least 3 members
Open every account from 3 different devices
Start typing in the group
Verify that "Name is typing..." appears below the composer on another device
Now start typing from one more device (typing on 2 device)
Verify that "Multiple users are typing..." is shown in the third device.

Verify that no errors appear in the JS console

QA Steps

Open app
Create group of at least 3 members
Open every account from 3 different devices
Start typing in the group
Verify that "Name is typing..." appears below the composer on another device
Now start typing from one more device (typing on 2 device)
Verify that "Multiple users are typing..." is shown in the third device.

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

…-indicator

parasharrajat

Android: this does not look completely vertically centered.

mdneyazahmad · 2022-09-07T07:54:34Z

@parasharrajat This is not just android thing but also other platforms. I had figured it out before, but I did not report it then. There is a margin of 5px in bottom of the composer.

App/src/styles/styles.js

Lines 1374 to 1376 in 85172f7

    
           chatFooter: { 
        
               marginBottom: 5, 
        
               paddingLeft: 20,

-marginBottom: 5,

This will fix the issue. Should we commit it here?

parasharrajat · 2022-09-07T12:58:44Z

I don't know why we have a bottom margin here. @shawnborton Could you please take a look and suggest us? Thank you.

Julesssss · 2022-09-07T13:57:22Z

I'm afraid I have no time to test this myself, but you should be able Android Studio to determine the exact margin/padding that is used natively. Build a dev build and use the Layout Inspector tool. You can select the TextInput View and it should show you the exact padding/margin attribute values.

parasharrajat · 2022-09-07T15:40:26Z

Thanks, @Julesssss. I already tested it and as @mdneyazahmad suggested there is an applied bottom margin by us. I am just curious to see the design impact of this. Before we remove it, it should be good to take confirmation from design team.

parasharrajat · 2022-09-07T20:42:06Z

@mdneyazahmad Please merge main to fix the tests.

…-indicator

mdneyazahmad · 2022-09-08T09:18:29Z

@parasharrajat merged main

shawnborton · 2022-09-08T15:53:39Z

@parasharrajat this screenshot here looks perfect to me:

I agree though that the bottom margin should be removed, not sure why/how that got there.

parasharrajat · 2022-09-08T16:27:24Z

Thanks, @shawnborton. the text has little extra space below it due to the margin otherwise, this is good.

@mdneyazahmad Please remove the margin and share the screenshots for android and web of

Typing indicator.
Offline indicator.
ExceededCommentLength indicator.

parasharrajat · 2022-09-14T14:39:05Z

Bump @mdneyazahmad

mdneyazahmad · 2022-09-15T12:19:01Z

Android

Web

parasharrajat · 2022-09-15T17:46:05Z

This is not the composer offline indicator. composer offline indicator is only shown on Web|desktop. So out of scope of this PR.

Thanks for the images. Testing it...

parasharrajat · 2022-09-15T17:47:10Z

@mdneyazahmad Did you remove the margin?

shawnborton · 2022-09-15T17:49:11Z

@parasharrajat your recent screenshot looks different from the one above...

vs.

The second screenshot is correct - there should be just a little bit of margin above the typing/offline indicator.

parasharrajat · 2022-09-15T17:55:43Z

Yeah, the first screenshot is an issue but not in the scope of this PR. That is a global offline indicator. Fixed my comment(mistype 😄)

shawnborton · 2022-09-15T17:59:31Z

Hmm but both the global offline indicator and the typing indicator should take up the exact same space right? So they do seem related to me.

parasharrajat · 2022-09-15T18:14:41Z

Yeah, they should. But this PR's issue was only talking about typing indicator which covers all the indicators of the composer. The global offline indicator resides in different parts of the code. But it can be done on this PR if @mdneyazahmad is up for it.

shawnborton · 2022-09-15T18:29:08Z

Yeah, I think we should not treat the styling of them as separate personally. Basically the exact space where the typing indicator shows up is also the exact space where the global offline indicator would show up as well, so we should make sure they are congruent.

shawnborton · 2022-10-18T14:54:01Z

So the screenshots look good to me, but I just tested the original bug again on the latest version of the app, and the bug is no longer happening. So before we merge these changes, do you know what might have happened?

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

parasharrajat · 2022-10-18T15:32:43Z

Strange, let me test.

parasharrajat · 2022-10-18T15:38:01Z

@mdneyazahmad Can you please confirm if the original issue is not more reproducible on the main? I can't reproduce.

If that is the case, let's revert all the changes for alignment and only remove the margin bottom.

mdneyazahmad · 2022-10-19T05:55:04Z

@parasharrajat I had pointed this earlier #10790 (comment). This issue is fixed here. Should we continue with the refactor, or remove the change made here?

parasharrajat · 2022-10-19T10:49:33Z

If that is the case, let's revert all the changes for alignment and only remove the margin-bottom.

mdneyazahmad · 2022-10-19T11:49:13Z

Updated! This PR now addresses a completely different issue than the linked PR.

parasharrajat · 2022-10-19T11:56:07Z

That's not an issue. At least our effort didn't go wasted.

parasharrajat

LGTM. Based on the latest discussion, we reverted the code and just fixed the margin.

cc: @Julesssss

shawnborton · 2022-10-19T13:34:22Z

Just want to confirm that the screenshots have been updated in the original comment?

Julesssss · 2022-10-21T09:58:03Z

@parasharrajat I had pointed this earlier #10790 (comment). This issue is fixed here.

Ah, that wasn't clear to me in that message. But thanks for clarifying

The latest edits to the description seem to show the most recent changes only, but @mdneyazahmad could you please confirm before I merge? Thanks

Julesssss

Approved and tested on all platforms:

Julesssss · 2022-10-21T11:03:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Julesssss · 2022-10-21T11:04:45Z

Stupid check. I'm ignoring this as I clearly filled the reviewer checklist.

Julesssss · 2022-10-21T11:05:21Z

See this, it is not an emergency.

OSBotify · 2022-10-21T11:09:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-25T00:13:35Z

🚀 Deployed to staging by @Julesssss in version: 1.2.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-26T22:32:59Z

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mdneyazahmad added 2 commits August 23, 2022 15:30

fix: spacing on report typing indicator

9280e15

style: fix eslint error

ec80b70

mdneyazahmad marked this pull request as ready for review September 5, 2022 12:02

mdneyazahmad requested a review from a team as a code owner September 5, 2022 12:02

melvin-bot bot requested review from Julesssss and parasharrajat and removed request for a team September 5, 2022 12:02

Merge branch 'main' of github.com:Expensify/App into fix/10486-typing…

34e954a

…-indicator

parasharrajat suggested changes Sep 6, 2022

View reviewed changes

Julesssss assigned mdneyazahmad Sep 7, 2022

Merge branch 'main' of github.com:Expensify/App into fix/10486-typing…

c6685ac

…-indicator

shawnborton self-requested a review October 18, 2022 14:50

shawnborton previously approved these changes Oct 18, 2022

View reviewed changes

docs: update comments

8315f26

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

mdneyazahmad dismissed stale reviews from shawnborton and parasharrajat via 8315f26 October 18, 2022 15:32

refactor: undo changes

018538d

parasharrajat approved these changes Oct 19, 2022

View reviewed changes

mdneyazahmad closed this by deleting the head repository Oct 21, 2022

mdneyazahmad reopened this Oct 21, 2022

Julesssss approved these changes Oct 21, 2022

View reviewed changes

Julesssss merged commit c2775d8 into Expensify:main Oct 21, 2022

melvin-bot bot added the Emergency label Oct 21, 2022

Expensify deleted a comment from melvin-bot bot Oct 21, 2022

Julesssss removed the Emergency label Oct 21, 2022

OSBotify mentioned this pull request Oct 24, 2022

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

45 tasks

fix: spacing on report typing indicator #10790

fix: spacing on report typing indicator #10790

Conversation

mdneyazahmad commented Sep 2, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

parasharrajat left a comment

Choose a reason for hiding this comment

mdneyazahmad commented Sep 7, 2022 • edited Loading

parasharrajat commented Sep 7, 2022

Julesssss commented Sep 7, 2022 • edited Loading

parasharrajat commented Sep 7, 2022

parasharrajat commented Sep 7, 2022

mdneyazahmad commented Sep 8, 2022

shawnborton commented Sep 8, 2022

parasharrajat commented Sep 8, 2022 • edited Loading

parasharrajat commented Sep 14, 2022

mdneyazahmad commented Sep 15, 2022 • edited Loading

Android

Web

parasharrajat commented Sep 15, 2022 • edited Loading

parasharrajat commented Sep 15, 2022

shawnborton commented Sep 15, 2022

parasharrajat commented Sep 15, 2022 • edited Loading

shawnborton commented Sep 15, 2022

parasharrajat commented Sep 15, 2022

shawnborton commented Sep 15, 2022

shawnborton commented Oct 18, 2022

parasharrajat commented Oct 18, 2022

parasharrajat commented Oct 18, 2022 • edited Loading

mdneyazahmad commented Oct 19, 2022 • edited Loading

parasharrajat commented Oct 19, 2022

mdneyazahmad commented Oct 19, 2022

parasharrajat commented Oct 19, 2022

parasharrajat left a comment • edited Loading

Choose a reason for hiding this comment

shawnborton commented Oct 19, 2022

Julesssss commented Oct 21, 2022

Julesssss left a comment

Choose a reason for hiding this comment

Julesssss commented Oct 21, 2022

Julesssss commented Oct 21, 2022

Julesssss commented Oct 21, 2022

OSBotify commented Oct 21, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

mdneyazahmad commented Sep 2, 2022 •

edited

Loading

mdneyazahmad commented Sep 7, 2022 •

edited

Loading

Julesssss commented Sep 7, 2022 •

edited

Loading

parasharrajat commented Sep 8, 2022 •

edited

Loading

mdneyazahmad commented Sep 15, 2022 •

edited

Loading

parasharrajat commented Sep 15, 2022 •

edited

Loading

parasharrajat commented Sep 15, 2022 •

edited

Loading

parasharrajat commented Oct 18, 2022 •

edited

Loading

mdneyazahmad commented Oct 19, 2022 •

edited

Loading

parasharrajat left a comment •

edited

Loading