[Refactor] VerifyIdentityForBankAccount #11719

MariaHCD · 2022-10-11T07:56:19Z

Redo of #10967 as it had to be reverted.

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/226853
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Log into an account on newdot and create a workspace
Go to Settings > {workspace} > Connect bank account
Add a bank account by connecting to Plaid following this SO: https://stackoverflow.com/c/expensify/questions/342
When you reach the personal information form, verify that you can submit it and reach the Onfido screen

5. Follow the prompts and submit the verification data

Verify you can proceed to the Beneficial Owners form

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Same as test steps

Screenshots

Web

1.New.Expensify.5.webm

Mobile Web - Chrome

1.New.Expensify.6.webm

Mobile Web - Safari

Screen.Recording.2022-10-17.at.12.59.30.PM.mov

Desktop

Screen.Recording.2022-10-17.at.1.04.52.PM.mov

iOS

Can't test on this platform as camera access is not possible via iOS simulator

Android

XRecorder_17102022_144522.mp4

…-identity-for-bank-account-v2

…-identity-for-bank-account-v2 # Conflicts: # src/libs/actions/BankAccounts.js

stitesExpensify · 2022-10-17T16:48:55Z

src/pages/ReimbursementAccount/RequestorOnfidoStep.js

+            key: ONYXKEYS.ONFIDO_TOKEN,
+        },
+        reimbursementAccountDraft: {
+            key: ONYXKEYS.REIMBURSEMENT_ACCOUNT_DRAFT,


Why is this not in the propTypes?

Good point, I updated the propTypes here and in BankAccountStep, CompanyStep and RequestorStep.

…-identity-for-bank-account-v2

…aftPropTypes"

MariaHCD · 2022-10-18T13:36:10Z

Just a heads up, I suspect that one of the reasons the VBBA flow is behaving incorrectly is because the Onfido step on staging/prod is still using the old deprecated API command instead of the new one refactored in this PR.

MariaHCD · 2022-10-18T13:36:23Z

This should be all set for review!

stitesExpensify

LGTM!

mananjadhav · 2022-10-19T04:58:08Z

I reviewed the code and that looks fine, but with respect to the testing and the scope of the issue, I don't have the context. I don't have access to the linked issue.

MariaHCD · 2022-10-19T07:14:26Z

Thanks, @mananjadhav. In terms of the context and scope of this PR, we're just using a new API command VerifyIdentityForBankAccount.

In regards to testing, I've outlined the steps in the tests section. Let me know if there's anything else I can clarify!

mananjadhav · 2022-10-19T15:00:14Z

@MariaHCD @nkuoch @stitesExpensify Is there a way to add Plaid account by the contributor?

Add a bank account by connecting to Plaid following this SO

Point 4 mentions a stackoverflow link but I can't access this.

mananjadhav · 2022-10-20T15:16:05Z

@MariaHCD For some reason it connects to me production plaid. I've enabled connect to staging servers, but it doesn't seem to be working for me.

stitesExpensify · 2022-10-20T19:45:34Z

I tested this on web and desktop, it is not testable on ios/android/mWeb via emulator because of onFido

stitesExpensify · 2022-10-20T19:47:52Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2022-10-20T19:56:09Z

@stitesExpensify looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

stitesExpensify · 2022-10-20T19:56:17Z

lies. Everything passed.

OSBotify · 2022-10-20T20:00:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-10-25T00:13:47Z

🚀 Deployed to staging by @stitesExpensify in version: 1.2.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-10-26T22:33:11Z

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MariaHCD added 3 commits October 11, 2022 11:47

Add new command VerifyIdentityForBankAccount

15a30f0

Add new component for Onfido flow during Requestor step

95e41dc

Use RequestorOnfidoStep component

e4e7310

MariaHCD self-assigned this Oct 11, 2022

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

64f843d

…-identity-for-bank-account-v2

MariaHCD marked this pull request as ready for review October 17, 2022 10:55

MariaHCD requested a review from a team as a code owner October 17, 2022 10:55

MariaHCD requested review from nkuoch and removed request for a team October 17, 2022 10:55

melvin-bot bot requested review from mananjadhav and stitesExpensify October 17, 2022 10:55

MariaHCD mentioned this pull request Oct 17, 2022

Fix: Onfido error and step back #11842

Merged

90 tasks

mananjadhav mentioned this pull request Oct 17, 2022

[HOLD for payment 2022-11-11] [$250] Andriod/IOS - Connect Bank Account - Company page displayed instead Personal Information Page after tap back button on Onfido flow, error message displayed #11461

Closed

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

87e96bc

…-identity-for-bank-account-v2 # Conflicts: # src/libs/actions/BankAccounts.js

nkuoch previously approved these changes Oct 17, 2022

View reviewed changes

stitesExpensify previously approved these changes Oct 17, 2022

View reviewed changes

stitesExpensify reviewed Oct 17, 2022

View reviewed changes

MariaHCD added 6 commits October 18, 2022 10:51

Add reimbursement account draft to prop types

34b3a8a

Update prop type

123c9cf

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

01a0328

…-identity-for-bank-account-v2

Fix propTypes for BankAccountStep

a98eb9a

Fix propTypes for CompanyStep

e03a8d7

Fix propTypes for RequestorStep

75ab5b9

MariaHCD dismissed stale reviews from stitesExpensify and nkuoch via 75ab5b9 October 18, 2022 07:21

MariaHCD requested review from stitesExpensify and nkuoch October 18, 2022 07:23

nkuoch previously approved these changes Oct 18, 2022

View reviewed changes

Fix linter error Missing file extension for "./reimbursementAccountDr…

aa460a9

…aftPropTypes"

MariaHCD dismissed nkuoch’s stale review via aa460a9 October 18, 2022 13:23

stitesExpensify approved these changes Oct 18, 2022

View reviewed changes

nkuoch approved these changes Oct 20, 2022

View reviewed changes

stitesExpensify merged commit 9a13fa3 into main Oct 20, 2022

stitesExpensify deleted the maria-refactor-verify-identity-for-bank-account-v2 branch October 20, 2022 19:56

melvin-bot bot added the Emergency label Oct 20, 2022

stitesExpensify removed the Emergency label Oct 20, 2022

OSBotify mentioned this pull request Oct 24, 2022

Deploy Checklist: New Expensify 2022-10-24 #12108

Closed

45 tasks

MariaHCD mentioned this pull request Oct 25, 2022

Add FullPageOfflineBlockingView for Requestor Onfido step #12113

Merged

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] VerifyIdentityForBankAccount #11719

[Refactor] VerifyIdentityForBankAccount #11719

MariaHCD commented Oct 11, 2022 •

edited by stitesExpensify

Loading

stitesExpensify Oct 17, 2022

MariaHCD Oct 18, 2022

MariaHCD commented Oct 18, 2022

MariaHCD commented Oct 18, 2022

stitesExpensify left a comment

mananjadhav commented Oct 19, 2022

MariaHCD commented Oct 19, 2022

mananjadhav commented Oct 19, 2022

mananjadhav commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022 •

edited

Loading

stitesExpensify commented Oct 20, 2022 •

edited

Loading

melvin-bot bot commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

[Refactor] VerifyIdentityForBankAccount #11719

[Refactor] VerifyIdentityForBankAccount #11719

Conversation

MariaHCD commented Oct 11, 2022 • edited by stitesExpensify Loading

Details

Fixed Issues

Tests

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

stitesExpensify Oct 17, 2022

Choose a reason for hiding this comment

MariaHCD Oct 18, 2022

Choose a reason for hiding this comment

MariaHCD commented Oct 18, 2022

MariaHCD commented Oct 18, 2022

stitesExpensify left a comment

Choose a reason for hiding this comment

mananjadhav commented Oct 19, 2022

MariaHCD commented Oct 19, 2022

mananjadhav commented Oct 19, 2022

mananjadhav commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022 • edited Loading

stitesExpensify commented Oct 20, 2022 • edited Loading

melvin-bot bot commented Oct 20, 2022

stitesExpensify commented Oct 20, 2022

OSBotify commented Oct 20, 2022

OSBotify commented Oct 25, 2022

OSBotify commented Oct 26, 2022

MariaHCD commented Oct 11, 2022 •

edited by stitesExpensify

Loading

stitesExpensify commented Oct 20, 2022 •

edited

Loading

stitesExpensify commented Oct 20, 2022 •

edited

Loading