IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log in with any account
3. Refresh the page
4. Cancelled all unpaid money requests
5. Refresh the page

Expected Result:

LHN now shows many red and green bars next to new chats at top for amounts owed to me and others

Actual Result:

IOU icons should not be displayed for canceled money requests

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2546.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Trying to get this auth PR merged to fix this hopefully https://github.com/Expensify/Auth/pull/7095

[Julesssss]

This is an internal issue.

Thankfully I have a PR in review which was improving this logic, and will resolve the issue. Preventing the need for a revert.

[Julesssss]

Until the last Web-E deploy, this issue existed on staging. A fix for that issue uncovered this bug.

The problem is that getActiveIOUReport retrieves IOUReports with a total of 0. This occurs when an iouReport is opened, but then all ious are rejected or canceled. This Auth PR introduces a change where the iouReportID is only returned from GetChats if the iouReport has a non-zero total. We then set the iouReportID as a param on the chatReport.

In addition, this Web-E PR will complete the fix, by linking and returning iouReports in our API commands ONLY if the iouReportID is included.

[mountiny]

Auth PR here https://github.com/Expensify/Auth/pull/7095

[Julesssss]

Auth PR has been approved, now we're just awaiting @cead22's review as he previously added some comments which were resolved.

[Julesssss]

This was merged, but awaiting Auth deployment. Adding a note to the deploy checklist that it should be unblocked soon.

[Julesssss]

Fixed, removing this blocker from the deploy checklist.