Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/11261 Chat the name with a long email address is truncated #11900

Conversation

tienifr
Copy link
Contributor

@tienifr tienifr commented Oct 17, 2022

Details

We want an account name with a long email address that should not be truncated in the welcome message. This PR fixes it

Fixed Issues

$ #11261
Proposal: #11261 (comment)

Tests

  1. Login with account A
  2. Create an account B with long email and login on a different device
  3. Search for account B and start a chat
  4. Verify that the email of account B is completely visible at the welcome message
  5. Now use the second device and search account A and start typing in the chat
  6. Check the chat from account A and verify that the email in typing indicator doesn't go outside of the screen
  7. Hard code in local as this comment then type from account B
  8. Verify that there's some gap between typing indicator and the character limit exceeded error
  • Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

  1. Login with account A
  2. Create an account B with long email and login on a different device
  3. Search for account B and start a chat
  4. Verify that the email of account B is completely visible at the welcome message
  5. Now use the second device and search account A and start typing in the chat
  6. Check the chat from account A and verify that the email in typing indicator doesn't go outside of the screen
  7. Paste more than 60k characters at composer at the chat with account B and type from account B
  8. Verify that there's some gap between typing indicator and character limit exceeded error
  • Verify that no errors appear in the JS console

Screenshots

Web

  1. Welcome Text

Screen Shot 2022-10-19 at 21 17 53

2. User is typing and character limit exceeded error

Screen Shot 2022-10-19 at 21 31 49

Mobile Web - Chrome

  1. Welcome text
    z3813190195368_e8256885af465e375516ed0c5f05c726

  2. User is typing and character limit exceeded error
    z3813190138936_63f1274b716426c619cefb4353ca5a5c

Mobile Web - Safari

  1. Welcome text

Screen Shot 2022-10-19 at 21 58 41

  1. User is typing and character limit exceeded error

Screen Shot 2022-10-19 at 22 03 19

Desktop

  1. Welcome text

Screen Shot 2022-10-19 at 21 54 14

  1. User is typing and character limit exceeded error

Screen Shot 2022-10-19 at 21 53 23

iOS

  1. Welcome text

Screen Shot 2022-10-19 at 22 23 34

  1. User is typing and character limit exceeded error

Screen Shot 2022-10-19 at 22 22 59

Android

  1. Welcome text

Screen Shot 2022-10-19 at 22 15 02

  1. User is typing and character limit exceeded error

Screen Shot 2022-10-19 at 22 40 44

@tienifr tienifr requested a review from a team as a code owner October 17, 2022 02:08
@melvin-bot melvin-bot bot requested review from pecanoro and thesahindia and removed request for a team October 17, 2022 02:08
@tienifr tienifr force-pushed the fix/11261-mweb-Chat-The-name-with-a-long-email-address-is-truncated branch from 864cac9 to 092171d Compare October 17, 2022 02:44
@tienifr tienifr marked this pull request as draft October 17, 2022 05:44
@tienifr tienifr marked this pull request as ready for review October 17, 2022 06:34
@thesahindia
Copy link
Member

@tienifr,

  1. Include the proposal link below the issue link.
  2. Add 4th step in Tests and QA to tell what needs to be verified (e.g. verify that the whole email is visible in the welcome message)
  3. Also add steps for the second part of this issue (email at typing indicator) and steps to repro the character limit exceeded error
  4. At tests you have to write the steps that you have taken locally to test that the PR is working correctly.

And one last suggestion for future Pull requests, refrain from using force push, when you have conflicts just merge main and resolve it.

@tienifr
Copy link
Contributor Author

tienifr commented Oct 18, 2022

Hi @thesahindia Thanks for your comment. I just fixed PR and resolved the conflict. Please help to check again.

@thesahindia
Copy link
Member

@tienifr, the steps aren't clear, please try to write the steps as clear as possible.

QA steps

  1. Login with account A
  2. Create an account B with long email and login on a different device
  3. Search for account B and start a chat
  4. Verify that the email of account B is completely visible at the welcome message
  5. Now use the second device and search account A and start typing in the chat
  6. Check the chat from account A and verify that the email in typing indicator doesn't go outside of the screen
  7. Paste more than 60k characters at composer at the chat with account B and type from account B
  8. Verify that there's some gap between typing indicator and character limit exceeded error

You can copy paste these steps.

At tests you have included the staging URL but you have to provide the steps that you taken locally, also include how you reproduced character limit exceeded error and also another step telling all the things that you verified(e.g. I verified the email is fully visible in the welcome message )

Also the fixed issue section should look like this
Screenshot 2022-10-18 at 8 29 56 PM

@tienifr
Copy link
Contributor Author

tienifr commented Oct 18, 2022

@thesahindia Thanks for your comment, I just fix PR and took note for the next PR. Please help to check again.

@thesahindia
Copy link
Member

@tienifr, sorry but you will need to update the screenshots after making the suggested change.
Right now in the screenshots for email at welcome text there's also character limit exceeded error, which can create confusions, so please update that as well.

Also a suggestion for future PRs: create more commits, refrain from changing everything in one single commit. It helps others to understand about the code change.

@tienifr
Copy link
Contributor Author

tienifr commented Oct 19, 2022

@thesahindia Thanks for noting, I took note for the next PR. And I just fixed your comment, Could you help to check again?

@thesahindia
Copy link
Member

There's an android only issue. In android (check the device in the left) there's some extra space at the right side of the typing indicator. This is already present at production so not related to this PR.
Screenshot 2022-10-19 at 3 05 17 PM

@thesahindia
Copy link
Member

Thanks for the changes @tienifr.

LGTM!

cc: @pecanoro

C+ reviewed 🎀👀🎀

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@pecanoro pecanoro merged commit 63f0efc into Expensify:main Oct 20, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.2.19-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants