-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/11261 Chat the name with a long email address is truncated #11900
Fix/11261 Chat the name with a long email address is truncated #11900
Conversation
864cac9
to
092171d
Compare
And one last suggestion for future Pull requests, refrain from using force push, when you have conflicts just merge main and resolve it. |
Hi @thesahindia Thanks for your comment. I just fixed PR and resolved the conflict. Please help to check again. |
@tienifr, the steps aren't clear, please try to write the steps as clear as possible. QA steps
You can copy paste these steps. At tests you have included the staging URL but you have to provide the steps that you taken locally, also include how you reproduced character limit exceeded error and also another step telling all the things that you verified(e.g. I verified the email is fully visible in the welcome message ) |
@thesahindia Thanks for your comment, I just fix PR and took note for the next PR. Please help to check again. |
@tienifr, sorry but you will need to update the screenshots after making the suggested change. Also a suggestion for future PRs: create more commits, refrain from changing everything in one single commit. It helps others to understand about the code change. |
@thesahindia Thanks for noting, I took note for the next PR. And I just fixed your comment, Could you help to check again? |
Thanks for the changes @tienifr. LGTM! cc: @pecanoro C+ reviewed 🎀👀🎀
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀
|
Details
We want an account name with a long email address that should not be truncated in the welcome message. This PR fixes it
Fixed Issues
$ #11261
Proposal: #11261 (comment)
Tests
PR Review Checklist
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
2. User is typing and character limit exceeded error
Mobile Web - Chrome
Welcome text
User is typing and character limit exceeded error
Mobile Web - Safari
Desktop
iOS
Android