Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Workspace - Error message "There was a problem adding this workspace member" displayed when adding non-existing account #11595

Closed
kbecciv opened this issue Oct 4, 2022 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Oct 4, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with your account
  3. Go to Setting - Workspace.
  4. Click Manage members.
  5. Click on Invite.
  6. Add a non-existent user and click Invite.

Expected Result:

No error message "There was a problem adding this workspace member" and console error when adding non-existing account

Actual Result:

Error message "There was a problem adding this workspace member when adding non-existing account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.11.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1320.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2022

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2022

@puneetlath Eep! 4 days overdue now. Issues have feelings too...

@puneetlath
Copy link
Contributor

It looks like this most likely has to do with inviting a member on a Domain Controlled domain, so will need to be Internal.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2022
@puneetlath puneetlath added the Internal Requires API changes or must be handled by Expensify staff label Oct 10, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2022

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

@puneetlath Still overdue 6 days?! Let's take care of this!

@puneetlath
Copy link
Contributor

Still expecting to get to this this week.

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

@puneetlath
Copy link
Contributor

It looks like the problem is happening here, where we try to get the authToken for the closed accounts in order to push the policy reports into their Onyx data. So we should only do that if the account is open.

@melvin-bot melvin-bot bot removed the Overdue label Oct 25, 2022
@puneetlath
Copy link
Contributor

PR sent.

@puneetlath
Copy link
Contributor

PR has been merged.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 1, 2022

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath
Copy link
Contributor

This was deployed to production yesterday.

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

2 participants