[$1000] User can't download the production app from playstore

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to playstore
2. Download new expensify
3. Open the app and login
4. Check if it has a stg badge at top

Expected Result:

The app should not have the stg badge and stg features

Actual Result:

The app is stg

Workaround:

unknown

Platform:

Where is this issue occurring?

• Android

Version Number:
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork job URL: https://www.upwork.com/jobs/~0138615bf32be2c02c
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662562500746549?thread_ts=1660710162.573049&cid=C01GTK53T8Q

View all open jobs on GitHub

[mallenexpensify]

@mvtglobally are you able to reproduce?

[melvin-bot]

@mvtglobally Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

@mvtglobally can you see if you're able to reproduce?

[melvin-bot]

@mvtglobally 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mvtglobally]

@mallenexpensify @mallenexpensify I was checking with the team on the same. There is a tricky way to download PROD build on Android with the same device as you have staging. Currently we all see STG
Since all our testers are already getting BETA (STG) builds, not sure this result is accurate.
Is there any chance you can ask someone in Expensify internally who DOES NOT have staging build to download PROD build?

video_2022-10-18_01-46-04.mp4

[mallenexpensify]

Asking internally https://expensify.slack.com/archives/C01SKUP7QR0/p1666291488048139

[mallenexpensify]

Gonna close cuz @alex-mechler was able to help test and it looks like its not repro

[melvin-bot]

Be sure to fill out the Contact List!

[Puneet-here]

@mallenexpensify, in the screenshot I can see the stg badge at the login page.

[mallenexpensify]

ah shit... you're right @Puneet-here , great 👀 .
Reopening and assigning an engineer to take a look

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Oh, I think this is a dupe of https://github.com/Expensify/Expensify/issues/237206 and it is probably internal

[iwiznia]

Oh wait, maybe not. Forget that.

[iwiznia]

Ummm, isn't play store downloading the staging app because you are in the beta???

[Puneet-here]

Ummm, isn't play store downloading the staging app because you are in the beta???

No, I don't think this is the case because external contributors aren't in the beta and I have tried some different accounts that I've never used at expensify but I still couldn't download the production app.

[iwiznia]

Ah ok ok, thanks for the context

[mallenexpensify]

@maddylewis taking this back, it was assigned to me before I went OOO.
Let's keep this daily since it sounds like @srikarparsi and @mountiny found the root cause.

[srikarparsi]

asked for example of play store url text here to help me write regex.

[srikarparsi]

Discussing a more long term solution here

[srikarparsi]

Unassigning myself as andrew is working on the fix

[AndrewGable]

PR sent 📤

[melvin-bot]

@AndrewGable, @mallenexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

This will hit the 'one week after deployed to production' milestone tomorrow. It looks like the only person dude compensation is @Puneet-here for reporting. If I'm missing someone, please comment

[mountiny]

Asked in the PR if we had closed to loop on the ProductionQA actually.

[AndrewGable]

@mallenexpensify Sounds good 👍 - Testing passed

[mallenexpensify]

@Puneet-here can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~019d52081ca835b9ef

[Puneet-here]

Accepted @mallenexpensify

[mallenexpensify]

@Puneet-here paid $250 for reporting
@AndrewGable we want to update regression test steps for this, right? If so I'll leave open and tackle the last piece.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/253420

[AndrewGable]

Yep - We can add a regression test for this.

[mallenexpensify]

Posted regression test steps in #bug-zero
https://expensify.slack.com/archives/C01SKUP7QR0/p1672711388472929

[mallenexpensify]

Likely running with this for regression test steps, will create the GH for tomorrow

Under "Account Setting" in TR add a new test titled About - App download links
Add steps

1. Ensure App isn't loaded on device
2. Click Android on an Android device
3. Follow steps to download app
4. Verify app has downloaded to device
5. Verify the app does not way staging on the login page.

I put 'does not' cuz that should be the expected behavior and staging should be the edge or test case, right? I'm still new to these steps, I'm assuming we're always creating them for the production version of the app, let me know if that's not correct

[mallenexpensify]

Issue created to update test steps https://github.com/Expensify/Expensify/issues/253420

Are these needed before we close this out @AndrewGable ?

• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[AndrewGable]

I do not think this is required, the code relied on an external site that we do not have control over, so it actually started to fail without a code change on our side.

[mallenexpensify]

Thanks @AndrewGable.
@thesahindia are you able to complete the above steps? I think the process we're working towards is to have C+ complete all items they can. For any that are related to backend changes, the C+ would comment on the issue, tag the assigned internal engineer, and provide reasoning why they're unable to complete the steps.

[thesahindia]

I don't have much knowledge on this issue since I didn't do anything here. Just a heads-up that @srikarparsi mentioned that it was a regression from #9960

[mountiny]

I think as Andrew mentioned, @mallenexpensify we should be good to close this one out, seems like the Google API response has changed and that introduced this problem. We could not do much else other than have a regression test which will check for this.

[mallenexpensify]

K, closing. Thanks @thesahindia and @mountiny