[HOLD App PR#12181] [$1000] [BUG] Pay with Expensify is NOT selecting ACH automatically

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Set your default payment method in Settings > Payment
3. Get IOU from another user
4. Click Pay in chat
5. Note the

Expected Result:

If user has Bank account setup, we should not be asking again for the new payment

Actual Result:

Pay with Expensify is NOT selecting ACH automatically

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.18-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.549.mp4

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664998800299199

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[michaelhaxhiu]

@ntrepanier can you please prioritize this one, as it was initially missed by mistake (in our bug reporting flow)? Refer to the slack thread above for context.

[michaelhaxhiu]

Note for the C+ that gets assigned, this GH should include a Root Cause Analysis (RCA) investigation since it's clearly a regression.

[melvin-bot]

@ntrepanier Huh... This is 4 days overdue. Who can take care of this?

[ntrepanier]

Sorry. It assigned while I was OOO. On it.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ntrepanier]

@johnmlee101 Can you help me determine if this would be external or internal?

[johnmlee101]

{triggerKYCFlow => (

seems to be self-referencial

App/src/components/SettlementButton.js

Line 89 in 62394cc

{triggerKYCFlow => (

I'm a bit confused, but I'm pretty sure this is external so marking it

[melvin-bot]

Current assignee @ntrepanier is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[smrutiparida]

@mvtglobally The bank account added is still not a default account as I can see from the screenshot attached. Underlined below.

As an external developer though I have not reproduced the steps but from the code it seems evident that though bank account is found, the isDefaultCredit() is returning false as the account is not a default account to receive payment.

May I hence suggest to make the account default and see one more. I hope that is what is the expected result.

[puneetlath]

@smrutiparida the issue exists even when a default payment method is set. Here's an example from my account:

I have a default payment method set, but it's still asking me how I want to pay when I click "pay with Expensify". If I choose bank account, it takes me to the add a bank account page. So in some way, this page is not registering that I already have a bank account set.

[puneetlath]

Doubled to $1000.

Job post is here: https://www.upwork.com/jobs/~01744f6f4e5bb3bfe4

[melvin-bot]

@puneetlath, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thomas-coldwell]

Trying to reproduce this issue, but unable to add a bank account as the default payment method - getting the following 404 output in console when I attempt it:
Finished API request - {"command":"MakeDefaultPaymentMethod","jsonCode":404,"requestID":"76665b147b9f7505-SJC"}

[MariaHCD]

Just a heads up here, I actually have the fix for this included in this PR: #12181

bankAccount.isDefaultCredit() is currently returning false because the this.json.defaultCredit property has now moved to this.json.accountData.defaultCredit as part of #10447

[mountiny]

Updated this issue to reflect it is internal. Sorry for the confusion. It is easy to overlook that some issue overlap and miss this. Hopefully this issue will be resolved. with the aforementioned PR.

[puneetlath]

Ok cool, good to know. Thanks @mountiny and @MariaHCD!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)

[puneetlath]

@MariaHCD would you be able to help me out with figuring out which PR caused the bug?

[MariaHCD]

@puneetlath It was due to this backend change: https://github.com/Expensify/Web-Expensify/pull/34592

The format of the bank account data in Onyx changed but the corresponding model in the App was not. cc: @Justicea83

There was also a RCA here but we didn't catch this particular bug because features related to the Expensify wallet are not being QA'd right now. That's going to change with the completion of https://github.com/Expensify/Expensify/issues/232687

[puneetlath]

Ok awesome, thanks for the info @MariaHCD.

And just checking, this is still on hold, is that right? If so, mind linking what we are holding for? Thanks!

[mountiny]

I think Maria is ooo til Friday so stepping in, from the previous comments this is on hold for #12181

It is in staging now so we should be bale to retest there, but we can wait for another deploy I assume

[mountiny]

I have read and reviewed this Project Manager Application!

[puneetlath]

Just tested on staging and looks like it's working so I think we're good to go here. Thanks @MariaHCD!

[mountiny]

I have read and reviewed this Manager Application!

Oops, luckily i dont have that chore. Wondering if it created some bugbot issue 🤔

nah, nothing, it will just add save me but it will not matter for the autoassigner.