Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online #11202

Closed
kbecciv opened this issue Sep 22, 2022 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Sep 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate any conversation
  2. Disable the internet connection
  3. Click on the emoji picker and send emoji
  4. Go back online.

Expected Result:

When switching from offline to online, one emoji must be sent

Actual Result:

Emoji sent while offline, showing doubled green lines when back online

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.2.4.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5743677_emoji_2209.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alex-mechler
Copy link
Contributor

Does both emojis only show up on the sender's side, or does the recipient also get two copies of the message?

@kbecciv
Copy link
Author

kbecciv commented Sep 24, 2022

@alex-mechler Only appears in sender's side.

@melvin-bot melvin-bot bot added the Overdue label Sep 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

@alex-mechler Whoops! This issue is 2 days overdue. Let's get this updated quick!

@alex-mechler
Copy link
Contributor

Okay perfect, this is likely external then, so applying the label!

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2022
@alex-mechler alex-mechler added External Added to denote the issue can be worked on by a contributor Overdue labels Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to @sketchydroide (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online [$250] IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online Sep 26, 2022
@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2022
@sketchydroide
Copy link
Contributor

This seems related to #11237
Where a similar thing is happening (it's just one line not 2) I think this is more about duplication of messages than the Green lines, you can see that it also duplicated the emoji.

@sketchydroide
Copy link
Contributor

not sure if that should be am external, as the duplication is normally to do with Sequence numbers, and we are revamping that.
What do you think @Expensify/mobile-deployers?

@sketchydroide
Copy link
Contributor

removing external for now, we can add it later.

@sketchydroide sketchydroide removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 26, 2022
@sketchydroide
Copy link
Contributor

not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 30, 2022
@sketchydroide
Copy link
Contributor

will set this as weekly, as there is no need to update this daily

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@sketchydroide sketchydroide added Weekly KSv2 and removed Daily KSv2 labels Oct 3, 2022
@sketchydroide sketchydroide changed the title [$250] IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online Oct 3, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 11, 2022
@MitchExpensify
Copy link
Contributor

What are we doing with this issue? Is it being handled internally or are we waiting on something before making external?

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2022
@sketchydroide
Copy link
Contributor

I'm currently trying to figure one out that is similar, was trying to replicate it on Friday locally and wasn't able, I'm going to try this again today and try to use staging API instead of the Dev machine (still a local build though)

Hopefully I will have a better answer soon

@sketchydroide
Copy link
Contributor

I can no longer replicate this, neither in staging or dev.
I do get duplicated Messages, but I think that is a different issue and the changes on the sequenceNumber

Screenshot 2022-10-14 at 16 37 11

@sketchydroide
Copy link
Contributor

@kbecciv can your team take a look to see if it still happens?

@roryabraham
Copy link
Contributor

Oh, I'm 99% certain this is the same bug as "stuck chats", so I'm going to put this on HOLD for the Deprecate Sequence Number doc and take it over.

@roryabraham roryabraham changed the title IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online [HOLD] IOS - Emoji - Emoji sent while offline, showing doubled green lines when back online Oct 15, 2022
@sketchydroide
Copy link
Contributor

@roryabraham I think the double green lines is no longer happening (the original issue).
The double messages/emojis is the only thing I was able to find this time, but entirely related to the issue, it what now happens instead of the previous bug.
I don't think we need to hold this GH, just make sure the double green lines is no longer happening, is not we can close it.

@kbecciv
Copy link
Author

kbecciv commented Oct 17, 2022

@sketchydroide Checking if the issue is still reproduce, update you shortly

@kbecciv
Copy link
Author

kbecciv commented Oct 17, 2022

@sketchydroide As you mention above - the double green lines is no longer happening (the original issue). Build is 1.2.16.4
The double messages I was able to reproduce this time, please attached.

RPReplay_Final1666015830.MP4

@sketchydroide
Copy link
Contributor

Thanks, I think the double messages is a different thing, not sure if there is already a GH for it.

@kbecciv
Copy link
Author

kbecciv commented Oct 17, 2022

Only KI I think of #10550, please check

@sketchydroide
Copy link
Contributor

yep those are the steps I took 👍🏼

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@roryabraham
Copy link
Contributor

Okay, so we can close this out then if the original issue is not reproducible?

@MitchExpensify
Copy link
Contributor

so we can close this out then if the original issue is not reproducible?

I think so, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants