Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - The error message is displayed 2 times and sometimes not displayed with a dot #11222

Closed
kavimuru opened this issue Sep 22, 2022 · 5 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #11037

Action Performed:

1.Click on green fab icon (+)
2.Create a new room with the name "foo"
3.Repeat step 1, and create a new room with the name "bar" in the same workspace as room "foo".
4.Go to room "bar" -> Room settings
5.Rename it to "foo"
6. Click Save multiple times

Expected Result:

The error message should appear with a dot and not double

Actual Result:

The error message is displayed 2 times and sometimes Dot is not displayed for the error message

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.2.5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/191864711-7af0fc20-7319-410c-bc70-18eea0346a6f.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2022

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2022

@jasperhuangg Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

@jasperhuangg Still overdue 6 days?! Let's take care of this!

@jasperhuangg
Copy link
Contributor

Sorry, was out sick last week. This should be a relatively straightforward fix.. we're duplicating the error displaying somewhere, I can look into this.

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Oct 4, 2022
@melvin-bot melvin-bot bot closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants