Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Messages appearing in compose box after message sent (then app closed soon after) #11293

Closed
mvtglobally opened this issue Sep 26, 2022 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Needs Reproduction Reproducible steps needed

Comments

@mvtglobally
Copy link

mvtglobally commented Sep 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sent message
  2. Immediately quit NewDot after
  3. Opened NewDot next morn and see a draft message for the one sent yesterday

Expected Result:

No duplicated messages should appear

Actual Result:

Multiple messages appear in the conversation

Related issues:
#10615
#10550

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.3-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image - 2022-09-26T155043 972

[duplicates at startup.txt](https://github.com/Expensify/App/files/9649237/duplicates.at.startup.txt) [scroll to make duplicate message.txt](https://github.com/Expensify/App/files/9649238/scroll.to.make.duplicate.message.txt)
2022-09-22_11-49-55.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663776833139009?thread_ts=1663714013.290919&cid=C01GTK53T8Q

View all open jobs on GitHub

@marcaaron
Copy link
Contributor

Surely we have already logged this somewhere...? It's the same bug that will be fixed by sequenceNumber deprecation which @roryabraham is writing the detailed portion for now.

@mallenexpensify mallenexpensify changed the title Duplicate Messages appearing Duplicate Messages appearing in compose box after message sent (then app closed soon after) Sep 27, 2022
@mallenexpensify mallenexpensify changed the title Duplicate Messages appearing in compose box after message sent (then app closed soon after) [HOLD Sequence #] Duplicate Messages appearing in compose box after message sent (then app closed soon after) Sep 27, 2022
@mallenexpensify
Copy link
Contributor

What's different for this, or what I hadn't experienced is the duplicate is in the compose box. Updated title

[HOLD Sequence #] Duplicate Messages appearing in compose box after message sent (then app closed soon after)

https://github.com/Expensify/Expensify/issues/227234

I'd assign to myself to monitor or test once the time is right but I'm OOO for a month soon

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 30, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD Sequence #] Duplicate Messages appearing in compose box after message sent (then app closed soon after) [HOLD 227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) Oct 5, 2022
@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@Christinadobrzyn
Copy link
Contributor

Since this is on hold until https://github.com/Expensify/Expensify/issues/227234 is resolved, going to move this to weekly

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Oct 20, 2022
@Christinadobrzyn
Copy link
Contributor

Moving to weekly since this is on [Hold]

@aldo-expensify
Copy link
Contributor

This is probably the same thing, but I can consistently reproduce it with the following steps:

  1. Send the following message in a chat:
    This is the list of domains that I'm explicitly ignoring in the Firm MRR query: 'aol.com', 'att.net', 'bellsouth.net', 'bills.expensify.com', 'expensify.cash', 'btinternet.com', 'cheerful.com', 'chromeexpensify.com', 'comcast.net', 'cox.net', 'evernote.user', 'expensify.sms', 'gmail.com', 'gmail.con', 'googlemail.com', 'hey.com', 'hotmail.co.uk', 'hotmail.com', 'hotmail.fr', 'hotmail.it', 'icloud.com', 'live.com', 'mac.com', 'mail.ru', 'me.com', 'msn.com', 'outlook.com', 'privaterelay.appleid.com', 'qq.com', 'sasktel.net', 'sbcglobal.net', 'verizon.net', 'yahoo.ca', 'yahoo.co.in', 'yahoo.co.uk', 'yahoo.com.br', 'yahoo.com', 'ymail.com', 'expensifail.com'
  2. Click on a different chat
  3. Click on the chat where you sent the first message on step 1.
  4. You should see it repeating

Weirdly this doesn't happen to me with any message, but with this specific content it does.

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2022
@Christinadobrzyn
Copy link
Contributor

I can replicate that in staging.

  1. Open a chat in staging
  2. Copy & paste This is the list of domains that I'm explicitly ignoring in the Firm MRR query: 'aol.com', 'att.net', 'bellsouth.net', 'bills.expensify.com', 'expensify.cash', 'btinternet.com', 'cheerful.com', 'chromeexpensify.com', 'comcast.net', 'cox.net', 'evernote.user', 'expensify.sms', 'gmail.com', 'gmail.con', 'googlemail.com', 'hey.com', 'hotmail.co.uk', 'hotmail.com', 'hotmail.fr', 'hotmail.it', 'icloud.com', 'live.com', 'mac.com', 'mail.ru', 'me.com', 'msn.com', 'outlook.com', 'privaterelay.appleid.com', 'qq.com', 'sasktel.net', 'sbcglobal.net', 'verizon.net', 'yahoo.ca', 'yahoo.co.in', 'yahoo.co.uk', 'yahoo.com.br', 'yahoo.com', 'ymail.com', 'expensifail.com'
  3. Go to a different chat
  4. Go back to the original chat and you can see the message dupe

2022-11-02_11-11-40 (1)

So should this stay on hold for this? https://github.com/Expensify/Expensify/issues/227234

I'm not really sure what to do here...

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2022
@mallenexpensify
Copy link
Contributor

Yeah.. I'd recommend keeping it on hold pending #227234 in E/E. It'll be addressed there. As far as the BZ role here.. I'd stay on top of the tracking issue and, if progress isn't being made, ping the folks assigned there.

@melvin-bot melvin-bot bot added the Overdue label Nov 10, 2022
@Christinadobrzyn
Copy link
Contributor

Still on hold waiting for - https://github.com/Expensify/Expensify/issues/227234

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2022
@Christinadobrzyn
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2022
@Christinadobrzyn
Copy link
Contributor

@Christinadobrzyn Christinadobrzyn added Monthly KSv2 and removed Weekly KSv2 labels Nov 29, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD 227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) [HOLD #227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) Dec 1, 2022
@JmillsExpensify
Copy link

Just came across this one. I'm taking over since I'm on the linked Sequence Numbers doc.

@JmillsExpensify
Copy link

Still on hold for sequence numbers, which is starting to pick up the pace.

@JmillsExpensify JmillsExpensify changed the title [HOLD #227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) [HOLD Expensify #227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) Dec 27, 2022
@JmillsExpensify
Copy link

Same same, though we're making great progress.

@JmillsExpensify
Copy link

JmillsExpensify commented Jan 11, 2023

Still on hold for the sequence numbers.

@melvin-bot
Copy link

melvin-bot bot commented Jan 11, 2023

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@JmillsExpensify
Copy link

Taking this off hold now and attempting to reproduce.

@JmillsExpensify JmillsExpensify changed the title [HOLD Expensify #227234] Duplicate Messages appearing in compose box after message sent (then app closed soon after) Duplicate Messages appearing in compose box after message sent (then app closed soon after) Feb 2, 2023
@JmillsExpensify
Copy link

Unable to reproduce this one now. Closing.

@JmillsExpensify JmillsExpensify added the Needs Reproduction Reproducible steps needed label Feb 2, 2023
@mallenexpensify
Copy link
Contributor

This issue used to happen to me frequently, not able to reproduce on two tries either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

7 participants