Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Not able to zoom pdf @gadhiyamanan #11398

Closed
kavimuru opened this issue Sep 28, 2022 · 49 comments
Closed

[New Feature] Not able to zoom pdf @gadhiyamanan #11398

kavimuru opened this issue Sep 28, 2022 · 49 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@kavimuru
Copy link

kavimuru commented Sep 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat which has pdf attached
  2. Click on pdf and try to zoom pdf

Expected Result:

Should be able to zoom pdf

Actual Result:

Not able to zoom pdf

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.9-0
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen_Recording_20220915_230944_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663263653930829

View all open jobs on GitHub

@kavimuru kavimuru added the Needs Reproduction Reproducible steps needed label Sep 28, 2022
@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 3, 2022
@gadhiyamanan
Copy link
Contributor

gadhiyamanan commented Oct 11, 2022

@kavimuru no one assigned here, I am still able to reproduce it with the latest build

@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @slafortune (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Oct 18, 2022
@CortneyOfstad
Copy link
Contributor

Helping Stevie with this and here is a recording of the issue from my NewDot:

2022-10-19_13-00-38 (1)

@slafortune
Copy link
Contributor

slafortune commented Oct 19, 2022

@kavimuru - I was also able to reproduce this on mobile web

I was not able to reproduce this on mobile app as shown below
Andriod 12
Galaxy Z Flip4

video_fab6003d0aa581a18367c0c9680c0fc64be30550.mp4

Also shown above, command+ does zoom until it hits the page width set.

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2022
@slafortune slafortune added Engineering and removed Needs Reproduction Reproducible steps needed labels Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2022

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@madmax330 madmax330 added Weekly KSv2 and removed Daily KSv2 labels Oct 20, 2022
@madmax330 madmax330 removed their assignment Oct 20, 2022
@madmax330 madmax330 added the External Added to denote the issue can be worked on by a contributor label Oct 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

Triggered auto assignment to @Julesssss (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@vladamx
Copy link
Contributor

vladamx commented Feb 1, 2023

@JmillsExpensify
Copy link

One idea for this issue: I think we should put it on hold until ECX. I think potentially everyone on this issue will be in Curacao?

@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2023
@JmillsExpensify
Copy link

We never got to this issue over Curacao. Thoughts about picking it back up now?

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Mar 30, 2023

@vladamx you wanna work on this together for the pre-design? We can build off of the feedback we got on slack.

We can discuss 1:1 a bit and I can take the lead if you want

@vladamx
Copy link
Contributor

vladamx commented Mar 30, 2023

@rushatgabhane Yeah, lets discuss. I would like to implement this if that's fine. I have some spare time at the moment.

@MelvinBot
Copy link

📣 @vladamx! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@vladamx
Copy link
Contributor

vladamx commented Mar 30, 2023

Contributor details
Your Expensify account email: vladamx.dev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~017751bdb1e653662b

@MelvinBot
Copy link

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@rushatgabhane
Copy link
Member

no updates yet

@JmillsExpensify
Copy link

Still no updates

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 20, 2023

same. not a priority ig

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 21, 2023
@JmillsExpensify
Copy link

Same as above.

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@JmillsExpensify
Copy link

Same

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@JmillsExpensify
Copy link

I'm going to close this issue in order to focus on other priorities. If we ever get back to this, we can reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests