Deploy Checklist: New Expensify 2023-04-25

[OSBotify]

Release Version: 1.3.5-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update version React-Native-Onyx 1.0.39 #16531
• Fix: hover background color is stuck after selection #17328
• Update CONTRIBUTING.md #17459
• Fix: Expensify help website color code and caret icons are not updated #17491
• Fix: Text is partially hidden in split bill feature #17536
• Update regex to split leftword and prefix to highlight #17551
• fix: when deleting a workspace offline, the layout breaks #17639
• Fix zoom and slide on native for PDFView #17647
• fix: airship-related crash on devices running Android 6 or lower #17655
• [Home Address] displays Arabic characters from left to right #17659
• style: move offline indicator closer to form in wider screens #17705
• [NoQA] Fix GH Actions comment when mobile build fails #17706
• Fix: make cursor pointer for whole row #17707
• Allow keyboard shortcuts to work on native devices #17708
• Reintroduce error message in "Connect Bank Account" flow when wrong bank account number is entered #17748
• Fix: update the padding for the offline indicator on mobile #17778
• fix android font line spacing issue on card section #17779
• fix: use month names and daysOfWeek directly in the render method #17780
• Fix: Context menu shows on long press report action on Web, Desktop #17782
• fix cursor styling for NewDatePicker & BaseTextInput #17783
• [No QA] Zhoosh up the playbooks #17814
• [No QA] Add constant for Default Billable Policy Change Log #17815
• Trim leading and trailing space from email/phone input in new contact method page #17817
• fix 17664: use googleEmptyListViewHeight variable with correct value #17832
• fix: trim the description field of IOU request #17852
• Update CONTRIBUTING.md #17879
• [No QA]Commit diff of pod install on main #17893
• Fix screen shaking when editing between 2 tabs #17899
• [NoQA] Add is money request report helper #17913
• [No QA] Add Default reimbursable report action for policy change logs #17941
• Fix issues from unpopulated personal details #17984
• Fix undefined personal details access causing crash when calling getOptions #17988

Deploy Blockers:

• [HOLD for payment 2023-05-04] [HOLD for payment 2023-05-03] App crash in SFO Lounge room #17915
• Login - Infinite spinner appears in login page after tap didn't receive a magic code #17966

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.5-4 🚀

[jasperhuangg]

Checking off #17966 as we're considering it not a blocker, context

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.5-5 🚀

[jasperhuangg]

Checking off #17459 as it's just a README change and #17879 as it's just a markdown change

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.5-5 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.5-6 🚀

[jasperhuangg]

Checking off #17915 per #17915 (comment)

[jasperhuangg]

Checking off #16531 since the only deploy blocker that was created from it was later deemed to not be a blocker (context)

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.5-6 has been deployed to staging 🎉

[mvtglobally]

@jasperhuangg
Regression is almost done

PR #16531 issue found while executing #17967
PR #17491 issue found while executing #17995
PR #17647 issue found while executing #17973
PR #17748 issue found while executing #16669

[jasperhuangg]

Checking off #16531 as I've deemed that the regressions associated with it aren't worth blocking deploy on, and we're going to have the contributor fix them in a follow-up PR.

[jasperhuangg]

Checking off #17491 not a bug just wasn't QA'd correctly

[jasperhuangg]

Checking off #17647 as #17973 is a known issue that is a dupe of #11398

[jasperhuangg]

@mvtglobally are we done with regression tests?

[mvtglobally]

@jasperhuangg we are done.

[jasperhuangg]

@mvtglobally while I have you here, can you clarify what is meant by

PR #17748 issue found while executing #16669

It seems like the issue linked here is the same issue that the PR originally solves. It doesn't indicate what the regression was specifically.

[mvtglobally]

It seems to be still repro https://user-images.githubusercontent.com/43995119/234473085-6fb3fec3-0659-4aa0-a982-2185422dfa3e.MOV

[jasperhuangg]

@mvtglobally Checking off #17748. In that video it doesn't look like the QAer followed the testing steps correctly.

On the second device (mobile device in the recording), you need to also complete step 2. When that happens the routing/account numbers update on the first device. I retested myself and it works as expected.

[jasperhuangg]