[HOLD for payment 2023-05-03] [$1000] Connect Bank Account - Error message is not displayed for entering the wrong bank account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with a applause.expensifail account (that does not have any bank account already added)
2. Enable staging Web secure server in Account Preferences if disabled
   3.Navigate to the add bank account modal (Workspace settings > Add bank account)
3. Select the Connect with plaid method to add a bank account
4. On the bank account list select "Chase"
5. Enter the credentials "user_good / pass_good"
6. If a verification is prompted - select mobile and enter "credentials_good" as the verification mode
7. Checkmark the "Plaid Checking" and "Plaid Saving"
8. Checkmark the 2 options under "additional information you want to share" >tap on continue
   10.Check the T&C and click "Connect account information"
9. Tap on the last confirmation on the plaid modal
10. Verify you're redirected to the choose an account screen in NewDot >Select the bank account ending in 1111
11. Verify you're redirected to the enter back account details manually (this is a special case for the Chase bank account selection)
12. Enter a incorrect bank account number (e.g 1111222233334444)
13. Verify there's an error for entering the wrong bank account and in which number should the bank account end with.

Expected Result:

There's an error for entering the wrong bank account and in which number should the bank account end with.

Actual Result:

Error message is not displayed for entering the wrong bank account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.91.0

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3303676

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5997150_Screen_Recording_20230329_151804_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c74c841b2a1ecd69
• Upwork Job ID: 1646854186665381888
• Last Price Increase: 2023-04-18

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Unable to verify VBA flow in production, feel free put Deploy Blocker if you can test in production.

[MelvinBot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Jumping in to verify this now.

[JmillsExpensify]

I wasn't able to reproduce this one. After this step...

Verify you're redirected to the choose an account screen in NewDot >Select the bank account ending in 1111

I immediately saw this page.

[JmillsExpensify]

Going to add the Needs reproduction label and close until someone else can reproduce.

[kbecciv]

Hello @JmillsExpensify! You need to connect through the Workspace not Payments.
Please review again, because QA team is Failed steps in TR. Thank you

[MelvinBot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Ah ok thanks for the clarification there.

[MelvinBot]

@JmillsExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[JmillsExpensify]

Apologies again for the delay! I just tested this one and yes, I wasn't informed about an incorrect account number. Instead, I was taken directly to the next step to fill out company information.

[JmillsExpensify]

Accordingly, I'm going to release this one to the pool. Pretty sure it should be internal given that it's Plaid, so starting there first.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c74c841b2a1ecd69

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[MelvinBot]

@JmillsExpensify, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

@JmillsExpensify @mananjadhav @amyevans this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[amyevans]

I have a draft PR up, just need to finish testing on all devices.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Reintroduce error message in "Connect Bank Account" flow when wrong bank account number is entered #17748

If no regressions arise, payment will be issued on 2023-05-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

Thanks for the quick work on this one @amyevans! Looks like C+ is due $1000 for reviewing the PR, right? If that's the case, no need to wait and we can get that kicked off now. Then @mananjadhav you want to suggest the regressions test or any changes on that front?

[mananjadhav]

I think we should add the following Regression Test proposal from QA steps of the PR

Regression Test Proposal

1. Log into an account without a Workspace VBA set up (create a new workspace if needed)
2. Go to Workspace settings > Connect bank account
3. Select the Connect online with Plaid method to add a bank account
4. On the bank account list select "Chase"
5. Enter the credentials "user_good / pass_good"
6. If a verification is prompted - select Mobile and enter "credentials_good" as the verification mode
7. Select the "Plaid Checking" and "Plaid Saving" accounts
8. Complete the flow (Check the 2 boxes under "additional information you want to share" > tap on Continue; check the T&C and click "Connect account information"; Tap on the last confirmation on the Plaid modal)
9. Once redirected back to NewDot, select the bank account ending in 1111. You'll be redirected to the enter back account details manually (this is a special case for the Chase bank account selection)
10. Enter routing number 011401533
11. Enter an incorrect bank account number (e.g 1111222233334444)
12. Verify there's an error for entering the wrong bank account number Your account number should end with 1111

do we agree 👍 or 👎 ?

[amyevans]

Looks like C+ is due $1000 for reviewing the PR, right?

Yep!

Regression Test Proposal

This GH came from a failing regression test, so Applause already has it documented in TestRail. I think we can :donothing:.

[mananjadhav]

Thanks for confirming @amyevans.

[JmillsExpensify]

Oh sweet! @mananjadhav I just sent you a contract for this Upwork job: https://www.upwork.com/jobs/~01c74c841b2a1ecd69.

[mananjadhav]

Thanks @JmillsExpensify. Accepted

[JmillsExpensify]

Nice, contract all paid out. I'm closing this one!