[Home Address] displays Arabic characters from left to right #17659
Conversation
left align text input
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
jasperhuangg
and removed request for
a team
|
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Adding myself since I was the engineer assigned in the original issue, not sure it didn't do it automatically. |
src/components/TextInput/index.js
Outdated
| @@ -38,6 +38,7 @@ class TextInput extends React.Component { | |||
| inputStyle={[ | |||
| styles.baseTextInput, | |||
| styles.textInputDesktop, | |||
| styles.textAlignLeft, | |||
There was a problem hiding this comment.
Are we sure we need to be applying these styles for all languages?
There was a problem hiding this comment.
Thanks a lot for the feedbacks, the styling changes to TextInput was to left align texts in Text input fields e.g. those used within AddressSearch component.
However I realised #16986 is about fixing the display of Home address field within Personal details page, so I should not be changing TextInput in the this PR associated with the issue, therefore I added a commit to undo the styling changes in TextInput.
Have done revalidation to ensure fix still works across all platforms.
There was a problem hiding this comment.
@jasperhuangg Currently App only supports LTR mode so this might be valid. But is your question related to the languages we type or the app language (Spanish or English)?
There was a problem hiding this comment.
I believe the current issue #16986 is about getting consistent address displaying pattern in home address page, so changing TextInput might be not in scope.
Moreover, I discovered that adding textAlignLeft will cause regression of #14273 (part of the fix there involves removing textAlignLeft) , so I think we should not includes change to TextInput in this PR.
|
@parasharrajat can you check this PR and add do the checklist? |
|
What about the Address Inputfield? Should this be also LTR? |
Screenshots🔲 iOS / native
🔲 iOS / Safari
🔲 MacOS / Desktop
🔲 MacOS / Chrome
🔲 Android / Chrome
🔲 Android / native
|
I would agree that input field should be LTR if possible. Given that the issue #16986 associated with this PR is about getting consistent address displaying pattern in home address page, I believe TextInput should not really be part of the scope. Therefore, I think we should evaluate Input field as a separate issue discussion, and if fixing is deemed necessary from the discussion outcome, there should be a separate issue fix proposal for it. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
cc: @danieldoglas
🎀 👀 🎀 C+ reviewed
|
@danieldoglas This is ready. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.5-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀
|
Details
Arabic characters in web are being displayed in different format and ordering across different platforms for Personal details page
Home Addressfield which resulted in inconsistency across various support platforms.Since the Expensify App layout does not currently support right to left display, the solution is to align the styling by making texts aligned to left and display characters in left to right direction, where character overflow would results in ellipsis on right side.
Fixed Issues
$ #16986
PROPOSAL: #16986(COMMENT)
Tests
jhgain Address line 1, choose the first result with Arabic texti.e. left to right direction, ellipsis (triple dots ...) is shown on right side of the text when text is too long
Offline tests
N/A
QA Steps
jhgain Address line 1, choose the first result with Arabic texti.e. left to right direction, ellipsis (triple dots ...) is shown on right side of the text when text is too long
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android