Login - Infinite spinner appears in login page after tap didn't receive a magic code

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app in the browser
2. Open another tab in the same browser
3. Log out from one of the tabs
4. Verify that in other tap the app is logged out.
5. Log in with the same user
6. Tap "Didn't receive the magic code"

Expected Result:

Infinite spinner does not appear in login page after tap didn't receive a magic code

Actual Result:

Infinite spinner appears in login page after tap didn't receive a magic code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.5.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2578.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186ac714505a4b6c5
• Upwork Job ID: 1650931778180227072
• Last Price Increase: 2023-04-25

[kbecciv]

Issue is not reproduced in Production, the flow is different

Recording.2579.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1682447137793479
Decision:

I would not block on this and also I think we are already on higher version of react native onyx so reverting would be a pain, I would make it a regression from that pr normal bug and let tienifr handle it, they usually fast

Also because this needs 2 tab to reproduce.

Probably from this PR #16531 cc @tienifr

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0186ac714505a4b6c5

[MelvinBot]

Triggered auto assignment to @slafortune (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Current assignee @iwiznia is eligible for the External assigner, not assigning anyone new.

[roryabraham]

cc @sobitneupane you found the same issue here

[gulfam110]

Add a timeout: When the user taps and doesn't receive a magic code, you can add a timeout that will trigger after a specific amount of time, such as 30 seconds. If the system is still attempting to connect to the server after the timeout, you can display an error message to the user indicating that there is an issue with the login process.

Implement error handling: You can implement error handling to catch any issues that may occur during the login process, such as a network error or a server error. If an error occurs, you can display an error message to the user indicating the issue and suggesting possible solutions.

Improve server response time: If the infinite spinner issue is caused by slow server response time, you can optimize your server to improve the response time. This can involve optimizing your database queries, implementing caching mechanisms, or upgrading your server hardware.

Use a different authentication method: If the magic code authentication method is causing issues, you can try using a different authentication method, such as a username and password or a two-factor authentication method.

Test thoroughly: Once you have implemented code changes to resolve the infinite spinner issue, it is important to thoroughly test the changes to ensure that they have been effective. Test the login process on different devices, browsers, and internet connections to ensure that the issue has been resolved.

[MelvinBot]

📣 @gulfam110! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[gulfam110]

Contributor details
Your Expensify account email: gulfam.luqon@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01721019a355863460

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[iamsuperdev]

I am Tymopify Vasylenko.
Here are many method to fix this problem.

Check your internet connection: Make sure that your device is connected to the internet and that you have a stable connection. If your internet connection is weak or unstable, it may prevent the magic code from being sent to your device.

Clear your browser cache: Clearing your browser cache can sometimes resolve issues with infinite spinners. To do this, go to your browser settings and clear your cache and cookies.

Try a different browser: If clearing your cache doesn't work, try using a different browser to see if the issue persists. Sometimes, browser extensions or settings can interfere with the login process.

Contact customer support: If none of the above solutions work, contact the customer support team for the service you are trying to log in to. They may be able to provide additional assistance or troubleshoot the issue further.

By trying these solutions, you can fix this problem.
Looking forward to your reply.
I am already anytime. Could you have a meeting with me?
please contact me when you are ready.
Thank you for your posting.

[MelvinBot]

📣 @iamsuperdev! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[iamsuperdev]

I am Tymopify Vasylenko.
Here are many method to fix this problem.

Check the validation process: Make sure that the validation process is working correctly and that the user is following the correct steps. If the validation process is not working correctly, the user may not be able to validate their account.

Check the user's email: Make sure that the user is checking the correct email account for the validation email. Sometimes, users may have multiple email accounts and may be checking the wrong one.

Resend the validation email: If the user is not receiving the validation email, try resending it. Make sure that the email address is correct and that the email is not being sent to the user's spam folder.

Contact customer support: If none of the above solutions work, contact the customer support team for the service the user is trying to sign in to. They may be able to provide additional assistance or troubleshoot the issue further.

By trying these solutions, you can fix this problem.
Could you have a meeting with me?
I am already anytime.
please contact me when you are ready.
Looking forward to your reply.

[iamsuperdev]

Excuse me , what chat platform do you use?

…

On Wed, Apr 26, 2023 at 12:56 AM MelvinBot ***@***.***> wrote: 📣 @iamsuperdev <https://github.com/iamsuperdev>! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps: 1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here <https://new.expensify.com/>. If you have multiple accounts (e.g. one for testing), please use your main account email. 2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this <https://www.upwork.com/freelancers/~01ca8ad8ce36b9eceb>. If you don't already have an account, sign up for one here <https://www.upwork.com/nx/signup/?dest=home>. 3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. [image: Screen Shot 2022-11-16 at 4 42 54 PM] <https://user-images.githubusercontent.com/30609178/231263719-a8a3b7d3-36a0-4d7f-8ad4-cebe1f560fa4.png> Format: Contributor details Your Expensify account email: <REPLACE EMAIL HERE> Upwork Profile Link: <REPLACE LINK HERE> — Reply to this email directly, view it on GitHub <#17966 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZMKGWUEI57QDYL7E6RECTDXDBB67ANCNFSM6AAAAAAXLE2NEI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jasperhuangg]

Removing help-wanted label as this is a regression that was caused by #16531. We're going to have the original contributor who opened that PR look into this, closing