fix cursor styling for NewDatePicker & BaseTextInput #17783

daraksha-dk · 2023-04-21T11:44:14Z

Details

#16513 (comment)
#16513 (comment)
#16513 (comment)
#16513 (comment)

We decided to only change the cursor styling to default value for this input

Fixed Issues

$ #16513
PROPOSAL: #16513 (comment)

Tests

Go to www.staging.new.expensify.com
Go to Settings > Profile > Personal details
Go to Date of birth of an account where the DOB has not yet been entered
Hover over the Date field and verify that default cursor is being shown
Click on the Textbox and Date Icon and verify that input doesn't flicker

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to www.staging.new.expensify.com
Go to Settings > Profile > Personal details
Go to Date of birth of an account where the DOB has not yet been entered
Hover over the Date field and verify that default cursor is being shown
Click on the Textbox and Date Icon and verify that input doesn't flicker

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-22.at.2.07.58.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-22.at.1.55.39.AM.mov

Mobile Web - Safari

Screen.Recording.2023-04-22.at.1.47.52.AM.mov

Desktop

Screen.Recording.2023-04-22.at.2.01.36.AM.mov

iOS

Screen.Recording.2023-04-22.at.1.57.33.AM.mov

Android

Screen.Recording.2023-04-22.at.2.02.23.AM.mov

MelvinBot · 2023-04-21T11:44:18Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

MelvinBot · 2023-04-21T12:23:37Z

@mountiny @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Prince-Mendiratta

Overall looks good, love the idea on using the editable prop instead of creating a new prop!

src/components/NewDatePicker/index.js

Prince-Mendiratta · 2023-04-21T13:09:06Z

With this PR, since we are proceeding with the assumption that the NewDatePicker will always be open, we can get rid of the Animated View that is used when the picker is opened manually by user. This is because when the user navigates to the DOB page, the is animation is fast enough such that the picker already shown and the user is not able to actually see the animation.

Thoughts @daraksha-dk @Santhosh-Sellavel @mountiny?

The changes would involve:

Getting rid of the showPicker method.
Getting rid of the opacity.
Getting rid of the componentDidMount method.
Getting rid of the autoFocus prop from DateOfBirthPage.
Converting Animated.View to View.
Removing the Animated import from RN.

daraksha-dk · 2023-04-21T15:04:15Z

I don't have a strong opinion on that, but it may not be relevant to this PR.

Santhosh-Sellavel · 2023-04-21T19:07:48Z

With this PR, since we are proceeding with the assumption that the NewDatePicker will always be open, we can get rid of the Animated View that is used when the picker is opened manually by user. This is because when the user navigates to the DOB page, the is animation is fast enough such that the picker already shown and the user is not able to actually see the animation.

Thoughts @daraksha-dk @Santhosh-Sellavel @mountiny?

The changes would involve:

Getting rid of the showPicker method.

Getting rid of the opacity.

Getting rid of the componentDidMount method.

Getting rid of the autoFocus prop from DateOfBirthPage.

Converting Animated.View to View.

Removing the Animated import from RN.

@daraksha-dk This is part of @Prince-Mendiratta's proposal refactor which we agreed on, so can you make the changes?

daraksha-dk · 2023-04-21T19:37:43Z

@Santhosh-Sellavel sure, I can do that. But I'd like to clarify that these changes were not a part of @Prince-Mendiratta's proposal.

@Prince-Mendiratta can confirm.

Prince-Mendiratta · 2023-04-21T19:40:31Z

Yup, these were not a part of the original proposal, those were already implemeted by @daraksha-dk. These are some additional things I think we can remove, that's why I asked for a reconsidered opinion.

…

On Sat, Apr 22, 2023 at 1:07 AM Daraksha ***@***.***> wrote: @Santhosh-Sellavel <https://github.com/Santhosh-Sellavel> sure, I can do that. But I'd like to clarify that these changes <#17783 (comment)> were not a part of @Prince-Mendiratta <https://github.com/Prince-Mendiratta>'s proposal <#16513 (comment)>. @Prince-Mendiratta <https://github.com/Prince-Mendiratta> can confirm. — Reply to this email directly, view it on GitHub <#17783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM4SPLFNRCUPWFEDP5J3GULXCLOZFANCNFSM6AAAAAAXGYNBYU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Santhosh-Sellavel · 2023-04-21T19:49:06Z

Oops I misread it then, I think this should be removed as well there is no point in keeping them.

daraksha-dk · 2023-04-21T19:52:03Z

Got it, thanks! Updating the PR now.

Prince-Mendiratta

LGTM, tests well too!

…-new-date-picker

Santhosh-Sellavel · 2023-04-21T20:31:37Z

@Prince-Mendiratta Can you complete the reviewer checklist too as you are testing this one thanks!

Prince-Mendiratta · 2023-04-21T20:32:34Z

Sure, will do.

…

On Sat, 22 Apr, 2023, 2:01 am Santhoshkumar Sellavel, < ***@***.***> wrote: @Prince-Mendiratta <https://github.com/Prince-Mendiratta> Can you complete the reviewer checklist too as you are testing this one thanks! — Reply to this email directly, view it on GitHub <#17783 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM4SPLFUMAH6VSSTO4AIYZ3XCLVDJANCNFSM6AAAAAAXGYNBYU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

daraksha-dk · 2023-04-21T20:40:17Z

Updated all the videos in the OP after the latest changes!

Prince-Mendiratta · 2023-04-21T20:52:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-mWeb.mp4

Mobile Web - Safari

iOS-mWeb.mp4

Desktop

desktop.mp4

iOS

iOS.mp4

Android

android.mp4

Prince-Mendiratta · 2023-04-21T20:54:01Z

@daraksha-dk can you please add the test in the OP to click on the Icon & Textbox and ensure that it does flicker? Thanks.

daraksha-dk · 2023-04-21T21:02:31Z

@Prince-Mendiratta OP updated!

Prince-Mendiratta · 2023-04-21T21:46:27Z

src/components/NewDatePicker/index.js

                        label={this.props.label}
                        value={this.props.value || ''}
                        defaultValue={this.defaultValue}
                        placeholder={this.props.placeholder || this.props.translate('common.dateFormat')}
                        errorText={this.props.errorText}
                        containerStyles={this.props.containerStyles}
-                        textInputContainerStyles={this.state.isPickerVisible ? [styles.borderColorFocus] : []}
+                        textInputContainerStyles={[styles.borderColorFocus]}
+                        inputStyle={[styles.pointerEventsNone]}


@daraksha-dk Adding this makes the label "Date" selectable when double clicking just above the input date, which is not happening on staging. I don't think we'd like to see that, double clicking anywhere should only select the text and not the label.

2023-04-22.03-15-21.mp4

Not a problem

Prince-Mendiratta · 2023-04-21T21:47:59Z

Also, double clicking on the icon selects the Month text but that is reproducible on staging as well. Should we do anything for this or let it remain @Santhosh-Sellavel @mountiny?

Santhosh-Sellavel · 2023-04-21T21:50:45Z

Not a problem here.

Prince-Mendiratta

LGTM! All yours @Santhosh-Sellavel @mountiny !

Got the be a C+ for the day experience today haha

mountiny

I love this refactoring and the collaboration here, really great job @Prince-Mendiratta and @Santhosh-Sellavel helping @Prince-Mendiratta to do his C+ trial :D

I hope to see you applying at some point!

OSBotify · 2023-04-21T22:39:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Prince-Mendiratta · 2023-04-22T22:29:07Z

Thank you @mountiny @Santhosh-Sellavel, loved the trail! I do plan on applying for the C+ program once I'm done with my semester exams soon and eventually for the job as well so we can actually meet up in SA! :D

OSBotify · 2023-04-25T06:09:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-26T05:51:32Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

daraksha-dk added 2 commits April 21, 2023 17:09

fix datepicker style and remove isPickerVisible

39b0cc4

define and use isEditable

8ce61ae

daraksha-dk marked this pull request as ready for review April 21, 2023 12:23

daraksha-dk requested a review from a team as a code owner April 21, 2023 12:23

melvin-bot bot requested review from mountiny and Santhosh-Sellavel and removed request for a team April 21, 2023 12:23

daraksha-dk mentioned this pull request Apr 21, 2023

[HOLD for payment 2023-05-03] [$1000] The cursor is not displayed as a pointer/hand on the pressable date of birth field #16513

Closed

6 tasks

Prince-Mendiratta reviewed Apr 21, 2023

View reviewed changes

src/components/NewDatePicker/index.js Show resolved Hide resolved

src/components/NewDatePicker/index.js Outdated Show resolved Hide resolved

cleanup

aaac819

Refactor: remove autofocus & animated usage in NewDatePicker

61b6a24

Prince-Mendiratta approved these changes Apr 21, 2023

View reviewed changes

Merge branch 'Expensify:main' into daraksha-dk-fix-cursor-styling-for…

02530b3

…-new-date-picker

Prince-Mendiratta reviewed Apr 21, 2023

View reviewed changes

Prince-Mendiratta approved these changes Apr 21, 2023

View reviewed changes

mountiny assigned daraksha-dk Apr 21, 2023

mountiny approved these changes Apr 21, 2023

View reviewed changes

mountiny merged commit 41e8810 into Expensify:main Apr 21, 2023

OSBotify mentioned this pull request Apr 25, 2023

Deploy Checklist: New Expensify 2023-04-25 #17948

Closed

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix cursor styling for NewDatePicker & BaseTextInput #17783

fix cursor styling for NewDatePicker & BaseTextInput #17783

daraksha-dk commented Apr 21, 2023 •

edited

Loading

MelvinBot commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

Prince-Mendiratta left a comment

Prince-Mendiratta commented Apr 21, 2023

daraksha-dk commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta commented Apr 21, 2023 via email

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta left a comment

Santhosh-Sellavel commented Apr 21, 2023

Prince-Mendiratta commented Apr 21, 2023 via email

daraksha-dk commented Apr 21, 2023 •

edited

Loading

Prince-Mendiratta commented Apr 21, 2023 •

edited

Loading

Prince-Mendiratta commented Apr 21, 2023

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta Apr 21, 2023

Santhosh-Sellavel Apr 21, 2023

Prince-Mendiratta commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023

Prince-Mendiratta left a comment

mountiny left a comment

OSBotify commented Apr 21, 2023

Prince-Mendiratta commented Apr 22, 2023

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

fix cursor styling for NewDatePicker & BaseTextInput #17783

fix cursor styling for NewDatePicker & BaseTextInput #17783

Conversation

daraksha-dk commented Apr 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 21, 2023

MelvinBot commented Apr 21, 2023

Prince-Mendiratta left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Apr 21, 2023

daraksha-dk commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023 • edited Loading

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta commented Apr 21, 2023 via email

Santhosh-Sellavel commented Apr 21, 2023 • edited Loading

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Apr 21, 2023

Prince-Mendiratta commented Apr 21, 2023 via email

daraksha-dk commented Apr 21, 2023 • edited Loading

Prince-Mendiratta commented Apr 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Prince-Mendiratta commented Apr 21, 2023

daraksha-dk commented Apr 21, 2023

Prince-Mendiratta Apr 21, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Apr 21, 2023

Choose a reason for hiding this comment

Prince-Mendiratta commented Apr 21, 2023

Santhosh-Sellavel commented Apr 21, 2023

Prince-Mendiratta left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 21, 2023

Prince-Mendiratta commented Apr 22, 2023

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

daraksha-dk commented Apr 21, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 21, 2023 •

edited

Loading

daraksha-dk commented Apr 21, 2023 •

edited

Loading

Prince-Mendiratta commented Apr 21, 2023 •

edited

Loading