[$500] BUG: Mac/Firefox - Opening the protect PDF modal and pressing TAB doesn’t focus on enter the password reported by @dhairyasenjaliya

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any conversation
2. Send Protected PDF (if required)
3. Open Protected PDF
4. Press TAB key simultaneously try to navigate to enter the password with TAB
5. Notice it will focus only on Close Modal /Download PDF

Expected Result:

On pressing TAB it should be able to focus on enter the password

Actual Result:

On pressing TAB it does not focus on enter the password

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web - Mac Firefox only

Version Number: 1.2.18-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-20.at.9.00.17.AM.mov

Recording.36.mp4

PDF used :
password-protected.pdf

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666236736080999

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mallenexpensify]

@zanyrenney new BZ chore SO is here, we want to ensure BZ stays assigned to all issues so we can get to BugZero,

[melvin-bot]

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[zanyrenney]

Hey @kavimuru - Are you created the password protected PDF in Adobe? That's the only way I see how to recreate this. If you can attach an example of the PDF to this GH issue, i can test this properly.

[kavimuru]

@zanyrenney Added the pdf used for this test in the GH.

[zanyrenney]

I need the password to be able to test too though, please? @kavimuru

[kavimuru]

@zanyrenney Password is 1234 and attached another PDF

[zanyrenney]

Thanks!

[zanyrenney]

I can't reproduce this on Mac/Chrome - is it only happening on FireFox @kavimuru ?

[dhairyasenjaliya]

@zanyrenney this bug is only related to firefox

[zanyrenney]

Thanks. Asking in slack if we should be testing and fixing these super edge cases: https://expensify.slack.com/archives/C01SKUP7QR0/p1666963361304399

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @roryabraham (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

No proposals yet.

[s77rt]

I meant something like this

diff --git a/src/components/PDFView/PDFInfoMessage.js b/src/components/PDFView/PDFInfoMessage.js
index 5d583db40..898983f13 100644
--- a/src/components/PDFView/PDFInfoMessage.js
+++ b/src/components/PDFView/PDFInfoMessage.js
@@ -1,6 +1,6 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import {View} from 'react-native';
+import {View, Pressable} from 'react-native';
 import Text from '../Text';
 import TextLink from '../TextLink';
 import Icon from '../Icon';
@@ -29,9 +29,11 @@ const PDFInfoMessage = props => (
         <Text>{props.translate('attachmentView.pdfPasswordForm.infoText')}</Text>
         <Text>
             {props.translate('attachmentView.pdfPasswordForm.beforeLinkText')}
-            <TextLink onPress={props.onShowForm}>
-                {` ${props.translate('attachmentView.pdfPasswordForm.linkText')} `}
-            </TextLink>
+            <Pressable onPress={props.onShowForm}>
+                <Text style={[styles.link]}>
+                    {` ${props.translate('attachmentView.pdfPasswordForm.linkText')} `}
+                </Text>
+            </Pressable>
             {props.translate('attachmentView.pdfPasswordForm.afterLinkText')}
         </Text>
     </View>

[huzaifa-99]

@s77rt something similar already proposed here but this would not work as suggested by @parasharrajat here

[zanyrenney]

Hi everyone - this issue is a duplicate of #12010, please can you post your proposals on the original issue to avoid duplication and track this correctly. @huzaifa-99 @s77rt cc. @parasharrajat @roryabraham

[zanyrenney]

Closing this issue in favour of #12010

[huzaifa-99]

@zanyrenney #12010 is related to the focus issues on Download/Close buttons on Mac/Safari only. This issue is related to focus issues on a label "Enter the password" in Mac/FireFox only.

Should we still consider these as one?

[dhairyasenjaliya]

hello @zanyrenney both issues are separate

#12058 this issue is about "enter the password" not focusing on the tab

#12010 this issue is about protect the PDF modal and pressing TAB doesn’t focus on download/close

• as this is not a duplicate issue so I do think this would be eligible for bug reporting

[s77rt]

@zanyrenney @huzaifa-99 @dhairyasenjaliya
not the same issue.
but #12010 covers both #12058 and #12554

[huzaifa-99]

Bump @zanyrenney

[zanyrenney]

Sorry @huzaifa-99 but from this comment it looks like it is correct this is closed in favour of that issue that covers this off? #12058 (comment) @roryabraham please also let me know your thoughts here.

[dhairyasenjaliya]

@zanyrenney also bug reporting bonus remaining since it was valid at reporting time then later on it was decided not to focus on keyboard navigation issues

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[huzaifa-99]

@zanyrenney related to the comment you mentioned, I am not sure if the other issue covers this one, please see this comment on the other issue. Maybe @s77rt can share more context.

At this time, I am not sure if my proposal is valid as from discussion here. The discussion does point to solve issues with accepted proposals before that thread was created (16 Nov), mine was accepted on 11 Nov.

Please feel free to close if otherwise. Thanks

[s77rt]

The solution to this issue #12010
is the solution of #12058 and #12554

I don't know how to handle such case but it's logical to close the new issues in favour of the old one but this didn't happen.
If it was about implementing a solution, I'd say @huzaifa-99 should be credited for solving a part of the issue (original issue), but I don't know how the reporting bonus work in such case so I can't help in that.

[JmillsExpensify]

@roryabraham @parasharrajat Is this issue still aimed at solving focus for TAB navigation? If so, I think we should close it. We've announced that these are new accessibility features and not bugs.

[roryabraham]

I agree, we should close this.

also bug reporting bonus remaining since it was valid at reporting time then later on it was decided not to focus on keyboard navigation issues

Not sure if this is correct or not, but I think we need to sort this out when we close it. Normally reporting bonus is only paid for bugs and new features that are fixed/implemented.

[dhairyasenjaliya]

Alright, got it, thank you @JmillsExpensify @roryabraham I think we are good to close then since this issue is about TAB navigation

[parasharrajat]

#12058 (comment)

No payment is due here.

[zanyrenney]

Taken to slack for discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1669809248604369

[zanyrenney]

hi @huzaifa-99 we decided that the proposal itself, which we approved is the only segment for payment, please can you apply for the job on upwork so we can pay you: https://www.upwork.com/jobs/~010f0af8b1df252e1d

[huzaifa-99]

@zanyrenney applied thanks.

we decided that the proposal itself, which we approved is the only segment for payment

Just to be sure, I should raise a PR, right?

[zanyrenney]

Hey @huzaifa-99 - no, you don't need to submit a PR. The reason you are due the payment is that you worked on the proposal already by the time we asked you not to do it, so, we're paying you for the proposal given the work was complete even though we aren't using it, for fairness and appreciation of your time. I hope that makes sense? Let me know if you have any questions.

[zanyrenney]

offer sent @huzaifa-99

[huzaifa-99]

Hey @huzaifa-99 - no, you don't need to submit a PR. The reason you are due the payment is that you worked on the proposal already by the time we asked you not to do it, so, we're paying you for the proposal given the work was complete even though we aren't using it, for fairness and appreciation of your time. I hope that makes sense? Let me know if you have any questions.

@zanyrenney thanks for the consideration and followup :)

[zanyrenney]

Paid via upwork, closing this out. @huzaifa-99 Reopen if you have any problems or follow up questions.