[PAID][Regression in PR][$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings
2. Go to Profile
3. Delete profile pic if already exist
4. Click on avatar
5. Click on Upload photo
6. Choose a high resolution photo
7. Click Save
8. Go to any workspace
9. Click Manage members
10. Remove other members if exist by selecting all and then clicking on remove button
11. Click on Select all checkbox

Expected Result:

Not able to check Select all checkbox when there is only me on the list

Actual Result:

Able to check Select all checkbox when there is only me on the list

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.18-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-21.at.9.46.11.PM.mov

Recording.760.mp4

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666371501103159

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[mallenexpensify]

@adeel0202 @kavimuru , you shouldn't be able to remove the admin of a workspace, right? So that box wouldn't/shouldn't be checked since it's not actionable... right?

2022-10-21_16-32-48.mp4

[kavimuru]

@mallenexpensify Yes, shouldn't be able to select the admin to delete. But it allows to remove and then error message appears. This is only reproducible by following the same steps in the actions performed. Please change the profile image of size 3mb.

[mallenexpensify]

Unable to reproduce on staging/Chrome with my test account. used a 4mb and 5mb test image. Works as expected.

2022-10-24_07-48-50.mp4

Tried other setups too - added two people then tried to select all, still no luck.

Anything else I might be missing? @kavimuru @adeel0202 are you both still able to repro?

[kavimuru]

@mallenexpensify I'm still able to reproduce. My profile image size is 3.8mb. Also you should remove the member right after adding profile picture.

Recording.778.mp4

[adeel0202]

I'm also still able to reproduce.

Also you should remove the member right after adding profile picture.

yup, you have to perform all the steps in a go and as quickly as possible.
upload a high res photo > go to any workspace > manage members page > select all > remove all selected members > select all

[mallenexpensify]

Still not able to, tried multiple test accounts too, on staging and production, in chrome and firefox.
Gonna dish to Engineering to see if they can, since both of you have been able to

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

@srikarparsi , can you see if you're able to reproduce this bug, please?

[srikarparsi]

checking now, sorry was caught up with some other issues

[srikarparsi]

hey, I'm also not able to reproduce. This was on staging and nothing of relevance came up in the console either. Anything else I could try to reproduce @kavimuru @adeel0202 ?

Screen.Recording.2022-10-27.at.9.10.26.PM.mov

[adeel0202]

@srikarparsi can you please try with a slower internet connection? I'm not sure but maybe you and @mallenexpensify are not able to reproduce because probably you guys have relatively faster internet connections.

Also, can you guys please try to reproduce this one as well?

[srikarparsi]

good idea @adeel0202, just tried it with slow connection and I'm able to reproduce the issue.

Screen.Recording.2022-10-28.at.4.45.53.PM.mov

Will try reproducing the other one now.

[srikarparsi]

I'm able to reproduce the second issue as well (manage members screen displaying an error after uploading high res profile picture with slow internet connection). I agree that the two issues are probably related. I'm a little busy with some other issues so will mark it external to get it looked at quicker.

Screen.Recording.2022-10-28.at.4.57.23.PM.mov

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mallenexpensify]

Reassigning as I'm heading OOO for a month

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• @laurenreidexpensify A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
• @sobitneupane @srikarparsi The PR that introduced the bug has been identified. Link to the PR:
• @laurenreidexpensify The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• @laurenreidexpensify A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• @laurenreidexpensify Payment has been made to the issue reporter (if applicable)
• @laurenreidexpensify Payment has been made to the contributor that fixed the issue (if applicable)
• @laurenreidexpensify Payment has been made to the contributor+ that helped on the issue (if applicable)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.27-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/12066: Able to check Select all checkbox of the manage members page when there is only owner #12545

If no regressions arise, payment will be issued on 2022-11-22. 🎊

[laurenreidexpensify]

Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi @sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi @sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi @sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
• [@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.

[parasharrajat]

There is a regression from this issue's PR #12770 .

[laurenreidexpensify]

@sobitneupane @srikarparsi can you confirm the status of the regression hold on this? Thanks

[sobitneupane]

@laurenreidexpensify

PR was deployed to production 3 days back.
Issue for regression: #12770

[laurenreidexpensify]

Looks like we're at 7 days on the regression being on prod with no further regression reported. Going to proceed to payment here now.

[laurenreidexpensify]

All payments have been issued in Upwork.

@srikarparsi @sobitneupane can you please add any relevant links here

[laurenreidexpensify]

Confirming Regression testing here

[srikarparsi]

hey @sobitneupane, do you have the bandwidth to work on the first three steps: #12066 (comment)

[sobitneupane]

Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi @sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
  Probably Migrate policy API to remove policy members #10452 as it was the PR which introduces pendingAction in removeMembers
• [@srikarparsi @sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  Not commented. Because I don't think this bug could have been caught in the PR.
• [@srikarparsi @sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  https://expensify.slack.com/archives/C049HHMV9SM/p1670562172269399
  This type of bug is very difficult to catch. Because it involves two different flows: one uploading high resolution image and other deleting members from workspace.