Deploy Checklist: New Expensify 2022-10-31

[OSBotify]

Release Version: 1.2.22-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Use native KeyboardAvoidingView component everywhere #11586
• Repair clicking on zoom photo line should zoom the photo #11717
• Improve default workspace naming #11875
• perf: memo SidebarLinks #11907
• Fix: Janky popover animation #12065
• Create HOC for get report data or navigate to home #12089
• fix: changes made in offline mode are not saved #12125
• fix: old message not loading when online again #12126
• add links and button for The Free Plan article #12137
• Add offline feedback for pending chats #12150
• removing the SmartScan article #12159
• Speed up webpack build and rebuild times #12160
• Default the report old policy name to an empty string if the property doesn't exist #12195
• Add space after emoji #12200
• Update react-native to @expensify/react-native@0.70.4-alpha.1 #12209
• [No QA] Automatically open site when running jekyll serve #12254
• Clean Up Comments in PaymentMethods.js #12297
• [CP Staging] Revert PR 11907 which introduced missing FAB bug #12336
• [NO-QA] Update hermes-pods manually to resolve iOS build issue #12342

Deploy Blockers:

• Android - LHN - Fab menu is missing after log in #12312

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.22-1 🚀

[mvtglobally]

We are still missing IOS build.

[Julesssss]

We are still missing IOS build.

I'm looking into this after reverting the issue that introduced a regression 👍

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.22-2 🚀

[Julesssss]

Checking off #12312, as the tests in #12336 will confirm the regression is resolved

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.22-2 has been deployed to staging 🎉

[mountiny]

⏫ @Expensify/applauseleads can you please retest this one deploy blocker? #12312 Thanks

[Julesssss]

Hey @Expensify/applauseleads, I just cherry-picked a fix for the failed iOS build and it should appear soon 🤞

[mvtglobally]

Great @Julesssss we will resume as soon as build is out

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.22-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.22-3 has been deployed to staging 🎉

[luacmartins]

@mvtglobally what is the status on the regression tests?

[mvtglobally]

@luacmartins almost done. We are wrapping last iOS slots. I will update checklist in a bit

[mvtglobally]

@luacmartins Regression is completed

PRs #11586, #11875, #11907 are blocked on Android due to #12312. We are retesting
PR #12150 is failing due to #12335. Repro in prod, checking off
PR #12195 is failing #12328. Repro in prod. Checking off

[Julesssss]

Hey @Expensify/applauseleads

• I believe #11586, #11875, #11907 should be possible to test now, given that the Android fab regression was resolved by PR [CP Staging] Revert PR 11907 which introduced missing FAB bug #12336
• It also looks like #12125 wasn't tested, is there a reason or can these be retested now?

[Julesssss]

I checked off #11907 as the PR was reverted

[Julesssss]

Checking off #12137 as it is not testable in staging

(test only in production).

[mvtglobally]

@Julesssss @luacmartins Checking off #11586, #11875, #11907, #12336 as retest pass
PR #12125 is fail on IOS #12355. Repro in prod checking off
We are all set

[Julesssss]

Amazing, thank you!

[Julesssss]

Timing dash has no new changes, we're still seeing higher times due to a new measurement method.

[Julesssss]

I cleared out some outdated issues in Firebase. The single new issue on Firebase is a one off as far as I can tell. I am unable to reproduce it based on the stack trace. We can investigate further if/when it occurs again

[Julesssss]

[Julesssss]

Hey @Expensify/applauseleads. FYI we had an issue generating the new checklist.

[mvtglobally]

@Julesssss i was just about to ping on the same. Any idea if the fix is coming soon?

[Julesssss]

That seems very unlikely at this point. I'll share an update tomorrow as it's near the end of my day.

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[Julesssss]

Oh, I triggered this accidently, please ignore!

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[roryabraham]