Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web -Chat - The welcome message and error message are not scaled correctly #12335

Closed
kbecciv opened this issue Nov 1, 2022 · 11 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12150

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login with any account
  2. Go offline
  3. Click the green plus at the bottom->New chat
  4. Enter 55555 as a phone number and select it in the results
  5. Go back online
  6. Click the search icon in the header
  7. Enter 55555 and open this chat

Expected Result:

The welcome message and the error message should be spread over the entire width of the chat page

Actual Result:

The welcome message and error message are not scaled correctly

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.22.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
12150 Web

Bug5800755_Recording__2707.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 1, 2022

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mallenexpensify
Copy link
Contributor

@kbecciv I tested and it looks correct on my end in Firefox
image

image

Which browser did you use?

@kbecciv
Copy link
Author

kbecciv commented Nov 1, 2022

We tested on Chrome browser

@mallenexpensify
Copy link
Contributor

I think I'm still unable to reproduce in Chrome, the error message looks to be aligned properly
image

@mallenexpensify
Copy link
Contributor

The welcome message and error message are not scaled correctly

@kbecciv can you provide more detail on "scaled correctly"? Are you expecting for the below blurb to be centered both horizontally and vertically in the main chat window?
image

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 4, 2022

@mallenexpensify We are expecting to see the error message in one line in the main chat window. But if its expected behavior, please let us know.

@mallenexpensify
Copy link
Contributor

expecting to see the error message in one line in the main chat window.

@kbecciv I'm still unsure of what that's supposed to look like, do you have a screenshot example?

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2022
@mallenexpensify
Copy link
Contributor

@kbecciv when you get a min, can you address the above? (commenting cuz it's Daily)

@melvin-bot melvin-bot bot removed the Overdue label Nov 7, 2022
@kbecciv
Copy link
Author

kbecciv commented Nov 7, 2022

@mallenexpensify This is just an idea how it can look. If you think this this is expected layout, please let me know.

2

@thesahindia
Copy link
Member

I believe this is expected. Let's close this.

@mallenexpensify
Copy link
Contributor

Thanks @thesahindia ! I agree that I think it's expected.
Thanks @kbecciv for the feedback. If you see any inconsistencies where the positional/location of the message isn't consistent with the above, please comment/reopen this issue or create a new GH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants