[HOLD for payment 2022-11-16] [$250] Workspace settings - The "Save" button is unavailable offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log in with any account
3. Go to Settings->Workspaces
4. Click on any workspace->Workspace settings
5. Kill the internet connection

Expected Result:

The "Save" button should be available

Actual Result:

"Save" button is unavailable

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.23.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5805035_Recording__2738.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Puneet-here]

Proposal

We need to pass enabledWhenOffline at Form to keep it enabled

App/src/pages/workspace/WorkspaceSettingsPage.js

Line 82 in 1dd7174

<Form

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Confirmed in open-source that we should support saving when offline. Marking external

[melvin-bot]

Current assignee @mateocole is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @Beamanator (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neil-marcellini]

I'm guessing this regression happened here when we refactored this page to use a form? #11615

[thesahindia]

Yup I think so. We already have a proposal which will fix this. What's the next step here?

[Beamanator]

It looks like this issue was created after the 7 day regression period, so I believe we should review proposals in this issue, no need to have the author of the regression fix the issue.

However, I think we need an RCA since the regression made it all the way to production?

[mateocole]

Job posting on upwork!
https://www.upwork.com/ab/applicants/1589654996264235008/job-details

[thesahindia]

@Puneet-here's proposal looks good to me

C+ reviewed 🎀👀🎀

cc: @Beamanator

[thesahindia]

However, I think we need an RCA since the regression made it all the way to production?

cc: @rushatgabhane (since you reviewed #11615)

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Beamanator]

Maybe this just needs to be added to TestRail, not sure if this is technically a "regression"

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Payment has been made to the issue reporter (if applicable)
• Payment has been made to the contributor that fixed the issue (if applicable)
• Payment has been made to the contributor+ that helped on the issue (if applicable)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Enable button even when offline #12550

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mateocole]

@Beamanator is this eligible for payment now?

[Beamanator]

Yessir @mateocole !

[Puneet-here]

Job posting on upwork! https://www.upwork.com/ab/applicants/1589654996264235008/job-details

@mateocole, the link is for the job details.

[mateocole]

Following payment steps here

Hey @Puneet-here can you apply directly to the upwork posting so I can document and hire from there

[thesahindia]

I have applied as well, thanks!

@Puneet-here, this is the correct link https://www.upwork.com/jobs/~01961de86d5adc919f (you can always search the upwork posting through the issue number)

[Puneet-here]

@Puneet-here, this is the correct link https://www.upwork.com/jobs/~01961de86d5adc919f

Thanks.

@mateocole, I have applied to the job.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@Beamanator, @mateocole, @thesahindia, @Puneet-here Huh... This is 4 days overdue. Who can take care of this?

[Beamanator]

Bump @mateocole - has everyone been paid? If so, let's close this out!

[Beamanator]

Another bump @mateocole :D

[mateocole]

Okay offers have been sent over, once accepted will pay out!

[thesahindia]

Accepted, thanks!

[Puneet-here]

Accepted the offer @mateocole
Note: This is eligible for 50% bonus because the PR was merged within 3 days

[mateocole]

Okay both payments are complete!

[thesahindia]

@mateocole, the 50% bonus is also applicable for C+ reviewer

[thesahindia]

bump @mateocole ^