[HOLD for payment 2022-11-16] [$250] Chat - App is crashed after click on expensifail account which is closed

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition:
Create a group conversation with account A and B ( should be expensifail account)
Close the expensifail account under domain account

1. Go to staging.new.expensify.com
2. Log in with account A
3. Select the created conversation between account A and B from LHN
4. Click on user's B avatar

Expected Result:

Details for account B should be displayed.

Actual Result:

App is crashed after click on expensifail account which is closed

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.24.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): 508-221-1196/applausetester+0709abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1619.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not reproducible in production

[marcaaron]

Go to staging.new.expensify.com
Log in with account A
Select the created conversation between account A and B from LHN
Click on account B

Not able to reproduce this. Please list the exact testing steps that were performed in order to trigger the bug.

[kbecciv]

1. Go to staging.new.expensify.com
2. Log in with account A (50821-11-96/Feya86Katya
3. Select the chat conversation with applausetester+0709abb@applause.expensifail.com
4. Click on applausetester+0709abb@applause.expensifail.com avatar

[0xmiros]

Proposal

App/src/pages/DetailsPage.js

Line 89 in 0724337

displayName: ReportUtils.getDisplayNameForParticipant({login}),

Root cause:
This line was added here - #12364
and regressed by #12399

Solution:

-               displayName: ReportUtils.getDisplayNameForParticipant({login}),
+               displayName: ReportUtils.getDisplayNameForParticipant(login),

[0xmiros]

@marcaaron this is clearly reproducible step:
https://staging.new.expensify.com/details?login=anonymous

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tgolen]

Ah yes, it looks like when I changed the signature of getDisplayNameForParticipant() that I missed a spot. The proposal from @0xmiroslav looks like a good fix for it.

[marcaaron]

@tgolen to clarify, are you saying that @0xmiroslav should be hired to fix it or that you are going to raise a PR with that solution?

[0xmiros]

This is a deploy blocker. Since it's urgent, I can raise PR as soon as got assigned 🚀

[tgolen]

If @0xmiroslav can do it now, then I'll let him do it. I'm in the middle of a few other things. I'll go ahead and assign

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[yuwenmemon]

Sounds good - removing the Deploy Blocker Label then

[joekaufmanexpensify]

Removing the hourly label as well given the PR is merged.

[joekaufmanexpensify]

PR still on staging. 7 day payment pending period will begin as soon as it's on prod.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash on profile detail #12533

If no regressions arise, payment will be issued on 2022-11-16. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[joekaufmanexpensify]

This just hit 7 days with no reported regressions. Going to work on bug zero checklist now!

[joekaufmanexpensify]

Discussing two new regression tests I think we should add here.

[joekaufmanexpensify]

Regression test sent to applause to be added! Linked in BZ checklist above.

[joekaufmanexpensify]

Okay, I updated the bug zero checklist above to reflect who is responsible for which tasks (as the checklist itself was just updated, before after it was posted to this issue).

@marcaaron / @parasharrajat let me know if I can help with commenting on the offending PR and beginning the discussion in Slack.

In the interim, I am going to pay everyone.

[joekaufmanexpensify]

@parasharrajat Mind accepting the offer for this one so we can pay you?

[marcaaron]

@joekaufmanexpensify it is done!

[marcaaron]

• (@marcaaron / @parasharrajat) The PR that introduced the bug has been identified. Link to the PR: Improve the performance of report name generation #12399
• (@marcaaron / @parasharrajat) The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Improve the performance of report name generation #12399 (comment)
• (@marcaaron / @parasharrajat) A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C02NK2DQWUX/p1668722375490279

[parasharrajat]

@joekaufmanexpensify Done.

[joekaufmanexpensify]

Great ty! Since this PR was merge the same day the contributor was assigned to the issue, both @parasharrajat and @0xmiroslav get a 50% bonus.

Going to issue payment of $375 to both of you now!

[joekaufmanexpensify]

@parasharrajat $375 sent!

[joekaufmanexpensify]

@0xmiroslav $375 sent!

[joekaufmanexpensify]

Applause found this, so no reporting payment to make.

[joekaufmanexpensify]

Job closed.

[joekaufmanexpensify]

This is all set. Confirming whether the issue needs to remain open until applause adds regression test.

[joekaufmanexpensify]

Okay, confirmed we don't need to wait for applause to actually add the regression test. Opening the issue for them is sufficient.

Closing as this is all set. Thanks everyone!