Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$1000] IOU-Offline shows the name of the currency, after going online it shows the symbol of currency #12573

Closed
kavimuru opened this issue Nov 8, 2022 · 36 comments
Closed

[$1000] IOU-Offline shows the name of the currency, after going online it shows the symbol of currency #12573

kavimuru opened this issue Nov 8, 2022 · 36 comments
Assignees
@jasperhuangg @aldo-expensify
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Nov 8, 2022 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Create a money request from User A to user B
  3. Go offline
  4. Create another money request
  5. As user A, go to the IOU details and cancel this IOU request
  6. Make sure the request has been cancelled and the IOU preview has been updated (the message should be greyed out)
  7. Back online

Expected Result:

In offline, the currency sign should be displayed immediately

Actual Result:

Offline shows the name of the currency, after going online it shows the sign of the currency

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.25-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5812702_11720_Web_1

Bug5812441_Gravar__1711.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 8, 2022

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@jliexpensify
Copy link
Contributor

@kavimuru I'm actually not seeing this behaviour on my side (I'm also in Staging):

image

Can this be reliably reproduced? Videos would be great. Assigning back to you for further investigation.

@jliexpensify jliexpensify assigned kavimuru and unassigned jliexpensify Nov 8, 2022
@kavimuru
Copy link
Author

kavimuru commented Nov 8, 2022

@jliexpensify I can repro with CAD and the video already attached in the bug is for the currency UAH

Recording.872.mp4

@jliexpensify
Copy link
Contributor

@kavimuru thanks for the video - your reproduction steps were in the wrong order in the original issue so i fixed that.

But I've tested again, multiple times - I still can't reproduce. I'm still getting the same currency symbol for both requests:

image

@mvtglobally mvtglobally mentioned this issue Nov 9, 2022
Closed
34 tasks
@melvin-bot
Copy link

melvin-bot bot commented Nov 14, 2022

@kavimuru Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 16, 2022

@kavimuru 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Nov 18, 2022

@kavimuru Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Nov 22, 2022

@kavimuru 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 25, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 25, 2022

This issue has not been updated in over 14 days. @kavimuru eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2022
@jasperhuangg jasperhuangg self-assigned this Nov 28, 2022
@jasperhuangg
Copy link
Contributor

Hey guys, I can repro! @jliexpensify notice how the symbol changes from CA$ to C$ at roughly the 4 second mark on the money request report item in the background:

repro.mov

@jasperhuangg jasperhuangg added Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Nov 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

Triggered auto assignment to @strepanier03 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot changed the title IOU-Offline shows the name of the currency, after going online it shows the symbol of currency [$1000] IOU-Offline shows the name of the currency, after going online it shows the symbol of currency Nov 28, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@jasperhuangg
Copy link
Contributor

Good discussion happening in the Slack thread, this is not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@jasperhuangg
Copy link
Contributor

Ionatan and I are more or less on the same page now, just working on ideating a solution

@jasperhuangg
Copy link
Contributor

PR incoming...

@jasperhuangg jasperhuangg removed the Planning Changes still in the thought process label Dec 5, 2022
@jasperhuangg jasperhuangg mentioned this issue Dec 6, 2022
Closed
@jasperhuangg
Copy link
Contributor

Still working on that PR! Hope to have something tested up today!

@jasperhuangg jasperhuangg mentioned this issue Dec 8, 2022
Closed
48 tasks
@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Dec 8, 2022
@jasperhuangg
Copy link
Contributor

PRs up and ready for review!

@jasperhuangg
Copy link
Contributor

Realized the testing for #13432 is actually a lot more involved than I had previously assumed so I'm putting the PR back on draft while I iron out the testing steps and screen captures.

@jasperhuangg
Copy link
Contributor

PRs are both under review, I'm also in @iwiznia 's NewDot DMs to clarify a few things 👀

@jasperhuangg jasperhuangg reopened this Dec 14, 2022
@jasperhuangg jasperhuangg removed the Reviewing Has a PR in review label Dec 15, 2022
@jasperhuangg
Copy link
Contributor

Just a quick update on this one, more great discussion is happening here in Slack about the best approach to solve this issue. We may have to HOLD this on a separate issue that @aldo-expensify is working on, but as for now I'm gonna put the Planning label back on.

@jasperhuangg jasperhuangg added the Planning Changes still in the thought process label Dec 15, 2022
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 16, 2022
@jasperhuangg
Copy link
Contributor

This is solved in Aldo's PR! https://github.com/Expensify/Web-Expensify/pull/35845

@jasperhuangg jasperhuangg removed the Planning Changes still in the thought process label Dec 16, 2022
@jasperhuangg
Copy link
Contributor

@aldo-expensify assigning ya so you can also get credit on this!

@melvin-bot
Copy link

melvin-bot bot commented Dec 23, 2022

@jasperhuangg, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@aldo-expensify
Copy link
Contributor

Redoing the PHP API PR: https://github.com/Expensify/Web-Expensify/pull/35908

(Salt PR was salted adding the missing dependency)

@melvin-bot
Copy link

melvin-bot bot commented Jan 2, 2023

@jasperhuangg, @aldo-expensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jan 4, 2023

@jasperhuangg, @aldo-expensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@aldo-expensify
Copy link
Contributor

No overdue, the https://github.com/Expensify/Web-Expensify/pull/35908 is in staging

@jasperhuangg
Copy link
Contributor

https://github.com/Expensify/Web-Expensify/pull/35908 is on prod, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasperhuangg jasperhuangg

@aldo-expensify aldo-expensify

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mananjadhav @strepanier03 @jliexpensify @jasperhuangg @kavimuru @aldo-expensify