Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-11-08 #12563

Closed
34 tasks done
OSBotify opened this issue Nov 8, 2022 · 11 comments
Closed
34 tasks done

Deploy Checklist: New Expensify 2022-11-08 #12563

OSBotify opened this issue Nov 8, 2022 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Nov 8, 2022

Release Version: 1.2.25-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Nov 8, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Nov 8, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.25-0 🚀

@yuwenmemon
Copy link
Contributor

@mvtglobally Do you think we might have regression results by EOD US West Coast today? No worries if not, just trying to see what the rest of my day might entail.

@mvtglobally
Copy link

@yuwenmemon I think we are looking more like tomorrow morning EST

@mvtglobally
Copy link

Regression is completed. I am sending summary in a few

@mvtglobally
Copy link

mvtglobally commented Nov 9, 2022

@yuwenmemon

PR #11720 is failing #12573. Repro in prod checking off
PR #12142 is failing #12600. Repro in prod checking off
PR #12153 #12490 PROD QA. Ok to check off?
PR #12169 is failing #12598 & #12597 Repro in prod checking off
PR #12345 is failing due to #12592. Reproducible in prod
PR #12374 is failing due to #12590. It's NOt repro in prod, but because this is new due to PR we didn't add deploy blocker label
PR #12376 is failing #12594 repro in prod

@mvtglobally
Copy link

mvtglobally commented Nov 9, 2022

just 2 outstanding items - to summarize

PR #12153 #12490 PROD QA. Ok to check off?

PR #12374 is failing due to #12590. It's Not repro in prod, but because this is new due to PR we didn't add deploy blocker label

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Nov 9, 2022

PR #12153 #12490 PROD QA. Ok to check off?

Yeah, good to check off 👍 @marcochavezf and @johncschuster Could you just be sure to test on prod once it hits there?

@yuwenmemon
Copy link
Contributor

PR #12374 is failing due to #12590. It's Not repro in prod, but because this is new due to PR we didn't add deploy blocker label

@mvtglobally I just CP'd a fix for this about an hour ago - can we retest and check off if it's passing?

@mvtglobally
Copy link

@yuwenmemon issue is resolved on all but iOS. Not sure if iOS needs a build push to resolve the cache. ![Uploading 200936071...]

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Nov 9, 2022

@mvtglobally Just tested on my own on staging iOS and it's looking like it passed so checking it off! 🎉

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants