-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Draft messages jump around in the LHN #12313
Conversation
Changes look fine @rawalyogendra Thanks for the PR. I'll test them by today and update here. |
Change is fine, and tests well. I would just like to highlight that the chat goes to the top as soon as we type is the expected behavior here. @deetergp all yours. 🎀 👀 🎀
ScreenshotsWebweb-draft-messages-jump.movMobile Web - Chromemweb-chrome-draft-messages-jump.movMobile Web - Safarimweb-safari-draft-messages-jump.movDesktopdesktop-draft-messages-jump.moviOSios-draft-messages-jump.movAndroidandroid-draft-messages-jump.mov |
@deetergp looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@mananjadhav When you do the review checklist, don't forget to actually approve the PR in the review 😅 |
Noted @deetergp. Thank you! |
🚀 Deployed to production by @yuwenmemon in version: 1.2.25-0 🚀
|
Details
Fixed Issues
$ #11330
PROPOSAL: #11330 (comment)
Tests
QA Steps
PR Review Checklist
PR Author Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Screen.Recording.2022-11-01.at.12.44.46.AM.mov
Mobile Web - Chrome
Record_2022-11-01-01-52-58.mp4
Mobile Web - Safari
sim1.mp4
Desktop
Screen.Recording.2022-11-01.at.1.00.54.AM.1.mov
iOS
sim1.mp4
Android
Record_2022-11-01-00-35-25.mp4